FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Xubuntu User

 
 
LinkBack Thread Tools
 
Old 04-27-2012, 03:40 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

David Cantrell wrote:

Comments below.

On Fri, Apr 27, 2012 at 09:59:28AM -0500, d.marlin wrote:


From: "d.marlin" <dmarlin@redhat.com>

Signed-off-by: David A. Marlin <dmarlin@redhat.com>
---
pyanaconda/iutil.py | 36 ++++++++++++++++++++++++++++++++++++
pyanaconda/platform.py | 5 +++++
pyanaconda/yuminstall.py | 6 ++++++
3 files changed, 47 insertions(+), 0 deletions(-)

diff --git a/pyanaconda/iutil.py b/pyanaconda/iutil.py
index dd691dc..2864980 100644
--- a/pyanaconda/iutil.py
+++ b/pyanaconda/iutil.py
@@ -656,6 +656,42 @@ def getPPCMacBook():
return 1
return 0

+## Get the ARM processor variety.

+# @return The ARM processor variety type, or 0 if not ARM.
+def getARMMachine():
+ if not os.uname()[4].startswith('arm'):
+ return 0
+
+ armMachine = None
+ machine = None
+
+ # ARM machine hash
+ armType = {
+ 'OMAP3 Beagle Board' : 'omap',
+ 'OMAP4 Panda board' : 'omap',
+ 'trimslice' : 'tegra',
+ 'Marvell GuruPlug Reference Board' : 'kirkwood',
+ 'Efika MX' : 'imx',
+ 'Genesi Efika MX' : 'imx',
+ 'Genesi Efika MX (Smartbook)' : 'imx',
+ 'Highbank' : 'highbank',
+ }
+
+ f = open('/proc/cpuinfo', 'r')
+ lines = f.readlines()
+ f.close()
+ for line in lines:
+ if line.find('Hardware') != -1:
+ machine = line.split(':')[1]
+
+ if machine is not None:
+ for type in armType.items():
+ if machine.find(type[0]) != -1:
+ armMachine = type[1]
+
+ return armMachine



I really _really_ dislike things like the armType hash. I know we have it
for ppc, but none of us were consulted when those names were ending up in
the kernel and packages.

Is there no way to get the strings like omap, tegra, kirkwood, imx, and
highbank from /proc/cpuinfo -or- from somewhere else in /sys? And if not,
why? I would very much prefer that we just be able to extract that string
from some info the kernel provides than to carry this list which will need
updating, and probably a lot because it's ARM.

I understand and agree. I have not been able to find this information
any where else (yet). I will do some more checking and see if there's
anything I have overlooked. I know it is not available in
/proc/cpuinfo, and have not been able to find it anywhere in /sys. I
will dig some more.


+
+
cell = None
## Determine if the hardware is the Cell platform.
# @return True if so, False otherwise.
diff --git a/pyanaconda/platform.py b/pyanaconda/platform.py
index 335ab5c..5c6ddea 100644
--- a/pyanaconda/platform.py
+++ b/pyanaconda/platform.py
@@ -348,6 +348,7 @@ class Sparc(Platform):
return start+1

class ARM(Platform):

+ _armMachine = iutil.getARMMachine()
_bootloaderClass = bootloader.GRUB2
_boot_stage1_device_types = ["disk"]
_boot_mbr_description = N_("Master Boot Record")
@@ -356,6 +357,10 @@ class ARM(Platform):

_disklabel_types = ["msdos"]

+ @property

+ def armMachine(self):
+ return self._armMachine
+
def getPlatform(anaconda):
"""Check the architecture of the system and return an instance of a
Platform subclass to match. If the architecture could not be determined,
diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py
index 109daec..d762959 100644
--- a/pyanaconda/yuminstall.py
+++ b/pyanaconda/yuminstall.py
@@ -1452,6 +1452,12 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
if selectKernel("kernel-PAE"):
foundkernel = True

+ if not foundkernel and iutil.isARM():

+ armMachine = iutil.getARMMachine()
+ if armMachine is not None:
+ selectKernel("kernel-" + armMachine)



Yuck, but ok. Would be nice if a single kernel package could happen for
ARM. Maybe someday

There is an effort underway to unify several of the ARM kernel variants
by making use of Flattened Device Tree, but I'm afraid even merging the
most common platforms into a single kernel will still take some time.
Unfortunately, just building from a single code base is a recent
accomplishment, but progress is being made.


+ foundkernel = True
+
if not foundkernel:
selectKernel("kernel")

--

1.7.6.5

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list






_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-27-2012, 03:44 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

Matthew Garrett wrote:

On Fri, Apr 27, 2012 at 09:59:28AM -0500, d.marlin wrote:



+ if not os.uname()[4].startswith('arm'):
+ return 0



Just use isARM()?


Good point. I'll make that change.


+ 'OMAP3 Beagle Board' : 'omap',
+ 'OMAP4 Panda board' : 'omap',
+ 'trimslice' : 'tegra',
+ 'Marvell GuruPlug Reference Board' : 'kirkwood',
+ 'Efika MX' : 'imx',
+ 'Genesi Efika MX' : 'imx',
+ 'Genesi Efika MX (Smartbook)' : 'imx',
+ 'Highbank' : 'highbank',



Well ugh. Any chance of the kernel being able to expose this mapping,
since presumably it already exists there in some form?

Not that I have found. For more details, please see my response to David
Cantrel's comments.


d.marlin

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-12-2012, 06:25 AM
Martin Gracik
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

See the comments...


Signed-off-by: David A. Marlin <dmarlin@redhat.com>
---
diff --git a/pyanaconda/iutil.py b/pyanaconda/iutil.py
index 8fe818d..b0d9adc 100644
--- a/pyanaconda/iutil.py
+++ b/pyanaconda/iutil.py
@@ -621,6 +621,42 @@ def getPPCMacBook():
return 1
return 0

+## Get the ARM processor variety.
+# @return The ARM processor variety type, or 0 if not ARM.
+def getARMMachine():
+ if not isARM():
+ return 0
+
+ armMachine = None
+ machine = None
+
+ # ARM machine hash
+ armType = {
+ 'OMAP' : 'omap',
+ 'trimslice' : 'tegra',
+ 'Marvell Armada XP' : 'mvebu',
+ 'Marvell GuruPlug' : 'kirkwood',
+ 'Efika MX' : 'imx',
+ 'Highbank' : 'highbank',
+ }
+
+ f = open('/proc/cpuinfo', 'r')
+ lines = f.readlines()
+ f.close()
+ for line in lines:
+ if line.find('Hardware') != -1:
+ machine = line.split(':')[1]
+ break
+
+ if machine is not None:
+ for type in armType.items():
+ if machine.find(type[0]) != -1:
+ armMachine = type[1]
+ break

You could change this to:

with open('/proc/cpuinfo', 'r') as fobj:
for line in fobj:
if 'Hardware' in line:
machine = line.split(':')[1]
# we got the machine here, so we can get the armMachine as well...
# shouldn't the value we got in machine be the same as the keys in the arm machine hash? is the find here necessary?
armMachine = armType.get(machine, None)
break

I think it is clearer this way. I don't like the find() method.

+
+ return armMachine
+
+
cell = None
## Determine if the hardware is the Cell platform.
# @return True if so, False otherwise.
diff --git a/pyanaconda/platform.py b/pyanaconda/platform.py
index 8870374..1611797 100644
--- a/pyanaconda/platform.py
+++ b/pyanaconda/platform.py
@@ -335,6 +335,7 @@ class Sparc(Platform):
return start+1

class ARM(Platform):
+ _armMachine = iutil.getARMMachine()
_bootloaderClass = bootloader.GRUB2
_boot_stage1_device_types = ["disk"]
_boot_mbr_description = N_("Master Boot Record")
@@ -343,6 +344,10 @@ class ARM(Platform):

_disklabel_types = ["msdos"]

+ @property
+ def armMachine(self):
+ return self._armMachine
+
def getPlatform(anaconda):
"""Check the architecture of the system and return an instance of a
Platform subclass to match. If the architecture could not be determined,
diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py
index 0ca534b..63d077d 100644
--- a/pyanaconda/yuminstall.py
+++ b/pyanaconda/yuminstall.py
@@ -1465,6 +1465,11 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
if selectKernel("kernel-PAE"):
foundkernel = True

+ if not foundkernel and iutil.isARM():
+ if anaconda.platform.armMachine is not None:
+ selectKernel("kernel-" + anaconda.platform.armMachine)
+ foundkernel = True
+
if not foundkernel:
selectKernel("kernel")


----- Original Message -----
>
> Attached is my latest version of this patch. It was made against the
> current anaconda/master and applied to 17.29 for testing on F17.
>
> d.marlin
> ========
>
> David A. Marlin wrote:
> >
> > Attached is my latest version of the ARM processor variety patch.
> > It
> > incorporates suggestions made previously, and was made against
> > anaconda/master (but applied to 17.29 for testing).
> >
> > I simplified the hash/lookup by consolidating some machine types,
> > but
> > I understand this may still be unacceptable. I am currently
> > tracking
> > master and carrying these patches locally. I keep the rpms in a
> > local
> > repo for testing.
> >
> > We are working on a method of exposing the platform in userspace,
> > but
> > that is not in place yet. Would it be possible to accept this as
> > an
> > interim solution with the expressed intent that the hash would be
> > removed as soon as an alternative solution is available? If not,
> > would a version of this patch with the hash/lookup stubbed out be
> > acceptable? I would like to get as much of this upstream as
> > possible,
> > to minimize the patch(es) I need to carry locally and simplify
> > keeping
> > up with master. Any suggestions are appreciated.
> >
> > Note: We successfully completed a test kickstart install on an ARM
> > system today using the modified anaconda-17.29.
> >
> >
> > d.marlin
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Anaconda-devel-list mailing list
> > Anaconda-devel-list@redhat.com
> > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
>
>
>
> [Text
> Documents:Add-support-to-determine-the-ARM-processor-variety.patch]
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-12-2012, 01:46 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

Martin Gracik wrote:

See the comments...


Signed-off-by: David A. Marlin <dmarlin@redhat.com>
---
diff --git a/pyanaconda/iutil.py b/pyanaconda/iutil.py
index 8fe818d..b0d9adc 100644
--- a/pyanaconda/iutil.py
+++ b/pyanaconda/iutil.py
@@ -621,6 +621,42 @@ def getPPCMacBook():
return 1
return 0

+## Get the ARM processor variety.

+# @return The ARM processor variety type, or 0 if not ARM.
+def getARMMachine():
+ if not isARM():
+ return 0
+
+ armMachine = None
+ machine = None
+
+ # ARM machine hash
+ armType = {
+ 'OMAP' : 'omap',
+ 'trimslice' : 'tegra',
+ 'Marvell Armada XP' : 'mvebu',
+ 'Marvell GuruPlug' : 'kirkwood',
+ 'Efika MX' : 'imx',
+ 'Highbank' : 'highbank',
+ }
+
+ f = open('/proc/cpuinfo', 'r')
+ lines = f.readlines()
+ f.close()
+ for line in lines:
+ if line.find('Hardware') != -1:
+ machine = line.split(':')[1]
+ break
+
+ if machine is not None:
+ for type in armType.items():
+ if machine.find(type[0]) != -1:
+ armMachine = type[1]
+ break

You could change this to:

with open('/proc/cpuinfo', 'r') as fobj:
for line in fobj:
if 'Hardware' in line:
machine = line.split(':')[1]
# we got the machine here, so we can get the armMachine as well...
# shouldn't the value we got in machine be the same as the keys in the arm machine hash? is the find here necessary?



The 'machine' from '/proc/cpuinfo' is not always an exact match for the
keys in the arm machine hash, for example 'OMAP' matches 'OMAP3' and
'OMAP4'. I used 'find' in order to minimize the hash map size and
provide the flexibility to support additional variants from a given
vendor without modifying the code.


d.marlin
========


armMachine = armType.get(machine, None)
break

I think it is clearer this way. I don't like the find() method.

+
+ return armMachine
+
+
cell = None
## Determine if the hardware is the Cell platform.
# @return True if so, False otherwise.
diff --git a/pyanaconda/platform.py b/pyanaconda/platform.py
index 8870374..1611797 100644
--- a/pyanaconda/platform.py
+++ b/pyanaconda/platform.py
@@ -335,6 +335,7 @@ class Sparc(Platform):
return start+1

class ARM(Platform):

+ _armMachine = iutil.getARMMachine()
_bootloaderClass = bootloader.GRUB2
_boot_stage1_device_types = ["disk"]
_boot_mbr_description = N_("Master Boot Record")
@@ -343,6 +344,10 @@ class ARM(Platform):

_disklabel_types = ["msdos"]

+ @property

+ def armMachine(self):
+ return self._armMachine
+
def getPlatform(anaconda):
"""Check the architecture of the system and return an instance of a
Platform subclass to match. If the architecture could not be determined,
diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py
index 0ca534b..63d077d 100644
--- a/pyanaconda/yuminstall.py
+++ b/pyanaconda/yuminstall.py
@@ -1465,6 +1465,11 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
if selectKernel("kernel-PAE"):
foundkernel = True

+ if not foundkernel and iutil.isARM():

+ if anaconda.platform.armMachine is not None:
+ selectKernel("kernel-" + anaconda.platform.armMachine)
+ foundkernel = True
+
if not foundkernel:
selectKernel("kernel")



----- Original Message -----


Attached is my latest version of this patch. It was made against the
current anaconda/master and applied to 17.29 for testing on F17.

d.marlin
========

David A. Marlin wrote:


Attached is my latest version of the ARM processor variety patch.
It
incorporates suggestions made previously, and was made against
anaconda/master (but applied to 17.29 for testing).

I simplified the hash/lookup by consolidating some machine types,
but
I understand this may still be unacceptable. I am currently
tracking
master and carrying these patches locally. I keep the rpms in a
local
repo for testing.

We are working on a method of exposing the platform in userspace,
but
that is not in place yet. Would it be possible to accept this as
an
interim solution with the expressed intent that the hash would be
removed as soon as an alternative solution is available? If not,
would a version of this patch with the hash/lookup stubbed out be
acceptable? I would like to get as much of this upstream as
possible,
to minimize the patch(es) I need to carry locally and simplify
keeping
up with master. Any suggestions are appreciated.

Note: We successfully completed a test kickstart install on an ARM
system today using the modified anaconda-17.29.


d.marlin

------------------------------------------------------------------------

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list



[Text
Documents:Add-support-to-determine-the-ARM-processor-variety.patch]

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list




------------------------------------------------------------------------


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-12-2012, 01:48 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

Vratislav Podzimek wrote:

Note that we are now sending the patches for a review to
anaconda-patches@lists.fedorahosted.org mailing list.

Thank you for the information. I will send all future patches to
anaconda-patches@lists.fedorahosted.org.


d.marlin
========

On Wed, 2012-07-11 at 15:01 -0500, David A. Marlin wrote:

Attached is my latest version of this patch. It was made against the
current anaconda/master and applied to 17.29 for testing on F17.


d.marlin
========

David A. Marlin wrote:

Attached is my latest version of the ARM processor variety patch. It
incorporates suggestions made previously, and was made against
anaconda/master (but applied to 17.29 for testing).


I simplified the hash/lookup by consolidating some machine types, but
I understand this may still be unacceptable. I am currently tracking
master and carrying these patches locally. I keep the rpms in a local
repo for testing.


We are working on a method of exposing the platform in userspace, but
that is not in place yet. Would it be possible to accept this as an
interim solution with the expressed intent that the hash would be
removed as soon as an alternative solution is available? If not,
would a version of this patch with the hash/lookup stubbed out be
acceptable? I would like to get as much of this upstream as possible,
to minimize the patch(es) I need to carry locally and simplify keeping
up with master. Any suggestions are appreciated.


Note: We successfully completed a test kickstart install on an ARM
system today using the modified anaconda-17.29.



d.marlin

------------------------------------------------------------------------

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


differences between files attachment
(Add-support-to-determine-the-ARM-processor-variety.patch)
Signed-off-by: David A. Marlin <dmarlin@redhat.com>
---
diff --git a/pyanaconda/iutil.py b/pyanaconda/iutil.py
index 8fe818d..b0d9adc 100644
--- a/pyanaconda/iutil.py
+++ b/pyanaconda/iutil.py
@@ -621,6 +621,42 @@ def getPPCMacBook():
return 1
return 0

+## Get the ARM processor variety.

+# @return The ARM processor variety type, or 0 if not ARM.
+def getARMMachine():
+ if not isARM():
+ return 0
+
+ armMachine = None
+ machine = None
+
+ # ARM machine hash
+ armType = {
+ 'OMAP' : 'omap',
+ 'trimslice' : 'tegra',
+ 'Marvell Armada XP' : 'mvebu',
+ 'Marvell GuruPlug' : 'kirkwood',
+ 'Efika MX' : 'imx',
+ 'Highbank' : 'highbank',
+ }
+
+ f = open('/proc/cpuinfo', 'r')
+ lines = f.readlines()
+ f.close()
+ for line in lines:
+ if line.find('Hardware') != -1:
+ machine = line.split(':')[1]
+ break
+
+ if machine is not None:
+ for type in armType.items():
+ if machine.find(type[0]) != -1:
+ armMachine = type[1]
+ break
+
+ return armMachine
+
+
cell = None
## Determine if the hardware is the Cell platform.
# @return True if so, False otherwise.
diff --git a/pyanaconda/platform.py b/pyanaconda/platform.py
index 8870374..1611797 100644
--- a/pyanaconda/platform.py
+++ b/pyanaconda/platform.py
@@ -335,6 +335,7 @@ class Sparc(Platform):
return start+1

class ARM(Platform):

+ _armMachine = iutil.getARMMachine()
_bootloaderClass = bootloader.GRUB2
_boot_stage1_device_types = ["disk"]
_boot_mbr_description = N_("Master Boot Record")
@@ -343,6 +344,10 @@ class ARM(Platform):

_disklabel_types = ["msdos"]

+ @property

+ def armMachine(self):
+ return self._armMachine
+
def getPlatform(anaconda):
"""Check the architecture of the system and return an instance of a
Platform subclass to match. If the architecture could not be determined,
diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py
index 0ca534b..63d077d 100644
--- a/pyanaconda/yuminstall.py
+++ b/pyanaconda/yuminstall.py
@@ -1465,6 +1465,11 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
if selectKernel("kernel-PAE"):
foundkernel = True

+ if not foundkernel and iutil.isARM():

+ if anaconda.platform.armMachine is not None:
+ selectKernel("kernel-" + anaconda.platform.armMachine)
+ foundkernel = True
+
if not foundkernel:
selectKernel("kernel")

_______________________________________________

Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list







_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-12-2012, 06:45 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

Matthew Garrett wrote:
In the common case we're going to be running Anaconda under a Fedora
kernel, so we should already have the kernel packaging name in the uname
output from EXTRAVERSION - presumably we can just parse that out and use
it to detemrine the package name? You'd want a way to manually override
that for bootstrapping, but that might well be a desirable feature
anyway.

Yes, we can parse the platform from a Fedora kernel, but I was concerned
about the possible situation where we were not running a Fedora kernel.
A command line option to override the platform sounds like a good option
there, and it would also permit us to build images for a target other
than the build host.


I would appreciate suggestions on how to implement the command line
option. I think this would most likely be needed when running
livemedia-creator to create disk images. Currently I create the images
using:


livemedia-creator
--make-disk --no-virt --image-only --keep-image
--ks=/root/f17-TS-hfp.ks

Should we add a command line option, like "--platform=...", to
livemedia-creator? Would we also need a command line option for
anaconda itself?



Thank you,

d.marlin

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-13-2012, 05:46 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

Matthew Garrett wrote:
In the common case we're going to be running Anaconda under a Fedora
kernel, so we should already have the kernel packaging name in the uname
output from EXTRAVERSION - presumably we can just parse that out and use
it to detemrine the package name? You'd want a way to manually override
that for bootstrapping, but that might well be a desirable feature
anyway.



I am sending an updated version of this patch to the
anaconda-patches@lists.fedorahosted.org mailing list for review. It
only addresses the first part of the suggested solution (parse uname to
get the platform). I talked with Dennis Gilmore, and he said he has
been working on a command line option for livemedia-creator to override
the platform, so if this patch is acceptable he can follow up with a
second patch to handle that.


Please let me know if you have any additional suggestions for improvement.


Thank you,

d.marlin

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-20-2012, 04:06 PM
"David A. Marlin"
 
Default Add support to determine the ARM processor variety and select the correct kernel to install.

David A. Marlin wrote:

Matthew Garrett wrote:
In the common case we're going to be running Anaconda under a Fedora
kernel, so we should already have the kernel packaging name in the
uname output from EXTRAVERSION - presumably we can just parse that
out and use it to detemrine the package name? You'd want a way to
manually override that for bootstrapping, but that might well be a
desirable feature anyway.



I am sending an updated version of this patch to the
anaconda-patches@lists.fedorahosted.org mailing list for review. It
only addresses the first part of the suggested solution (parse uname
to get the platform). I talked with Dennis Gilmore, and he said he
has been working on a command line option for livemedia-creator to
override the platform, so if this patch is acceptable he can follow up
with a second patch to handle that.


Please let me know if you have any additional suggestions for
improvement.
I have been following the archives on anaconda-patches, but have not
seen any comments or feedback on:


https://fedorahosted.org/pipermail/anaconda-patches/2012-July/000140.html

If this patch is acceptable, please apply and push to anaconda/master.

Note: I have now subscribed to the anaconda-patches email list as well,
and can continue the discussion there, if preferred.



Thank you,

d.marlin
========




Thank you,

d.marlin

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 04:35 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org