FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu User

 
 
LinkBack Thread Tools
 
Old 07-21-2011, 05:36 PM
"Brian C. Lane"
 
Default Check the format of /boot when using EFI (#689996)

On EFI /boot needs to be on an extX filesystem.
Add the error to the partitioning sanity check.

Resolves: rhbz#689996

NOTE: This has been tested with EFI on USB boot media and DVD, as well as in a KVM
---
platform.py | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/platform.py b/platform.py
index e139033..bdb2357 100644
--- a/platform.py
+++ b/platform.py
@@ -244,8 +244,14 @@ class EFI(Platform):
if req.format.type != "efi":
errors.append(_("/boot/efi is not EFI."))

- # Don't try to check the disklabel on lv's etc, using lv for /boot
- # is already checked in the generic Platform.checkBootRequest()
+ # EFI also needs /boot to be on an extX partition, either as its own
+ # partition or with / on extX. Get the format of whatever /boot is on
+ mntDict = self._mntDict()
+ boot_device = mntDict.get("/boot", mntDict.get("/"))
+ boot_errors = Platform.checkBootRequest(self, boot_device)
+ errors += boot_errors
+
+ # Don't try to check the disklabel on lv's etc.
partitions = []
if req.type == "partition":
partitions = [ req ]
--
1.7.4.4

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-21-2011, 06:30 PM
"Brian C. Lane"
 
Default Check the format of /boot when using EFI (#689996)

On Thu, Jul 21, 2011 at 10:36:04AM -0700, Brian C. Lane wrote:

Note that this is for RHEL6.

--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 07-22-2011, 07:39 PM
Chris Lumens
 
Default Check the format of /boot when using EFI (#689996)

> diff --git a/platform.py b/platform.py
> index e139033..bdb2357 100644
> --- a/platform.py
> +++ b/platform.py
> @@ -244,8 +244,14 @@ class EFI(Platform):
> if req.format.type != "efi":
> errors.append(_("/boot/efi is not EFI."))
>
> - # Don't try to check the disklabel on lv's etc, using lv for /boot
> - # is already checked in the generic Platform.checkBootRequest()
> + # EFI also needs /boot to be on an extX partition, either as its own
> + # partition or with / on extX. Get the format of whatever /boot is on
> + mntDict = self._mntDict()
> + boot_device = mntDict.get("/boot", mntDict.get("/"))
> + boot_errors = Platform.checkBootRequest(self, boot_device)
> + errors += boot_errors
> +
> + # Don't try to check the disklabel on lv's etc.
> partitions = []
> if req.type == "partition":
> partitions = [ req ]

This looks okay to me, though I admit I'm not all that familiar with the
problem.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 08:05 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org