As previously promised, here's my patches to use pykickstart inside loader. I
have tested the kickstart.c parts by adding a separate patch that allows
building a standalone executable (can merge as well if anyone cares), but not
of the patch set as a whole.

These fix bug 667526, though that was not my main motivation here.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Thu, 20 Jan 2011, Chris Lumens wrote:


As previously promised, here's my patches to use pykickstart inside loader. I
have tested the kickstart.c parts by adding a separate patch that allows
building a standalone executable (can merge as well if anyone cares), but not
of the patch set as a whole.

These fix bug 667526, though that was not my main motivation here.


Ack to them all, with the comment that the code that creates C-bindings
for pykickstart should maybe be part of pykickstart rather than loader.
That may or may not be possible, but if any of the functions of generic
enough to warrant a libpykickstart as part of the pykickstart package, I
think that would be better for maintenance in the future.

All in all, I like the patch set. It's nice to eliminate another
pykickstart parser.

--
David Cantrell <dcantrell@redhat.com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Honolulu, HI | UTC-10

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> Ack to them all, with the comment that the code that creates C-bindings
> for pykickstart should maybe be part of pykickstart rather than loader.
> That may or may not be possible, but if any of the functions of generic
> enough to warrant a libpykickstart as part of the pykickstart package, I
> think that would be better for maintenance in the future.

Yeah, moving into pykickstart does make a lot of sense. It's going to
make pykickstart a non-noarch package, and will require me to rework a
lot of those general functions I think. I wasn't terribly careful with
the API there given that it's all static internal loader stuff I hope to
one day kill anyway. For moving into pykickstart, real design will be
required.

I'll push this now and then start working on moving into pykickstart
later, probably after FUDCon.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list