FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu User

 
 
LinkBack Thread Tools
 
Old 11-23-2009, 08:54 PM
Chris Lumens
 
Default Only check for DEVICE_DASD in S390.diskLabelType, not for all platforms.

---
platform.py | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/platform.py b/platform.py
index 62260da..2a4b9ea 100644
--- a/platform.py
+++ b/platform.py
@@ -141,9 +141,6 @@ class Platform(object):

def diskLabelType(self, deviceType):
"""Return the disk label type as a parted.DiskType."""
- if deviceType == parted.DEVICE_DASD:
- return parted.diskType["dasd"]
-
return self._diskLabelType

@property
@@ -441,6 +438,13 @@ class S390(Platform):
def __init__(self, anaconda):
Platform.__init__(self, anaconda)

+ def diskLabelType(self, deviceType):
+ """Return the disk label type as a parted.DiskType."""
+ if deviceType == parted.DEVICE_DASD:
+ return parted.diskType["dasd"]
+ else:
+ return Platform.diskLabelType(self, deviceType)
+
class Sparc(Platform):
_diskLabelType = parted.diskType["sun"]

--
1.6.5.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 11-24-2009, 07:09 AM
Ales Kozumplik
 
Default Only check for DEVICE_DASD in S390.diskLabelType, not for all platforms.

On 11/23/2009 10:54 PM, Chris Lumens wrote:

---
platform.py | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/platform.py b/platform.py
index 62260da..2a4b9ea 100644
--- a/platform.py
+++ b/platform.py
@@ -141,9 +141,6 @@ class Platform(object):

def diskLabelType(self, deviceType):
"""Return the disk label type as a parted.DiskType."""
- if deviceType == parted.DEVICE_DASD:
- return parted.diskType["dasd"]
-
return self._diskLabelType

@property
@@ -441,6 +438,13 @@ class S390(Platform):
def __init__(self, anaconda):
Platform.__init__(self, anaconda)

+ def diskLabelType(self, deviceType):
+ """Return the disk label type as a parted.DiskType."""
+ if deviceType == parted.DEVICE_DASD:
+ return parted.diskType["dasd"]
+ else:
+ return Platform.diskLabelType(self, deviceType)
+
class Sparc(Platform):
_diskLabelType = parted.diskType["sun"]



Looks good to me.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:21 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org