FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu User

 
 
LinkBack Thread Tools
 
Old 11-10-2009, 01:39 AM
David Cantrell
 
Default Honor existing RUNKS conf file variable on s390 (#513951).

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 9 Nov 2009, Jeremy Katz wrote:


On Mon, Nov 9, 2009 at 6:47 PM, David Cantrell <dcantrell@redhat.com> wrote:

The linuxrc.s390 rewrite changed the behavior of RUNKS on RHEL-5. *We've
done away with RUNKS on RHEL-6, but we still need to maintain existing
functionality on RHEL-5.


To minimize the deltas between RHEL5 and RHEL6, would it make sense to
just have something like
if [ "$RUNKS" = "0" ]; then RUNKS="" ; fi
at the top of the script?

Looks fine in any case, just minor nitpicking to save effort on
keeping the two in sync.


Yeah, how about:

- ---
loader2/linuxrc.s390 | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/loader2/linuxrc.s390 b/loader2/linuxrc.s390
index 5dec01d..2856f96 100644
- --- a/loader2/linuxrc.s390
+++ b/loader2/linuxrc.s390
@@ -52,6 +52,10 @@ unset testing
# uncomment the following test="1" to never execute sensitive commands
#testing="1"

+if [ "$RUNKS" = "0" ]; then
+ RUNKS=""
+fi
+
# helper function to disable commands while running outside the initrd
function tv() {
if [ -z "$testing" ]; then
- --
1.6.5.2


Woo.

- --
David Cantrell <dcantrell@redhat.com>

Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkr40nMACgkQ5hsjjIy1Vkn9FwCfUBWgXmoLM+ jvcWiBOwwtOvJ/
PmkAoIqpZH/wbe1dhpXT14E+8wjykBCe
=KA1Q
-----END PGP SIGNATURE-----_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 06:32 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org