FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu User

 
 
LinkBack Thread Tools
 
Old 11-06-2009, 01:19 PM
Chris Lumens
 
Default Don't activate / de-activate dmraid sets on setup / teardown

> diff --git a/storage/devices.py b/storage/devices.py
> index bc8951f..7b4b314 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2682,34 +2682,19 @@ class DMRaidArrayDevice(DiskDevice):
> else:
> self.sysfsPath = '
>
> - def teardown(self, recursive=None):
> - """ Close, or tear down, a device. """
> + def deactivate(self):
> + """ Deactivate the raid set. """

Aren't we still going to end up getting DiskDevice.teardown called for
these devices in some loop somewhere? Same for setup.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 11-06-2009, 01:26 PM
Hans de Goede
 
Default Don't activate / de-activate dmraid sets on setup / teardown

Hi,

On 11/06/2009 03:19 PM, Chris Lumens wrote:

diff --git a/storage/devices.py b/storage/devices.py
index bc8951f..7b4b314 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -2682,34 +2682,19 @@ class DMRaidArrayDevice(DiskDevice):
else:
self.sysfsPath = '

- def teardown(self, recursive=None):
- """ Close, or tear down, a device. """
+ def deactivate(self):
+ """ Deactivate the raid set. """


Aren't we still going to end up getting DiskDevice.teardown called for
these devices in some loop somewhere? Same for setup.



Ah, yes I forgot to put that in the commit message, yes this change means
that setup() and teardown() no get replaced with the ones from the super,
which in case of a recursive teardown means the members (parents) of the
set will have there teardown() called, since these parents are of
type StorageDevice, the teardown is a no-op.

I already checked using the super's setup() / teardown() would not
cause any issues, but I forgot to put this in the commit msg :|

Regards,

Hans





- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 06:50 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org