FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu User

 
 
LinkBack Thread Tools
 
Old 01-19-2009, 12:42 PM
Hans de Goede
 
Default PATCH: fix intel isw raid 0 and 1 in Fedora

Hi All,

This is a forward port of a RHEL-5 patch by Joel, with a pyblock compiled with
this patch in an updates.img I can successfully install F-10 on an intel isw
dmraid 0 system.


Regards,

Hans
--- pyblock-0.32-new/dmraid.c 2006-07-26 16:58:22.000000000 +0200
+++ pyblock-0.32/dmraid.c 2008-10-17 19:32:30.000000000 +0200
@@ -1245,10 +1245,18 @@
}

Py_DECREF(name);
- if (!group_set(ctx->lc, &rd->name)) {
- pyblock_PyErr_Format(GroupingError, "%s", rd->name);
- Py_DECREF(dict);
- return NULL;
+ if (!group_set(ctx->lc, &rd->name)) {
+ /*
+ * This means that whatever was in name did not
+ * play well with current context. lest try
+ * a NULL list.
+ */
+ char *temp[] = {NULL};
+ if (!group_set(ctx->lc, temp)){
+ pyblock_PyErr_Format(GroupingError, "%s", rd->name);
+ Py_DECREF(dict);
+ return NULL;
+ }
}
Py_DECREF(dict);
}
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-19-2009, 01:06 PM
Joel Granados
 
Default PATCH: fix intel isw raid 0 and 1 in Fedora

This looks pretty similar to what I did in rhel5. Though I thought that for fedora we could do something different (less patchy) I'm going to give this the goahead with the knowledge that it will probably change in the future.

regards.
----- "Hans de Goede" <hdegoede@redhat.com> wrote:

> Hi All,
>
> This is a forward port of a RHEL-5 patch by Joel, with a pyblock
> compiled with
> this patch in an updates.img I can successfully install F-10 on an
> intel isw
> dmraid 0 system.
>
> Regards,
>
> Hans
>
> --- pyblock-0.32-new/dmraid.c 2006-07-26 16:58:22.000000000 +0200
> +++ pyblock-0.32/dmraid.c 2008-10-17 19:32:30.000000000 +0200
> @@ -1245,10 +1245,18 @@
> }
>
> Py_DECREF(name);
> - if (!group_set(ctx->lc, &rd->name)) {
> - pyblock_PyErr_Format(GroupingError, "%s", rd->name);
> - Py_DECREF(dict);
> - return NULL;
> + if (!group_set(ctx->lc, &rd->name)) {
> + /*
> + * This means that whatever was in name did not
> + * play well with current context. lest try
> + * a NULL list.
> + */
> + char *temp[] = {NULL};
> + if (!group_set(ctx->lc, temp)){
> + pyblock_PyErr_Format(GroupingError, "%s", rd->name);
> + Py_DECREF(dict);
> + return NULL;
> + }
> }
> Py_DECREF(dict);
> }
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Joel Andres Granados
Red Hat / Brno Czech Republic

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-19-2009, 01:21 PM
Jeremy Katz
 
Default PATCH: fix intel isw raid 0 and 1 in Fedora

On Monday, January 19 2009, Hans de Goede said:
> This is a forward port of a RHEL-5 patch by Joel, with a pyblock compiled
> with this patch in an updates.img I can successfully install F-10 on an
> intel isw dmraid 0 system.

Looks okay. We should also get in your change so that we can run
pychecker as non-root

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-19-2009, 01:49 PM
Hans de Goede
 
Default PATCH: fix intel isw raid 0 and 1 in Fedora

Jeremy Katz wrote:

On Monday, January 19 2009, Hans de Goede said:
This is a forward port of a RHEL-5 patch by Joel, with a pyblock compiled
with this patch in an updates.img I can successfully install F-10 on an
intel isw dmraid 0 system.


Looks okay. We should also get in your change so that we can run
pychecker as non-root



Yeah I already was one that, its time to get the anaconda specfile to
automatically run the pychecker script, so that we can catch (some) syntax
errors early.


Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 12:47 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org