Install udevd and required rules on the stage1 initrd. Remove obsolete /var/state directory.

12-05-2007, 10:24 PM

---
scripts/mk-images | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/scripts/mk-images b/scripts/mk-images
index 006314f..fc70f56 100755
--- a/scripts/mk-images
+++ b/scripts/mk-images
@@ -567,7 +567,7 @@ makeinitrd() {
mkdir -p $MBD_DIR/sys
mkdir -p $MBD_DIR/tmp
mkdir -p $MBD_DIR/etc/terminfo/{a,b,d,l,s,v,x}
- mkdir -p $MBD_DIR/var/state
+ mkdir -p $MBD_DIR/etc/udev/rules.d
mkdir -p $MBD_DIR/var/run
mkdir -p $MBD_DIR/var/lock/rpm

@@ -651,6 +651,13 @@ EOF
fi
install -m 644 $MYLANGTABLE $MBD_DIR/etc/lang-table

+ install -s -m 755 $IMGPATH/usr/sbin/udevd.static $MBD_DIR/sbin/udevd
+ install -m 644 $IMGPATH/etc/udev/udev.conf $MBD_DIR/etc/udev/udev.conf
+ for i in 05-udev-early.rules 40-redhat.rules 50-udev-default.rules 64-device-mapper.rules 64-md-raid.rules 80-drivers.rules 95-udev-late.rules ; do
+ [ -f $IMGPATH/etc/udev/rules.d/$i ] &&
+ install -m 644 $IMGPATH/etc/udev/rules.d/$i $MBD_DIR/etc/udev/rules.d/$i
+ done
+
install -m 644 $LOADERBINDIR/$MYLOADERTR $MBD_DIR/etc/loader.tr
for i in a/ansi d/dumb l/linux s/screen v/vt100 v/vt100-nav v/vt102 x/xterm x/xterm-color g/gnome ; do
[ -f $IMGPATH/usr/share/terminfo/$i ] &&
--
1.5.3.4

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

12-06-2007, 03:53 PM

On Wed, 2007-12-05 at 18:24 -0500, Bill Nottingham wrote:
> + for i in 05-udev-early.rules 40-redhat.rules
> 50-udev-default.rules 64-device-mapper.rules 64-md-raid.rules
> 80-drivers.rules 95-udev-late.rules ;

This is going to be incredibly fragile as there's nothing that says the
rule names are going to stay the same over time and I've already seen
the name of 50-udev-default.rules change once in the past six months.
Any real reason not to just take everything?

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

12-06-2007, 04:02 PM

Jeremy Katz (katzj@redhat.com) said:
> On Wed, 2007-12-05 at 18:24 -0500, Bill Nottingham wrote:
> > + for i in 05-udev-early.rules 40-redhat.rules
> > 50-udev-default.rules 64-device-mapper.rules 64-md-raid.rules
> > 80-drivers.rules 95-udev-late.rules ;
>
> This is going to be incredibly fragile as there's nothing that says the
> rule names are going to stay the same over time and I've already seen
> the name of 50-udev-default.rules change once in the past six months.
> Any real reason not to just take everything?

Fewer meaningless errors from rules that we don't care about. But we certainly
could take everything.

Bill

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

12-06-2007, 04:09 PM

On Thu, 2007-12-06 at 12:02 -0500, Bill Nottingham wrote:
> Jeremy Katz (katzj@redhat.com) said:
> > On Wed, 2007-12-05 at 18:24 -0500, Bill Nottingham wrote:
> > > + for i in 05-udev-early.rules 40-redhat.rules
> > > 50-udev-default.rules 64-device-mapper.rules 64-md-raid.rules
> > > 80-drivers.rules 95-udev-late.rules ;
> >
> > This is going to be incredibly fragile as there's nothing that says the
> > rule names are going to stay the same over time and I've already seen
> > the name of 50-udev-default.rules change once in the past six months.
> > Any real reason not to just take everything?
>
> Fewer meaningless errors from rules that we don't care about. But we certainly
> could take everything.

What type of errors? Also, I'd be fine with not taking everything, but
only if we're auto-detecting when to leave something out (rather than
the hardcoded list)

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

12-06-2007, 04:19 PM

Jeremy Katz (katzj@redhat.com) said:
> What type of errors?

Generally, RUN commands failing due to no volume_id, etc. (for making
/dev/by-id/... that we don't care about.

Bill

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

12-06-2007, 08:19 PM

Bill Nottingham (notting@redhat.com) said:
> Jeremy Katz (katzj@redhat.com) said:
> > What type of errors?
>
> Generally, RUN commands failing due to no volume_id, etc. (for making
> /dev/by-id/... that we don't care about.

Updated patchset:

commit 4b6eae5024035b3ca7313e23eee2baaf2ddd6cec
Author: Bill Nottingham <notting@redhat.com>
Date: Thu Dec 6 16:15:43 2007 -0500

Install udevd and required rules on the stage1 initrd. Remove obsolete /var/state directory.

diff --git a/scripts/mk-images b/scripts/mk-images
index 55c82f5..e3fe908 100755
--- a/scripts/mk-images
+++ b/scripts/mk-images
@@ -557,7 +557,7 @@ makeinitrd() {
mkdir -p $MBD_DIR/sys
mkdir -p $MBD_DIR/tmp
mkdir -p $MBD_DIR/etc/terminfo/{a,b,d,l,s,v,x}
- mkdir -p $MBD_DIR/var/state
+ mkdir -p $MBD_DIR/etc/udev/rules.d
mkdir -p $MBD_DIR/var/run
mkdir -p $MBD_DIR/var/lock/rpm

@@ -639,6 +639,14 @@ makeinitrd() {
install -m 644 $IMGPATH/etc/passwd $MBD_DIR/etc/passwd
install -m 644 $IMGPATH/etc/group $MBD_DIR/etc/group

+ install -s -m 755 $IMGPATH/usr/sbin/udevd.static $MBD_DIR/sbin/udevd
+ install -m 644 $IMGPATH/etc/udev/udev.conf $MBD_DIR/etc/udev/udev.conf
+ for i in $IMGPATH/etc/udev/rules.d/* ; do
+ install -m 644 $i $IMGPATH/etc/udev/rules.d/$i $MBD_DIR/etc/udev/rules.d/${i##*/}
+ done
+ rm -f $MBD_DIR/etc/udev/rules.d/*persistent*
+ rm -f $MBD_DIR/etc/udev/rules.d/*generator*
+
install -m 644 $LOADERBINDIR/$MYLOADERTR $MBD_DIR/etc/loader.tr
for i in a/ansi d/dumb l/linux s/screen v/vt100 v/vt100-nav v/vt102 x/xterm x/xterm-color g/gnome ; do
[ -f $IMGPATH/usr/share/terminfo/$i ] &&

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

12-06-2007, 09:13 PM

On Thu, 2007-12-06 at 16:19 -0500, Bill Nottingham wrote:
> Bill Nottingham (notting@redhat.com) said:
> > Jeremy Katz (katzj@redhat.com) said:
> > > What type of errors?
> >
> > Generally, RUN commands failing due to no volume_id, etc. (for making
> > /dev/by-id/... that we don't care about.
>
> Updated patchset:

Seems at least less likely to break. One of these days, maybe we can
get a useful breakout of "minimal rules" and "crazy crack rules" from
udev. And, you know, maybe build the useful ones in

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list