FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Studio User

 
 
LinkBack Thread Tools
 
Old 12-09-2009, 05:28 PM
Ales Kozumplik
 
Default Fixes problems in the manual network configuration screen in loader with IPv6.

A crash occurs after the IPv6 GUI has been enabled when we chose to configure
the network device manually. When the crash is fixed the screen still does not
appear. This patch fixes both the problems.
---
isys/iface.h | 2 +-
loader/net.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/isys/iface.h b/isys/iface.h
index 3f97935..820d10b 100644
--- a/isys/iface.h
+++ b/isys/iface.h
@@ -29,7 +29,7 @@
#include <glib.h>

/* Enumerated types used in iface.c as well as loader's network code */
-enum { IPUNUSED, IPV4, IPV6 };
+enum { IPUNUSED = -1, IPV4, IPV6 };

enum { IPV4_UNUSED_METHOD, IPV4_DHCP_METHOD, IPV4_MANUAL_METHOD, IPV4_IBFT_METHOD, IPV4_IBFT_DHCP_METHOD };
enum { IPV6_UNUSED_METHOD, IPV6_AUTO_METHOD, IPV6_DHCP_METHOD,
diff --git a/loader/net.c b/loader/net.c
index c3a6a75..75c1872 100644
--- a/loader/net.c
+++ b/loader/net.c
@@ -929,7 +929,7 @@ int manualNetConfig(char * device, iface_t * iface,
}

/* run the form */
- while ((have[IPV4] != 2) && (have[IPV6] != 2)) {
+ while ((have[IPV4] != 2) || (have[IPV6] != 2)) {
answer = newtRunForm(f);

/* collect IPv4 data */
--
1.6.2.5

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-07-2010, 05:41 PM
David Cantrell
 
Default Fixes problems in the manual network configuration screen in loader with IPv6.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 9 Dec 2009, Ales Kozumplik wrote:


A crash occurs after the IPv6 GUI has been enabled when we chose to configure
the network device manually. When the crash is fixed the screen still does not
appear. This patch fixes both the problems.
---
isys/iface.h | 2 +-
loader/net.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/isys/iface.h b/isys/iface.h
index 3f97935..820d10b 100644
--- a/isys/iface.h
+++ b/isys/iface.h
@@ -29,7 +29,7 @@
#include <glib.h>

/* Enumerated types used in iface.c as well as loader's network code */
-enum { IPUNUSED, IPV4, IPV6 };
+enum { IPUNUSED = -1, IPV4, IPV6 };

enum { IPV4_UNUSED_METHOD, IPV4_DHCP_METHOD, IPV4_MANUAL_METHOD, IPV4_IBFT_METHOD, IPV4_IBFT_DHCP_METHOD };
enum { IPV6_UNUSED_METHOD, IPV6_AUTO_METHOD, IPV6_DHCP_METHOD,
diff --git a/loader/net.c b/loader/net.c
index c3a6a75..75c1872 100644
--- a/loader/net.c
+++ b/loader/net.c
@@ -929,7 +929,7 @@ int manualNetConfig(char * device, iface_t * iface,
}

/* run the form */
- while ((have[IPV4] != 2) && (have[IPV6] != 2)) {
+ while ((have[IPV4] != 2) || (have[IPV6] != 2)) {
answer = newtRunForm(f);

/* collect IPv4 data */



This one is good to go now. I didn't catch you before you left for the day,
so I did a git am on this email so it's in master now.

- --
David Cantrell <dcantrell@redhat.com>

Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)

iEYEARECAAYFAktGKsgACgkQ5hsjjIy1VklDlACfTzCeza9qlu PwAkXqoCvuiOwM
gxEAn1UyP+QohexgDEbOm5E8Y1DpbBPZ
=X6af
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-08-2010, 01:36 PM
Ales Kozumplik
 
Default Fixes problems in the manual network configuration screen in loader with IPv6.

This one is good to go now. I didn't catch you before you left for the day,
so I did a git am on this email so it's in master now.



Great!

BTW I still think that we should at some point remove the #ifdefs on
master to keep the code clean. NM might not be there yet, but IPv6 as
such is going to stay I think:-)


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-08-2010, 07:56 PM
David Cantrell
 
Default Fixes problems in the manual network configuration screen in loader with IPv6.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 8 Jan 2010, Ales Kozumplik wrote:




This one is good to go now. I didn't catch you before you left for the day,
so I did a git am on this email so it's in master now.



Great!

BTW I still think that we should at some point remove the #ifdefs on master
to keep the code clean. NM might not be there yet, but IPv6 as such is going
to stay I think:-)




Given the fact that it's taken NM this long to get partial IPv6 support, I'm
not holding my breath on it fully working right away. So having a way to
easily disable this code for future builds for now is safer for us. I'm ok
with the ifdefs going away in the future, I just don't think we're there yet.
I don't trust NM enough yet to remove the ifdefs.

- --
David Cantrell <dcantrell@redhat.com>

Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)

iEYEARECAAYFAktHnBgACgkQ5hsjjIy1VknWHQCaAhuFcRKH/BNCMO9VAUTNs09n
6XoAoNFvdp4bKF5xUXOD7u5EJZuJVsqB
=qy1N
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 04:43 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org