Code reviews for packaging changes
 

Hey everyone out there in server land.

A few of us have decided to do start doing code reviews for the bulk of
packaging changes in Ubuntu Server, given the high bar for quality and
precision in.. well.. precise. :)

Whether or not you are able to actually upload to the Ubuntu archive,
you can help out with these code reviews.

You can look for active code reviews here:

https://code.launchpad.net/~ubuntu-server/+activereviews

Note that you will probably want to join the 'ubuntu-server' launchpad
team.

If you want to propose a change to ubuntu-server, push the change to
an appropriate branch, and then propose for merging, and change the
requested reviewer to 'ubuntu-server'.

An appropriate branch means something like

bzr push lp:~your-username/ubuntu/precise/packagename/what-the-branch-does

1 review should be sufficient for most changes, though even if something
already has an "Approved" from somebody else, feel free to suggest
changes, the idea here is just to get more eyeballs on changes before
they land in Ubuntu Server.

Also please note that some packaging branches are out of sync. Recent
versions of bzr will actually tell you if the branch is CURRENT or not.
If it is out of date, you can send a debdiff to this list for review.

--
ubuntu-server mailing list
ubuntu-server@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server
More info: https://wiki.ubuntu.com/ServerTeam

Code reviews for packaging changes
 

+ Clint Byrum <clint@ubuntu.com>:

> You can look for active code reviews here:
>
> https://code.launchpad.net/~ubuntu-server/+activereviews

Already did and successfully reviewed one pending change,
but i'd like to know whether there's some kind of notification
available (mail or rss) that i coudn't find or we're supposed
to take a look at that page periodically.

Happy to be helpful :)

--
Alex Muntada <alexm@alexm.org>
http://alexm.org/

--
ubuntu-server mailing list
ubuntu-server@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server
More info: https://wiki.ubuntu.com/ServerTeam

Code reviews for packaging changes
 

Excerpts from Alex Muntada's message of Fri Dec 16 12:59:11 -0800 2011:
> + Clint Byrum <clint@ubuntu.com>:
>
> > You can look for active code reviews here:
> >
> > https://code.launchpad.net/~ubuntu-server/+activereviews
>
> Already did and successfully reviewed one pending change,
> but i'd like to know whether there's some kind of notification
> available (mail or rss) that i coudn't find or we're supposed
> to take a look at that page periodically.
>
> Happy to be helpful :)
>

Alex, thanks for the review of my change!

There's no emails, but I think thats just the default setting of the
ubuntu-server team to not receive these emails. I do not know if launchpad
will allow you to say "please send me merge proposals for this team.".

Best thing to do is to just hit it periodically. I find that having a
set time to do code reviews for the projects I'm working on helps me to
focus on them, as they're not nearly as fun as doing actual coding. :)

--
ubuntu-server mailing list
ubuntu-server@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server
More info: https://wiki.ubuntu.com/ServerTeam

Code reviews for packaging changes
 

On 12/14/2011 03:04 PM, Clint Byrum wrote:

Hey everyone out there in server land.

A few of us have decided to do start doing code reviews for the bulk of
packaging changes in Ubuntu Server, given the high bar for quality and
precision in.. well.. precise. :)

Whether or not you are able to actually upload to the Ubuntu archive,
you can help out with these code reviews.

You can look for active code reviews here:

https://code.launchpad.net/~ubuntu-server/+activereviews

Note that you will probably want to join the 'ubuntu-server' launchpad
team.

If you want to propose a change to ubuntu-server, push the change to
an appropriate branch, and then propose for merging, and change the
requested reviewer to 'ubuntu-server'.



Hi Clint-

Awesome stuff.

As someone who currently seeks sponsorship for uploads I've got one
question. Several times in the last few months, I've proposed a merge
containing packaging changes to a package in the server set with hopes
of getting some peer review from fellow teammates. Before anyone on the
team had a chance to review, the patch pilot on duty reviewed, merged
and uploaded. Given this new workflow, are there any extra steps
needed to prevent that from happening so we can ensure a good peer
review/+1 before upload? Or is specifying 'ubuntu-server' as the
reviewer enough?


Cheers,
Adam

--
ubuntu-server mailing list
ubuntu-server@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server
More info: https://wiki.ubuntu.com/ServerTeam

Code reviews for packaging changes
 

+ Clint Byrum <clint@ubuntu.com>:

> Best thing to do is to just hit it periodically. I find that having a
> set time to do code reviews for the projects I'm working on helps
> me to focus on them, as they're not nearly as fun as doing actual
> coding. :)

Fair enough, but i'll try launchpadlib to see if i can run a cronjob ;)

--
Alex Muntada <alexm@alexm.org>
http://alexm.org/

--
ubuntu-server mailing list
ubuntu-server@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server
More info: https://wiki.ubuntu.com/ServerTeam

Code reviews for packaging changes
 

+ Alex Muntada <alexm@alexm.org>:

> i'll try launchpadlib to see if i can run a cronjob

Launchpad API is amazing:

#!/usr/bin/python
#
# https://api.launchpad.net/1.0/~ubuntu-server?ws.op=getMergeProposals&status=Needs+review
#
from launchpadlib.launchpad import Launchpad

lp = Launchpad.login_anonymously('ubuntu-server code reviews', 'production')
team = lp.people['ubuntu-server']
needs_review = team.getMergeProposals(status='Needs review')
print needs_review.total_size

--
Alex Muntada <alexm@alexm.org>
http://alexm.org/

--
ubuntu-server mailing list
ubuntu-server@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server
More info: https://wiki.ubuntu.com/ServerTeam