FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 05-11-2008, 12:20 AM
Tim Gardner
 
Default UBUNTU: ssb: Fix all-ones boardflags OriginalAuthor: Larry Finger OriginalLocation: http://launchpadlibrarian.net/14435353/0007-ssb_boardflags_fix Bug: #197959

In the SSB SPROM a field set to all ones means the value
is not defined in the SPROM.

In case of the boardflags, we need to set them to zero
to avoid confusing drivers. For certain cards, leaving
the flags all set to 1 will prevent the card from transmitting,
as has been seen for the PCI version of a BCM4301.

This patch was included in mainline kernels with commit
4503183aa32e6886400d82282292934fa64a81b0.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/ssb/pci.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 0ab095c..23bcc95 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -426,6 +426,7 @@ static int sprom_extract(struct ssb_bus *bus,
SPEX(crc, SSB_SPROM_REVISION, SSB_SPROM_REVISION_CRC,
SSB_SPROM_REVISION_CRC_SHIFT);

+
if ((bus->chip_id & 0xFF00) == 0x4400) {
/* Workaround: The BCM44XX chip has a stupid revision
* number stored in the SPROM.
@@ -443,6 +444,10 @@ static int sprom_extract(struct ssb_bus *bus,
if (out->revision >= 4)
goto unsupported;
}
+ if (out->r1.boardflags_lo == 0xFFFF)
+ out->r1.boardflags_lo = 0; /* per specs */
+ if (out->r2.boardflags_hi == 0xFFFF)
+ out->r2.boardflags_hi = 0; /* per specs */

return 0;
unsupported:
--
1.5.4.3



--------------040705030006050706090801
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

--------------040705030006050706090801--
 

Thread Tools




All times are GMT. The time now is 02:47 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org