On Thu, Oct 11, 2012 at 05:56:32PM +0100, Luis Henriques wrote:
[...]

Ack on the patch, just noted some minor things that doesn't affect
correctness anyway...

> + if (allow_unsupported_sfp)
> + hw->allow_unsupported_sfp = allow_unsupported_sfp;

This could be assigned directly, without the if (harmless).

> - hw_dbg(hw, "SFP+ module not supported
");
> - hw->phy.type = ixgbe_phy_sfp_unsupported;
> - status = IXGBE_ERR_SFP_NOT_SUPPORTED;
> + if (hw->allow_unsupported_sfp) {
> + e_warn(drv, "WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics. Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter. Intel Corporation is not responsible for any harm caused by using untested modules.");

String could have been broken down in more than one line...

--
[]'s
Herton

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team