FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 10-11-2012, 05:26 PM
Herton Ronaldo Krzesinski
 
Default Ack: ixgbe: Add module parameter to allow untested and unsafe SFP+ modules

On Thu, Oct 11, 2012 at 05:56:32PM +0100, Luis Henriques wrote:
[...]

Ack on the patch, just noted some minor things that doesn't affect
correctness anyway...

> + if (allow_unsupported_sfp)
> + hw->allow_unsupported_sfp = allow_unsupported_sfp;

This could be assigned directly, without the if (harmless).

> - hw_dbg(hw, "SFP+ module not supported
");
> - hw->phy.type = ixgbe_phy_sfp_unsupported;
> - status = IXGBE_ERR_SFP_NOT_SUPPORTED;
> + if (hw->allow_unsupported_sfp) {
> + e_warn(drv, "WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics. Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter. Intel Corporation is not responsible for any harm caused by using untested modules.");

String could have been broken down in more than one line...

--
[]'s
Herton

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 12:04 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org