UBUNTU: SAUCE: input: fix weird issue of synaptics psmouse sync lost after resume
From: Eric Miao <email@example.com>
This patch has already been sent upstream by Eric. Unfortunately,
after a little back and forth between Eric and Dmitry Torokhov, the
patch did get included, and there is still an open question to Dmitry.
However, this is a known issue on at least 4 systems, and it causes
them to lose their mouse device on suspend. So I was hoping we could
get it in to quantal. Original email follows:
So in summary, the symptom is intermittent key events lost after resume
on some machines with synaptics touchpad (seems this is synaptics _only_),
and key events loss is due to serio port reconnect after psmouse sync lost.
Removing psmouse and inserting it back during the suspend/resume process
is able to work around the issue, so the difference between psmouse_connect()
and psmouse_reconnect() is the key to the root cause of this problem.
After comparing the two different paths, synaptics driver has its own
implementation of synaptics_reconnect(), and the missing psmouse_probe()
seems significant, the patch below added psmouse_probe() to the reconnect
process, and has been verified many times that the issue could not be reliably
There are two PS/2 commands in psmouse_probe():
The weird thing is, the PSMOUSE_CMD_GETID seems to be significant, and the
PSMOUSE_CMD_RESET_DIS is irrelevant to this issue after trying several times.
Now it's rather difficult to form a sane theory. So this patch is
really for RFC.
Note it does fix a real problem though.
Signed-off-by: James M Leddy <firstname.lastname@example.org>
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)