FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 09-27-2012, 08:19 PM
Leann Ogasawara
 
Default ALSA: hda - Add PCI and Codec IDs for Haswell HDMI Audio

On 09/27/2012 12:49 PM, Leann Ogasawara wrote:
> On 09/27/2012 06:13 AM, Tim Gardner wrote:
>> On 09/27/2012 06:49 AM, David Henningsson wrote:
>>> From: Wang Xingchao <xingchao.wang@intel.com>
>>>
>>> This is a backport of several upstream commits:
>>> e926f2c850c472f813f9bab486c68a3fe0b03ae4
>>> 1c76684d2752b3a24bb7da183cc18e5d126dbcc9
>>> bdbe34dece4942f4d8df9865dba7785bb813366a
>>> d279fae8a41690ec1b20c07be8c6f42f8af27a17
>>>
>>> ...which all are trivial and just add PCI and Codec IDs
>>> to the relevant tables.
>>>
>> Don't combine the patches. d279fae8a41690ec1b20c07be8c6f42f8af27a17 is
>> not a valid object from Linus' repo. All of these patches need a bug number.
> Hi David,
>
> Indeed it is better for us maintenance wise to be able to have a 1-1
> mapping of upstream commits when we apply them to our tree. As such, I
> took the liberty to go ahead and individually cherry-pick these into our
> Quantal repo. That last commit, d279fae8, I found in takashi's tree so
> I picked it up from there. I also took the liberty to open a tracking
> bug for this:
>
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1057698
>
> Please review the quantal repo and make sure what I've done looks
> correct as e926f2c8 wasn't a clean cherry-pick.

I also decided to cherry-pick 144dad99 from upstream while I was at it.

Thanks,
Leann

commit 144dad99ef6ad10c8c8ebe787d08157c4a94201f
Author: James Ralston <james.d.ralston@intel.com>
Date: Thu Aug 9 09:38:59 2012 -0700

ALSA: hda_intel: Add Device IDs for Intel Lynx Point-LP PCH



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 09-28-2012, 06:55 AM
David Henningsson
 
Default ALSA: hda - Add PCI and Codec IDs for Haswell HDMI Audio

On 09/27/2012 09:49 PM, Leann Ogasawara wrote:

On 09/27/2012 06:13 AM, Tim Gardner wrote:

On 09/27/2012 06:49 AM, David Henningsson wrote:

From: Wang Xingchao <xingchao.wang@intel.com>

This is a backport of several upstream commits:
e926f2c850c472f813f9bab486c68a3fe0b03ae4
1c76684d2752b3a24bb7da183cc18e5d126dbcc9
bdbe34dece4942f4d8df9865dba7785bb813366a
d279fae8a41690ec1b20c07be8c6f42f8af27a17

...which all are trivial and just add PCI and Codec IDs
to the relevant tables.


Don't combine the patches. d279fae8a41690ec1b20c07be8c6f42f8af27a17 is
not a valid object from Linus' repo. All of these patches need a bug number.


Hi David,


Hi Leann, and first of all, thanks a lot for walking the extra mile for
me :-)



Indeed it is better for us maintenance wise to be able to have a 1-1
mapping of upstream commits when we apply them to our tree. As such, I
took the liberty to go ahead and individually cherry-pick these into our
Quantal repo. That last commit, d279fae8, I found in takashi's tree so


Yeah, I thought I checked that they were all in Linus' tree, but git can
be bewildering sometimes, especially when you start adding remotes (to
be able to to cherrypicking), and then it suddenly finds things from
those other remotes which you didn't consider...or something.



I picked it up from there. I also took the liberty to open a tracking
bug for this:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1057698

Please review the quantal repo and make sure what I've done looks
correct as e926f2c8 wasn't a clean cherry-pick.


I did have a look at the current master-next branch. The haswell ones
looked correct to me - you had correctly replaced posfix_combo with
posfix_lpib.


I'm a little more hesitant to whether we should have LPIB on the lynx
point-LP patch: the combo mode uses posbuf for recording and lpib for
playback. This is why it works for haswell, which is HDMI and playback
only - but for this one, we could just pick either one and see if we get
in trouble (in this case, that would typically be non-functional or
strange noises in recordings), we might have to switch, i e, remove the
POSFIX_LPIB for Lynx Point LP, just as done for the already present Lynx
Point.



--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 06:54 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org