This patch to the new Cypress PS/2 Trackpad driver fixes trackpad
misbehavior when the user opts to disable tap-to-click.
To test (requires a Cypress PS/2 Trackpad):
1. Disable tap-to-click in Mouse and Touchpad settings.
2. Tap the touchpad (do not click the physical button) in various
places. Notice that when touching the zones above the physical
buttons, tap-to-click single clicks are still generated (but
not when touching higher up on the pad).
3. Test same with patch applied: observe no extraneous tap-to-click
events when that feature has been disabled; tap-to-click works
as usual when left enabled.
None known. This patch affects only the Cypress PS/2 Trackpad driver.
The following changes since commit 96081f77301b66a75da842e1a26eda6cb57e90e5:
+ /* This is only true if one of the mouse buttons were tapped.
+ * Make sure it doesn't turn into a click. The regular tap-to-
+ * click functionality will handle that on its own. If we don't
+ * do this, disabling tap-to-click won't affect the mouse button
+ * zones. */
+ if (report_data->tap)
+ report_data->left = 0;
if (report_data->contact_cnt <= 0)
kernel-team mailing list