FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 09-16-2012, 06:08 AM
Brad Figg
 
Default Ack: eCryptfs: Call lower ->flush() from ecryptfs_flush()

On 09/15/2012 12:09 PM, Colin King wrote:
> From: Tyler Hicks <tyhicks@canonical.com>
>
> Since eCryptfs only calls fput() on the lower file in
> ecryptfs_release(), eCryptfs should call the lower filesystem's
> ->flush() from ecryptfs_flush().
>
> If the lower filesystem implements ->flush(), then eCryptfs should try
> to flush out any dirty pages prior to calling the lower ->flush(). If
> the lower filesystem does not implement ->flush(), then eCryptfs has no
> need to do anything in ecryptfs_flush() since dirty pages are now
> written out to the lower filesystem in ecryptfs_release().
>
> BugLink: https://launchpad.net/bugs/1047261
>
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> (upstream cherry pick 64e6651dcc10e9d2cc6230208a8e6c2cfd19ae18)
> Colin Ian King <colin.king@canonical.com>
> ---
> fs/ecryptfs/file.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c
> index 44ce5c6..d45ba45 100644
> --- a/fs/ecryptfs/file.c
> +++ b/fs/ecryptfs/file.c
> @@ -275,8 +275,14 @@ out:
>
> static int ecryptfs_flush(struct file *file, fl_owner_t td)
> {
> - return file->f_mode & FMODE_WRITE
> - ? filemap_write_and_wait(file->f_mapping) : 0;
> + struct file *lower_file = ecryptfs_file_to_lower(file);
> +
> + if (lower_file->f_op && lower_file->f_op->flush) {
> + filemap_write_and_wait(file->f_mapping);
> + return lower_file->f_op->flush(lower_file, td);
> + }
> +
> + return 0;
> }
>
> static int ecryptfs_release(struct inode *inode, struct file *file)
>


--
Brad Figg brad.figg@canonical.com http://www.canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 10:09 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org