Ubuntu 7.10 PowerNow! issue with future AMD processors
 

Langsdorf, Mark wrote:
> The PowerNow! driver included in Ubuntu 7.10
> has a flaw that prevents it from loading on
> AMD family 0x11 processors (which have not
> been released). AMD considers Ubuntu 7.10 an
> important software platform for family 0x11
> processors. We would like to get a patch
> added so that the driver can work.
>
> What would be the best way to go about
> getting such a patch added?
>
> -Mark Langsdorf
> Operating System Research Center
> AMD
>
>
>

Mark - this is pretty much the right way. Send a patch to this list.

--
Tim Gardner tim.gardner@ubuntu.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Ubuntu 7.10 PowerNow! issue with future AMD processors
 

Tim Gardner wrote:
>
> Mark - this is pretty much the right way. Send a patch to this list.
>

As a follow-up, I forgot to mention that you should try to get it
upstream as well (maybe that is obvious to you). If the patch makes it
into 2.6.24, then Hardy ought to get it for free. We are depending on
2.6.24 closing before we lock down kernel development for the Hardy cycle.

rtg
--
Tim Gardner tim.gardner@ubuntu.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Ubuntu 7.10 PowerNow! issue with future AMD processors
 

> > Mark - this is pretty much the right way. Send a patch to this list.
>
> As a follow-up, I forgot to mention that you should try to get it
> upstream as well (maybe that is obvious to you). If the patch makes it
> into 2.6.24, then Hardy ought to get it for free. We are depending on
> 2.6.24 closing before we lock down kernel development for the
> Hardy cycle.

Thanks for the prompt response. AMD is familiar with the
need to code upstream as early as possible, no worry there.

An updated version of the patch is included in the
2.6.23-rc3 kernel and should support all future AMD
processors, but it's a fairly large patch. The
patch I intend to to submit is much smaller (~10 lines)
but only supports family 0x11 and earlier processors.

I'll submit the small patch for inclusion in 7.10,
and let Hardy take the larger patch for free.

-Mark Langsdorf
Operating System Research Center
AMD



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Ubuntu 7.10 PowerNow! issue with future AMD processors
 

On Tuesday 27 November 2007, Tim Gardner wrote:
> Langsdorf, Mark wrote:
> > The PowerNow! driver included in Ubuntu 7.10
> > has a flaw that prevents it from loading on
> > AMD family 0x11 processors (which have not
> > been released). AMD considers Ubuntu 7.10 an
> > important software platform for family 0x11
> > processors. We would like to get a patch
> > added so that the driver can work.


The equation to find the frequency given the fid and did is family dependant.

Acked-by: Mark Langsdorf <mark.langsdorf at amd.com>
Signed-off-by: Joachim Deguara <joachim.deguara at amd.com>

--
Index: 2.6-git/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
================================================== =================
--- 2.6-git.orig/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
+++ 2.6-git/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
@@ -76,7 +76,10 @@ static u32 find_khz_freq_from_fid(u32 fi
/* Return a frequency in MHz, given an input fid and did */
static u32 find_freq_from_fiddid(u32 fid, u32 did)
{
- return 100 * (fid + 0x10) >> did;
+ if (current_cpu_data.x86 == 0x10)
+ return 100 * (fid + 0x10) >> did;
+ else
+ return 100 * (fid + 0x8) >> did;
}

static u32 find_khz_freq_from_fiddid(u32 fid, u32 did)



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Ubuntu 7.10 PowerNow! issue with future AMD processors
 

Langsdorf, Mark wrote:

> An updated version of the patch is included in the
> 2.6.23-rc3 kernel and should support all future AMD
> processors, but it's a fairly large patch. The
> patch I intend to to submit is much smaller (~10 lines)
> but only supports family 0x11 and earlier processors.
>
> I'll submit the small patch for inclusion in 7.10,
> and let Hardy take the larger patch for free.
>

Ubuntu intends to support 7.10 until 2009. Will the small patch be
adequate for this timeframe? It would be preferable to do all the
necessary patching now rather than needing a second patch later.

Thanks

Phillip Lougher


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Ubuntu 7.10 PowerNow! issue with future AMD processors
 

> > An updated version of the patch is included in the
> > 2.6.23-rc3 kernel and should support all future AMD
> > processors, but it's a fairly large patch. The
> > patch I intend to to submit is much smaller (~10 lines)
> > but only supports family 0x11 and earlier processors.
> >
> > I'll submit the small patch for inclusion in 7.10,
> > and let Hardy take the larger patch for free.
> >
>
> Ubuntu intends to support 7.10 until 2009. Will the small patch be
> adequate for this timeframe? It would be preferable to do all the
> necessary patching now rather than needing a second patch later.

It's possible that parts released in 2009 may
not be family 0x11 and would fail with the small
patch. The larger patch would work with them.
It's a question of how thorough you want to be.

The larger patch is essentially the 2.6.24 driver.
Should I just diff it against the 7.10 kernel and
submit that?

-Mark Langsdorf
Operating System Research Center
AMD



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Ubuntu 7.10 PowerNow! issue with future AMD processors
 

On Wed, 2007-11-28 at 14:40 -0600, Langsdorf, Mark wrote:
> > > An updated version of the patch is included in the
> > > 2.6.23-rc3 kernel and should support all future AMD
> > > processors, but it's a fairly large patch. The
> > > patch I intend to to submit is much smaller (~10 lines)
> > > but only supports family 0x11 and earlier processors.
> > >
> > > I'll submit the small patch for inclusion in 7.10,
> > > and let Hardy take the larger patch for free.
> > >
> >
> > Ubuntu intends to support 7.10 until 2009. Will the small patch be
> > adequate for this timeframe? It would be preferable to do all the
> > necessary patching now rather than needing a second patch later.
>
> It's possible that parts released in 2009 may
> not be family 0x11 and would fail with the small
> patch. The larger patch would work with them.
> It's a question of how thorough you want to be.
>
> The larger patch is essentially the 2.6.24 driver.
> Should I just diff it against the 7.10 kernel and
> submit that?

Yes, please. We can check both patches and weigh our options on how we
would like to fix this in 7.10.

Thanks

--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/
SwissDisk: http://www.swissdisk.com/


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team