Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Ubuntu Kernel Team (http://www.linux-archive.org/ubuntu-kernel-team/)
-   -   APPLIED: APPLIED: ASUS ET2012 series machines (http://www.linux-archive.org/ubuntu-kernel-team/651710-applied-applied-asus-et2012-series-machines.html)

Tim Gardner 04-02-2012 01:03 PM

APPLIED: APPLIED: ASUS ET2012 series machines
 
--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Tim Gardner 04-02-2012 01:06 PM

APPLIED: APPLIED: ASUS ET2012 series machines
 
The commit log for c55d995dd3cebffdeb2b7eff8acc813c56d62c97 is
non-existent, so its hard to tell from the patch just _how_ it avoids a
potential NULL memory access.

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

AceLan Kao 04-03-2012 01:39 AM

APPLIED: APPLIED: ASUS ET2012 series machines
 
Dear Tim,

In this function
static void eeepc_wmi_quirks(struct asus_wmi_driver *driver)
{
- driver->panel_power = FB_BLANK_UNBLANK;
- driver->quirks = &quirk_asus_unknown;
- driver->quirks->hotplug_wireless = hotplug_wireless;
- driver->quirks->wapf = -1;
+ quirks = &quirk_asus_unknown;
+ quirks->hotplug_wireless = hotplug_wireless;
+
dmi_check_system(asus_quirks);
+
driver->quirks = quirks;
+ driver->quirks->wapf = -1;
+ driver->panel_power = FB_BLANK_UNBLANK;
}

"driver->quirks" will become NULL if dmi_check_system() doesn't match any quirk.

This line actually prevents the NULL pointer be assigned to
"driver->quirks" after dmi_check_system()
+ quirks = &quirk_asus_unknown;

I think it's fixed accidentally, since the driver maintainer's machine
and mine all match the quirk.

Best regards,
AceLan Kao.

2012/4/2 Tim Gardner <tim.gardner@canonical.com>:
> The commit log for c55d995dd3cebffdeb2b7eff8acc813c56d62c97 is
> non-existent, so its hard to tell from the patch just _how_ it avoids a
> potential NULL memory access.
>
> --
> Tim Gardner tim.gardner@canonical.com



--
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team


All times are GMT. The time now is 02:46 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.