FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 03-26-2012, 02:53 PM
Tim Gardner
 
Default Backport killable request_module()

The following changes since commit 773c2e5b6fba66cb775b20593c1862d7a226985f:

KVM: x86: fix missing checks in syscall emulation (2012-03-16 10:08:10 -0300)

are available in the git repository at:

git://kernel.ubuntu.com/rtg/ubuntu-natty.git lp963685-usermode-helper

for you to fetch changes up to d26407be000cb0e30e0aeff5288d15cda0adf4da:

UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently (2012-03-26 08:48:04 -0600)

----------------------------------------------------------------
Oleg Nesterov (7):
usermodehelper: use UMH_WAIT_PROC consistently
usermodehelper: introduce umh_complete(sub_info)
usermodehelper: implement UMH_KILLABLE
usermodehelper: kill umh_wait, renumber UMH_* constants
usermodehelper: ____call_usermodehelper() doesn't need do_exit()
kmod: introduce call_modprobe() helper
kmod: make __request_module() killable

Tim Gardner (1):
UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently

drivers/block/drbd/drbd_nl.c | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 2 +-
drivers/staging/rtl8192e/r8192E_dm.c | 2 +-
drivers/video/uvesafb.c | 2 +-
include/linux/kmod.h | 17 +++---
kernel/kmod.c | 84 ++++++++++++++++++++++++++------
security/keys/request_key.c | 2 +-
security/tomoyo/load_policy.c | 2 +-
ubuntu/fsam7400/fsam7400.c | 4 +-
ubuntu/ndiswrapper/loader.c | 6 +-
ubuntu/rtl8192se/rtl_dm.c | 6 +-
11 files changed, 91 insertions(+), 38 deletions(-)

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-26-2012, 06:01 PM
Tim Gardner
 
Default Backport killable request_module()

The following changes since commit a21c77713c589069b93a82f44c29e282f36aea05:

UBUNTU: Bump ABI (2012-03-26 11:55:19 -0600)

are available in the git repository at:

git://kernel.ubuntu.com/rtg/ubuntu-lucid.git lp963685-usermode-helper

for you to fetch changes up to c610bda0b22a8774f22d8cc0d0575d3783d3306f:

UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently (2012-03-26 11:55:38 -0600)

----------------------------------------------------------------
Masami Hiramatsu (1):
kmod: fix resource leak in call_usermodehelper_pipe()

Neil Horman (1):
kmod: add init function to usermodehelper

Oleg Nesterov (7):
usermodehelper: use UMH_WAIT_PROC consistently
usermodehelper: introduce umh_complete(sub_info)
usermodehelper: implement UMH_KILLABLE
usermodehelper: kill umh_wait, renumber UMH_* constants
usermodehelper: ____call_usermodehelper() doesn't need do_exit()
kmod: introduce call_modprobe() helper
kmod: make __request_module() killable

Tim Gardner (1):
UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently

drivers/staging/rtl8187se/r8180_core.c | 2 +-
drivers/video/uvesafb.c | 2 +-
include/linux/kmod.h | 54 ++++++++++---
kernel/kmod.c | 141 +++++++++++++++++++++++---------
kernel/sys.c | 6 +-
net/bridge/br_stp_if.c | 2 +-
security/tomoyo/common.c | 2 +-
ubuntu/fsam7400/fsam7400.c | 4 +-
ubuntu/ndiswrapper/loader.c | 6 +-
ubuntu/rtl8192se/rtl_dm.c | 6 +-
10 files changed, 159 insertions(+), 66 deletions(-)

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-27-2012, 01:01 PM
Andy Whitcroft
 
Default Backport killable request_module()

This is a heafty pile of patches, but many are pretty small overall.
The upstream references look ok. It should be easy to test, systems
should stop booting right if this is wrong. As this is a user
triggerable DOS and assuming some testing:

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-27-2012, 01:02 PM
Andy Whitcroft
 
Default Backport killable request_module()

This is a heafty pile of patches, but many are pretty small overall.
The upstream references look ok. It should be easy to test, systems
should stop booting right if this is wrong. As this is a user
triggerable DOS and assuming some testing:

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-28-2012, 06:31 AM
Tetsuo Handa
 
Default Backport killable request_module()

Andy Whitcroft wrote:
> It should be easy to test, systems should stop booting right if this is wrong.

Since we can force recompilation of kernel modules upon ABI bump, we could
apply a validator patch (like below untested one) upon next ABI bump (in order
to catch forgotten users) and revert it upon some-time-later ABI rebump.

diff --git a/include/linux/kmod.h b/include/linux/kmod.h
index 9efeae6..1350670 100644
--- a/include/linux/kmod.h
+++ b/include/linux/kmod.h
@@ -48,10 +48,10 @@ static inline int request_module_nowait(const char *name, ...) { return -ENOSYS;
struct cred;
struct file;

-#define UMH_NO_WAIT 0 /* don't wait at all */
-#define UMH_WAIT_EXEC 1 /* wait for the exec, but not the process */
-#define UMH_WAIT_PROC 2 /* wait for the process to complete */
-#define UMH_KILLABLE 4 /* wait for EXEC/PROC killable */
+#define UMH_NO_WAIT 0x10 /* don't wait at all */
+#define UMH_WAIT_EXEC 0x11 /* wait for the exec, but not the process */
+#define UMH_WAIT_PROC 0x12 /* wait for the process to complete */
+#define UMH_KILLABLE 0x04 /* wait for EXEC/PROC killable */

struct subprocess_info {
struct work_struct work;
diff --git a/kernel/kmod.c b/kernel/kmod.c
index 957a7aa..ecfd3d5 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -483,6 +483,18 @@ int call_usermodehelper_exec(struct subprocess_info *sub_info, int wait)
DECLARE_COMPLETION_ONSTACK(done);
int retval = 0;

+ if (unlikely(wait == -1 || wait == 0 || wait == 1)) {
+ WARN(1, "Requesting for usermode helper with hardcoded wait "
+ "flag. Change to use UMH_* symbols and recompile, or "
+ "this request will fail on Linux 3.4.
");
+ if (wait == -1)
+ wait = UMH_NO_WAIT;
+ else if (wait == 0)
+ wait = UMH_WAIT_EXEC;
+ else
+ wait = UMH_WAIT_PROC;
+ }
+
helper_lock();
if (sub_info->path[0] == '')
goto out;

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 06:42 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org