FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 03-20-2012, 06:27 AM
Jeremy Kerr
 
Default powerpc/pmac: Fix SMP kernels on pre-core99 UP machines

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

BugLink: https://bugs.launchpad.net/bugs/959959

The code for "powersurge" SMP would kick in and cause a crash
at boot due to the lack of a NULL test.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
Reported-By: Adam Conrad <adconrad@ubuntu.com>
Tested-By: Adam Conrad <adconrad@ubuntu.com>

Cherry-picked from upstream commit
78c5c68a4cf4329d17abfa469345ddf323d4fd62

---
arch/powerpc/platforms/powermac/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
index 9b6a820..3394254 100644
--- a/arch/powerpc/platforms/powermac/smp.c
+++ b/arch/powerpc/platforms/powermac/smp.c
@@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {

static void __init smp_psurge_setup_cpu(int cpu_nr)
{
- if (cpu_nr != 0)
+ if (cpu_nr != 0 || !psurge_start)
return;

/* reset the entry point so if we get another intr we won't

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-20-2012, 07:37 AM
Anca Emanuel
 
Default powerpc/pmac: Fix SMP kernels on pre-core99 UP machines

On Tue, Mar 20, 2012 at 9:27 AM, Jeremy Kerr <jeremy.kerr@canonical.com> wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> BugLink: https://bugs.launchpad.net/bugs/959959
>
> The code for "powersurge" SMP would kick in and cause a crash
> at boot due to the lack of a NULL test.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
> Reported-By: Adam Conrad <adconrad@ubuntu.com>
> Tested-By: Adam Conrad <adconrad@ubuntu.com>
>
> Cherry-picked from upstream commit
> 78c5c68a4cf4329d17abfa469345ddf323d4fd62
>
> ---
> *arch/powerpc/platforms/powermac/smp.c | * *2 +-
> *1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
> index 9b6a820..3394254 100644
> --- a/arch/powerpc/platforms/powermac/smp.c
> +++ b/arch/powerpc/platforms/powermac/smp.c
> @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {
>
> *static void __init smp_psurge_setup_cpu(int cpu_nr)
> *{
> - * * * if (cpu_nr != 0)
> + * * * if (cpu_nr != 0 || !psurge_start)
> * * * * * * * *return;
>
> * * * */* reset the entry point so if we get another intr we won't
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Why not CC: lkml ?

It is on the stable channel ? Upstream link please ?
Now you understand Greg's concerns about maintaining a stable kernel ?

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-20-2012, 07:38 AM
Jeremy Kerr
 
Default powerpc/pmac: Fix SMP kernels on pre-core99 UP machines

Hi Anca,


Why not CC: lkml ?



Because it's already in mainline. Refer:

> Cherry-picked from upstream commit
> 78c5c68a4cf4329d17abfa469345ddf323d4fd62




Cheers,


Jeremy

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 01:45 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org