FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 03-12-2012, 08:14 PM
Herton Ronaldo Krzesinski
 
Default Ack: eCryptfs: Copy up lower inode attrs after setting lower xattr

On Mon, Mar 12, 2012 at 09:00:28PM +0000, Colin King wrote:
> From: Tyler Hicks <tyhicks@canonical.com>
>
> After passing through a ->setxattr() call, eCryptfs needs to copy the
> inode attributes from the lower inode to the eCryptfs inode, as they
> may have changed in the lower filesystem's ->setxattr() path.
>
> One example is if an extended attribute containing a POSIX Access
> Control List is being set. The new ACL may cause the lower filesystem to
> modify the mode of the lower inode and the eCryptfs inode would need to
> be updated to reflect the new mode.
>
> https://launchpad.net/bugs/926292
>
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Reported-by: Sebastien Bacher <seb128@ubuntu.com>
> Cc: John Johansen <john.johansen@canonical.com>
> Cc: <stable@vger.kernel.org>
> (cherry picked from commit 545d680938be1e86a6c5250701ce9abaf360c495)
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ecryptfs/inode.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index 19892d7..ab35b11 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -1085,6 +1085,8 @@ ecryptfs_setxattr(struct dentry *dentry, const char *name, const void *value,
> }
>
> rc = vfs_setxattr(lower_dentry, name, value, size, flags);
> + if (!rc)
> + fsstack_copy_attr_all(dentry->d_inode, lower_dentry->d_inode);
> out:
> return rc;
> }
> --
> 1.7.9.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
[]'s
Herton

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 03-12-2012, 08:14 PM
Herton Ronaldo Krzesinski
 
Default Ack: eCryptfs: Copy up lower inode attrs after setting lower xattr

On Mon, Mar 12, 2012 at 09:01:37PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> After passing through a ->setxattr() call, eCryptfs needs to copy the
> inode attributes from the lower inode to the eCryptfs inode, as they
> may have changed in the lower filesystem's ->setxattr() path.
>
> One example is if an extended attribute containing a POSIX Access
> Control List is being set. The new ACL may cause the lower filesystem to
> modify the mode of the lower inode and the eCryptfs inode would need to
> be updated to reflect the new mode.
>
> https://launchpad.net/bugs/926292
>
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Reported-by: Sebastien Bacher <seb128@ubuntu.com>
> Cc: John Johansen <john.johansen@canonical.com>
> Cc: <stable@vger.kernel.org>
> (backport of upstream commit 5d58bd2bb0e9b3576a5ae26879a73e6c30cd3914)
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ecryptfs/inode.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index 90a6087..645da17 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -1035,6 +1035,8 @@ ecryptfs_setxattr(struct dentry *dentry, const char *name, const void *value,
> rc = lower_dentry->d_inode->i_op->setxattr(lower_dentry, name, value,
> size, flags);
> mutex_unlock(&lower_dentry->d_inode->i_mutex);
> + if (!rc)
> + fsstack_copy_attr_all(dentry->d_inode, lower_dentry->d_inode, NULL);
> out:
> return rc;
> }
> --
> 1.7.0.4
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
[]'s
Herton

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 11:12 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org