FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 02-27-2012, 03:53 PM
Tim Gardner
 
Default ACK: Ack: eCryptfs: Clear i_nlink in rmdir

On 02/27/2012 09:49 AM, Herton Ronaldo Krzesinski wrote:

On Mon, Feb 27, 2012 at 03:56:16PM +0000, Colin King wrote:

From: Colin Ian King<colin.king@canonical.com>

SRU Justification:

The IN_DELETE_SELF mask for inotify_add_watch indicates that an event
should be emitted when the watched path is deleted, however, this does
not happen on an eCryptfs mount.

To reproduce:

mkdir upper lower
sudo mount -t ecryptfs lower upper

and compile and run the following test program in the upper directory:

https://launchpadlibrarian.net/64953109/inotify.c

This test program hangs waiting for the IN_DELETE_SELF event that never
occurs.

Fix: the following two patches address the bug. The first patch removes
and an unnecessary d_delete from ecryptfs_rmdir. The second patch clears
the inode's i_nlink after a successful vfs_rmdir() on the lower directory.
Without the second patch inode evict and destroy paths are missed and
hence IN_DELETE_SELF inotify events do not occur.

With the fix, the test inotify program receives the IN_DELETE_SELF event
and completes.

https://bugs.launchpad.net/bugs/723518

These patches are clean cherry picks of upstream commits
35ffa948b2f7bdf79e488cd496232935d095087a and
07850552b92b3637fa56767b5e460b4238014447


Ack, these shas should go to the patch changelog (cherry-picked from...)



Tyler Hicks (2):
eCryptfs: Remove extra d_delete in ecryptfs_rmdir
eCryptfs: Clear i_nlink in rmdir

fs/ecryptfs/inode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team





I'm cleaning the patches and will also submit to stable as soon as I've
verified the testing.


rtg
--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 07:51 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org