FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 02-16-2012, 04:51 PM
Herton Ronaldo Krzesinski
 
Default Ack: ecryptfs: read on a directory should return EISDIR if not supported

On Thu, Feb 16, 2012 at 05:11:06PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> SRU Justification:
>
> Impact: Read on an ecryptfs directory should return EISDIR if not
> supported however currently EINVAL is being returned rather than
> EISDIR.
>
> Fix: With this patch a .read operation for ecryptfs directories is
> connected up to generic_read_dir() which then performs the correct
> behavior.
>
> Testcase:
>
> $ mkdir foo
> $ grep blah foo
> grep: foo: Invalid argument
> $ strace -fe open,read grep blah foo
> [snip]
> open("foo", O_RDONLY) = 3
> read(3, 0x19a1000, 32768) = -1 EINVAL (Invalid argument)
> [snip]
>
> whereas with the fix, read returns:
>
> read(3, 0x120d000, 32768) = -1 EISDIR (Is a directory)
>
> This is a clean cherry pick of commit 323ef68faf1bbd9b1e66aea268fd09d358d7e8ab
>
> Andy Whitcroft (1):
> ecryptfs: read on a directory should return EISDIR if not supported
>
> fs/ecryptfs/file.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
[]'s
Herton

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 10:07 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org