-/* I think this is a fiction */
+ * The units on the numbers in the next two are... bizarre. Examples will
+ * make it clearer; this one parallels an example in the eDP spec.
+ * intel_dp_max_data_rate for one lane of 2.7GHz evaluates as:
+ * 270000 * 1 * 8 / 10 == 216000
+ * The actual data capacity of that configuration is 2.16Gbit/s, so the
+ * units are decakilobits. ->clock in a drm_display_mode is in kilohertz -
+ * or equivalently, kilopixels per second - so for 1680x1050R it'd be
+ * 119000. At 18bpp that's 2142000 kilobits per second.
+ * Thus the strange-looking division by 10 in intel_dp_link_required, to
+ * get the result in decakilobits instead of kilobits.
intel_dp_link_required(struct drm_device *dev, struct intel_dp *intel_dp, int pixel_clock)
struct drm_i915_private *dev_priv = dev->dev_private;
+ int bpp = 24;