FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 12-06-2011, 04:15 PM
Seth Forshee
 
Default Ack: KEYS: Fix a NULL pointer deref in the user-defined key type

On Tue, Dec 06, 2011 at 04:32:05PM +0000, Andy Whitcroft wrote:
> From: David Howells <dhowells@redhat.com>
>
> Fix a NULL pointer deref in the user-defined key type whereby updating a
> negative key into a fully instantiated key will cause an oops to occur
> when the code attempts to free the non-existent old payload.
>
> This results in an oops that looks something like the following:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
> IP: [<ffffffff81085fa1>] __call_rcu+0x11/0x13e
> PGD 3391d067 PUD 3894a067 PMD 0
> Oops: 0002 [#1] SMP
> CPU 1
> Pid: 4354, comm: keyctl Not tainted 3.1.0-fsdevel+ #1140 /DG965RY
> RIP: 0010:[<ffffffff81085fa1>] [<ffffffff81085fa1>] __call_rcu+0x11/0x13e
> RSP: 0018:ffff88003d591df8 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 000000000000006e
> RDX: ffffffff8161d0c0 RSI: 0000000000000000 RDI: 0000000000000000
> RBP: ffff88003d591e18 R08: 0000000000000000 R09: ffffffff8152fa6c
> R10: 0000000000000000 R11: 0000000000000300 R12: ffff88003b8f9538
> R13: ffffffff8161d0c0 R14: ffff88003b8f9d50 R15: ffff88003c69f908
> FS: 00007f97eb18c720(0000) GS:ffff88003bd00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000008 CR3: 000000003d47a000 CR4: 00000000000006e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> Process keyctl (pid: 4354, threadinfo ffff88003d590000, task ffff88003c78a040)
> Stack:
> ffff88003e0ffde0 ffff88003b8f9538 0000000000000001 ffff88003b8f9d50
> ffff88003d591e28 ffffffff810860f0 ffff88003d591e68 ffffffff8117bfea
> ffff88003d591e68 ffffffff00000000 ffff88003e0ffde1 ffff88003e0ffde0
> Call Trace:
> [<ffffffff810860f0>] call_rcu_sched+0x10/0x12
> [<ffffffff8117bfea>] user_update+0x8d/0xa2
> [<ffffffff8117723a>] key_create_or_update+0x236/0x270
> [<ffffffff811789b1>] sys_add_key+0x123/0x17e
> [<ffffffff813b84bb>] system_call_fastpath+0x16/0x1b
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Acked-by: Jeff Layton <jlayton@redhat.com>
> Acked-by: Neil Horman <nhorman@redhat.com>
> Acked-by: Steve Dickson <steved@redhat.com>
> Acked-by: James Morris <jmorris@namei.org>
> Cc: stable@kernel.org
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> (backported from commit 9f35a33b8d06263a165efe3541d9aa0cdbd70b3b)
> CVE-2011-4110
> BugLink: http://bugs.launchpad.net/bugs/894369
> Signed-off-by: Andy Whitcroft <apw@canonical.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>

> ---
> security/keys/user_defined.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/security/keys/user_defined.c b/security/keys/user_defined.c
> index 7c687d5..97edf29 100644
> --- a/security/keys/user_defined.c
> +++ b/security/keys/user_defined.c
> @@ -119,7 +119,8 @@ int user_update(struct key *key, const void *data, size_t datalen)
> key->expiry = 0;
> }
>
> - call_rcu(&zap->rcu, user_update_rcu_disposal);
> + if (zap)
> + call_rcu(&zap->rcu, user_update_rcu_disposal);
>
> error:
> return ret;
> --
> 1.7.5.4
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Tue Dec 6 19:30:01 2011
Return-path: <ubuntu-users-bounces@lists.ubuntu.com>
Envelope-to: tom@linux-archive.org
Delivery-date: Tue, 06 Dec 2011 19:16:19 +0200
Received: from chlorine.canonical.com ([91.189.94.204]:56659)
by s2.java-tips.org with esmtp (Exim 4.69)
(envelope-from <ubuntu-users-bounces@lists.ubuntu.com>)
id 1RXycs-00059L-SA
for tom@linux-archive.org; Tue, 06 Dec 2011 19:16:19 +0200
Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com)
by chlorine.canonical.com with esmtp (Exim 4.71)
(envelope-from <ubuntu-users-bounces@lists.ubuntu.com>)
id 1RXycC-0007nm-7e; Tue, 06 Dec 2011 17:15:36 +0000
Received: from mail-gx0-f177.google.com ([209.85.161.177])
by chlorine.canonical.com with esmtp (Exim 4.71)
(envelope-from <toshazed@gmail.com>) id 1RXycA-0007kI-5K
for ubuntu-users@lists.ubuntu.com; Tue, 06 Dec 2011 17:15:34 +0000
Received: by ggnp4 with SMTP id p4so1012192ggn.8
for <ubuntu-users@lists.ubuntu.com>;
Tue, 06 Dec 2011 09:15:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:content-type; bh=Ac47o0XVr0ntGxpqC5DJlnYxhySOAn77nWZfwYGjUDI=;
b=Hbb1s/onO8YOLl+FqwDqsAJ7hQOMsSdRf7c1EDn1WoreIic4NFCWdBVC gXRoq0Zb/A
7yIQ1eVdsIX9z6J87uEsYCLuzheG5I0S74/XtajZ8J3uxyjeYr7TuztrvI2vXpRITo+u
yYqQGTX8qQQxo0pMjO49O2ep4L9Arm1Da+25Y=
MIME-Version: 1.0
Received: by 10.101.201.1 with SMTP id d1mr3370119anq.44.1323191733443; Tue,
06 Dec 2011 09:15:33 -0800 (PST)
Received: by 10.150.226.21 with HTTP; Tue, 6 Dec 2011 09:15:33 -0800 (PST)
In-Reply-To: <CAOMhDU7UFW-aLgHbP6Bjuio3Mh+sYF0j=LkH5_Q6x3pWGfhykg@mail.gmail .com>
References: <CAOMhDU7UFW-aLgHbP6Bjuio3Mh+sYF0j=LkH5_Q6x3pWGfhykg@mail.gmail .com>
Date: Tue, 6 Dec 2011 23:15:33 +0600
Message-ID: <CAK6e52okNey6_XWWswrgdDgMTzsYxUDJEHZtPBfSV_0Q2kDG cQ@mail.gmail.com>
Subject: Re: 10.10 freeze-up
From: =?UTF-8?B?4Ka44Ka+4Kac4KeH4Kam4KeB4KawIOCmsOCmueCmv+Cmri Dgppzgp4vgp5/gpr7gprDgpqY=?=
=?UTF-8?B?4Ka+4Kaw?= <toshazed@gmail.com>
To: "Ubuntu user technical support,
not for general discussions" <ubuntu-users@lists.ubuntu.com>
X-BeenThere: ubuntu-users@lists.ubuntu.com
X-Mailman-Version: 2.1.13
Precedence: list
Reply-To: "Ubuntu user technical support,
not for general discussions" <ubuntu-users@lists.ubuntu.com>
List-Id: "Ubuntu user technical support,
not for general discussions" <ubuntu-users.lists.ubuntu.com>
List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/ubuntu-users>,
<mailto:ubuntu-users-request@lists.ubuntu.com?subject=unsubscribe>
List-Archive: <https://lists.ubuntu.com/archives/ubuntu-users>
List-Post: <mailto:ubuntu-users@lists.ubuntu.com>
List-Help: <mailto:ubuntu-users-request@lists.ubuntu.com?subject=help>
List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/ubuntu-users>,
<mailto:ubuntu-users-request@lists.ubuntu.com?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============6623488536001632200=="
Sender: ubuntu-users-bounces@lists.ubuntu.com
Errors-To: ubuntu-users-bounces@lists.ubuntu.com

--===============6623488536001632200==
Content-Type: multipart/alternative; boundary=0016e68ef3c93dde2904b36f9519

--0016e68ef3c93dde2904b36f9519
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: base64

RGVhciBCb2IKCldoYXQgaXMgdGhlIGNvbmZpZ3VyYXRpb24gb2 YgeW91ciBkZWZlY3RpdmUgUEM/
CgpXaXRoIFJlZ2FyZHMKLS0gCuCmsOCmv+Cmgi9yaW5nCis4OD AxNjcxNDExNDM3Cgrgpq7gprng
pr7gprjgpprgpr/gpqwvR2VuZXJhbCBTZWNyZXRhcnkK4Kar4Ka+4KaJ4Kao4KeN4 Kah4KeH4Ka2
4KaoIOCmq+CmsCDgppPgpqrgp4fgpqgg4Ka44KeL4Kaw4KeN4K a4IOCmuOCmsuCmv+CmieCmtuCm
qOCmuCDgpqzgpr7gpoLgprLgpr7gpqbgp4fgprYvRm91bmRhdG lvbiBmb3IgT3BlbiBTb3VyY2UK
U29sdXRpb25zIEJhbmdsYWRlc2gKCuCmquCnjeCmsOCmp+Cmvu CmqCDgprjgpq7gpqjgp43gpqzg
pq/gprzgppUsICLgpqrgp4fgppngp43gppfgp4Hgpofgpqgg4Kau4 KeH4Kay4Ka+IC0K4Keo4Kem
4Ken4KenPGh0dHA6Ly93d3cuZm9zc2JkLm9yZy9pbmRleC5waH AvMTktc2FtcGxlLWRhdGEtYXJ0
aWNsZXMvam9vbWxhLzM1LXByb2Zlc3Npb25hbHM+IgrgpaTgpa Qg4Kas4KeN4Kav4KaV4KeN4Kak
4Ka/4KaX4KakIOCmrOCnjeCmsuCml+CmgyDgprDgpr/gpoIt4Kam4KeN4KavIOCmoeCmqCAn4Kaw
IOCmrOCnjeCmsuCmlyA8aHR0cDovL3Rvc2hhemVkLndvcmRwcm Vzcy5jb20vPiDgpaTgpaQK4Ka4
4Kam4Ka44KeN4KavLCDgprLgpr/gpqjgpr7gppXgp43gprgg4Kau4Ka/4Kao4KeN4KafIOCmrOCm
vuCmguCmsuCmvuCmpuCnh+CmtiA8aHR0cDovL2xpbnV4bWludC 1iZC5vcmcvYWJvdXRfdXM+IOCl
pOClpArgprjgpqbgprjgp43gpq8sIOCmieCmrOCngeCmqOCnje Cmn+CngQrgpqzgpr7gpoLgprLg
pr7gpqbgp4fgprYgPGh0dHBzOi8vbGF1bmNocGFkLm5ldC8lN0 V0b3NoYXplZD4K
--0016e68ef3c93dde2904b36f9519
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: base64

RGVhciBCb2I8YnI+PGJyIGNsZWFyPSJhbGwiPldoYXQgaXMgdG hlIGNvbmZpZ3VyYXRpb24gb2Yg
eW91ciBkZWZlY3RpdmUgUEM/PGJyPjxicj5XaXRoIFJlZ2FyZHM8YnI+LS0gPGJyPuCmsOCmv+ Cm
gi9yaW5nPGJyPis4ODAxNjcxNDExNDM3PGJyPjxmb250Pjxmb2 50IHN0eWxlPSJjb2xvcjpyZ2Io
MCwgMCwgMCkiIGNvbG9yPSIjODg4ODg4Ij48YnI+4Kau4Ka54K a+4Ka44Kaa4Ka/4KasL0dlbmVy
YWwgU2VjcmV0YXJ5PGJyPgoKPC9mb250PjwvZm9udD7gpqvgpr 7gpongpqjgp43gpqHgp4fgprbg
pqgg4Kar4KawIOCmk+CmquCnh+CmqCDgprjgp4vgprDgp43gpr gg4Ka44Kay4Ka/4KaJ4Ka24Kao
4Ka4IOCmrOCmvuCmguCmsuCmvuCmpuCnh+Cmti9Gb3VuZGF0aW 9uIGZvciBPcGVuIFNvdXJjZSBT
b2x1dGlvbnMgQmFuZ2xhZGVzaDxicj48YnI+PGZvbnQ+PGZvbn Qgc3R5bGU9ImNvbG9yOnJnYigw
LCAwLCAwKSIgY29sb3I9IiM4ODg4ODgiPuCmquCnjeCmsOCmp+ CmvuCmqCDgprjgpq7gpqjgp43g
pqzgpq/gprzgppU8L2ZvbnQ+PC9mb250PiwgJnF1b3Q7PGEgaHJlZj0ia HR0cDovL3d3dy5mb3Nz
YmQub3JnL2luZGV4LnBocC8xOS1zYW1wbGUtZGF0YS1hcnRpY2 xlcy9qb29tbGEvMzUtcHJvZmVz
c2lvbmFscyIgdGFyZ2V0PSJfYmxhbmsiPuCmquCnh+CmmeCnje Cml+CngeCmh+CmqCDgpq7gp4fg
prLgpr4gLSDgp6jgp6bgp6fgp6c8L2E+JnF1b3Q7IOClpOClpC Dgpqzgp43gpq/gppXgp43gpqTg
pr/gppfgpqQg4Kas4KeN4Kay4KaX4KaDIDxhIGhyZWY9Imh0dHA6L y90b3NoYXplZC53b3JkcHJl
c3MuY29tLyIgdGFyZ2V0PSJfYmxhbmsiPuCmsOCmv+Cmgi3gpq bgp43gpq8g4Kah4KaoICYjMzk7
4KawIOCmrOCnjeCmsuCmlzwvYT4g4KWk4KWkIOCmuOCmpuCmuO CnjeCmrywgPGEgaHJlZj0iaHR0
cDovL2xpbnV4bWludC1iZC5vcmcvYWJvdXRfdXMiIHRhcmdldD 0iX2JsYW5rIj7gprLgpr/gpqjg
pr7gppXgp43gprgg4Kau4Ka/4Kao4KeN4KafIOCmrOCmvuCmguCmsuCmvuCmpuCnh+CmtjwvYT 4g
4KWk4KWkIOCmuOCmpuCmuOCnjeCmrywgPGEgaHJlZj0iaHR0cH M6Ly9sYXVuY2hwYWQubmV0LyU3
RXRvc2hhemVkIiB0YXJnZXQ9Il9ibGFuayI+4KaJ4Kas4KeB4K ao4KeN4Kaf4KeBIOCmrOCmvuCm
guCmsuCmvuCmpuCnh+CmtjwvYT48YnI+Cgo=
--0016e68ef3c93dde2904b36f9519--


--===============6623488536001632200==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
ubuntu-users mailing list
ubuntu-users@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-users

--===============6623488536001632200==--
 

Thread Tools




All times are GMT. The time now is 09:49 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org