FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 07-25-2011, 04:38 PM
Manoj Iyer
 
Default mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

Please consider the following SRU for Natty, it fixes Ricoh SD/MMC card
reader which fails to read certain types of MMC/SD Cards. Please note that
this patch should be applied on top of the patch to Ricoh mmc already SRUed
for natty and maverick. http://patchwork.ozlabs.org/patch/98056/

SRU JUSTIFICATION
================

EFFECT
======
Ricoh 1180:e823 does not recognize certain types of SD/MMC cards.
- Buffalo SD 512MB
dmesg: I/O error, dev mmcblk0, sector xxx
- Kingston SD 2GB
dmesg: I/O error, dev mmcblk0, sector xxx
- Patriot Micro SDHC
dmesg: I/O error, dev mmcblk0, sector xxx.

FIX
===
Lowering the SD base clock frequency from 200Mhz to 50Mhz fixes
this issue. This solution was suggest by Koji Matsumuro, Ricoh Company, Ltd.

TEST
====
Performance test results with various MMC and SD cards were posted
to https://lkml.org/lkml/2011/7/11/381 and also part of the results
attached to this bug.


The following changes since commit 84aa86ba6a3f2331f1cfbab9b6def072ac1dee37:

mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency (2011-07-25 11:19:53 -0500)

are available in the git repository at:
git://kernel.ubuntu.com/manjo/ubuntu-natty.git lp773524




--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 07-25-2011, 04:45 PM
Leann Ogasawara
 
Default mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

On Mon, 2011-07-25 at 11:38 -0500, Manoj Iyer wrote:
> Ricoh 1180:e823 does not recognize certain types of SD/MMC cards,
> as reported at http://launchpad.net/bugs/773524. Lowering the SD
> base clock frequency from 200Mhz to 50Mhz fixes this issue. This
> solution was suggest by Koji Matsumuro, Ricoh Company, Ltd.
>
> This change has no negative performance effect on standard SD
> cards, though it's quite possible that there will be one on
> UHS-1 cards.
>
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> Tested-by: Daniel Manrique <daniel.manrique@canonical.com>
> Cc: Koji Matsumuro <matsumur@nts.ricoh.co.jp>
> Cc: <stable@kernel.org>
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Chris Ball <cjb@laptop.org>
> (cherry picked from commit 15bed0f2fa8e1d7db201692532c210a7823d2d21)
>
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>

Whomever commits this to Natty should add the BugLink. Otherwise, this
is a low risk of regression and has positive test results.

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

> ---
> drivers/pci/quirks.c | 23 +++++++++++++++++++++++
> 1 files changed, 23 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index a1e4f61..b1c312e 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2755,6 +2755,29 @@ static void ricoh_mmc_fixup_r5c832(struct pci_dev *dev)
>
> dev_notice(&dev->dev, "proprietary Ricoh MMC controller disabled (via firewire function)
");
> dev_notice(&dev->dev, "MMC cards are now supported by standard SDHCI controller
");
> +
> + /*
> + * RICOH 0xe823 SD/MMC card reader fails to recognize
> + * certain types of SD/MMC cards. Lowering the SD base
> + * clock frequency from 200Mhz to 50Mhz fixes this issue.
> + *
> + * 0x150 - SD2.0 mode enable for changing base clock
> + * frequency to 50Mhz
> + * 0xe1 - Base clock frequency
> + * 0x32 - 50Mhz new clock frequency
> + * 0xf9 - Key register for 0x150
> + * 0xfc - key register for 0xe1
> + */
> + if (dev->device == PCI_DEVICE_ID_RICOH_R5CE823) {
> + pci_write_config_byte(dev, 0xf9, 0xfc);
> + pci_write_config_byte(dev, 0x150, 0x10);
> + pci_write_config_byte(dev, 0xf9, 0x00);
> + pci_write_config_byte(dev, 0xfc, 0x01);
> + pci_write_config_byte(dev, 0xe1, 0x32);
> + pci_write_config_byte(dev, 0xfc, 0x00);
> +
> + dev_notice(&dev->dev, "MMC controller base frequency changed to 50Mhz.
");
> + }
> }
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C832, ricoh_mmc_fixup_r5c832);
> DECLARE_PCI_FIXUP_RESUME_EARLY(PCI_VENDOR_ID_RICOH , PCI_DEVICE_ID_RICOH_R5C832, ricoh_mmc_fixup_r5c832);
> --
> 1.7.4.1
>
>



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 12:56 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org