Linux Archive

Linux Archive (
-   Ubuntu Kernel Team (
-   -   dccp: handle invalid feature options length (

Andy Whitcroft 07-07-2011 10:12 PM

dccp: handle invalid feature options length
Integer underflow in the dccp_parse_options function
(net/dccp/options.c) in the Linux kernel before allows
remote attackers to cause a denial of service via a Datagram
Congestion Control Protocol (DCCP) packet with an invalid feature
options length, which triggers a buffer over-read.

This problem was introduced in v2.6.29-rc1 and therefore does not affect
hardy. The fix for this has already hit lucid, natty, and oneiric via
mainline and stable. Following this email is a patch for: lucid/fsl-imx51,
maverick, maverick/ti-omap4, and natty/ti-omap4; this is a clean
cherry-pick from the upstream commit.

Proposing for lucid/fsl-imx51, maverick, maverick/ti-omap4, and natty/ti-omap4.


kernel-team mailing list

Andy Whitcroft 07-07-2011 10:12 PM

dccp: handle invalid feature options length
From: Dan Rosenberg <>

A length of zero (after subtracting two for the type and len fields) for
the DCCPO_{CHANGE,CONFIRM}_{L,R} options will cause an underflow due to
the subtraction. The subsequent code may read past the end of the
options value buffer when parsing. I'm unsure of what the consequences
of this might be, but it's probably not good.

Signed-off-by: Dan Rosenberg <>
Acked-by: Gerrit Renker <>
Signed-off-by: David S. Miller <>

(cherry picked from commit a294865978b701e4d0d90135672749531b9a900d)
Signed-off-by: Andy Whitcroft <>
net/dccp/options.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/dccp/options.c b/net/dccp/options.c
index 1b08cae..b4a853e 100644
--- a/net/dccp/options.c
+++ b/net/dccp/options.c
@@ -131,6 +131,8 @@ int dccp_parse_options(struct sock *sk, struct dccp_request_sock *dreq,
if (pkt_type == DCCP_PKT_DATA) /* RFC 4340, 6 */
+ if (len == 0)
+ goto out_invalid_option;
rc = dccp_feat_parse_options(sk, dreq, mandatory, opt,
*value, value + 1, len - 1);
if (rc)

kernel-team mailing list

All times are GMT. The time now is 05:47 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.