FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 07-04-2011, 09:53 AM
 
Default netfilter: arp_tables: fix infoleak to userspace CVE-2011-1170

From: Vasiliy Kulikov <segoon@openwall.com>

BugLink: http://bugs.launchpad.net/bugs/801480

Structures ipt_replace, compat_ipt_replace, and xt_get_revision are
copied from userspace. Fields of these structs that are
zero-terminated strings are not checked. When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.

The first bug was introduced before the git epoch; the second is
introduced by 6b7d31fc (v2.6.15-rc1); the third is introduced by
6b7d31fc (v2.6.15-rc1). To trigger the bug one should have
CAP_NET_ADMIN.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
net/ipv4/netfilter/arp_tables.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 2909c92..da85e92 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -816,6 +816,7 @@ static int do_replace(void __user *user, unsigned int len)
return -ENOMEM;
if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;

newinfo = xt_alloc_table_info(tmp.size);
if (!newinfo)
@@ -930,6 +931,7 @@ static int do_add_counters(void __user *user, unsigned int len)
paddc = vmalloc(len);
if (!paddc)
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;

if (copy_from_user(paddc, user, len) != 0) {
ret = -EFAULT;
@@ -1070,6 +1072,7 @@ static int do_arpt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len
ret = -EFAULT;
break;
}
+ rev.name[sizeof(rev.name)-1] = 0;

try_then_request_module(xt_find_revision(NF_ARP, rev.name,
rev.revision, 1, &ret),
--
1.7.4.1


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 07-04-2011, 02:08 PM
 
Default netfilter: arp_tables: fix infoleak to userspace CVE-2011-1170

From: Vasiliy Kulikov <segoon@openwall.com>

BugLink: http://bugs.launchpad.net/bugs/801480

commit upstream 42eab94fff18cb1091d3501cd284d6bd6cc9c143

Structures ipt_replace, compat_ipt_replace, and xt_get_revision are
copied from userspace. Fields of these structs that are
zero-terminated strings are not checked. When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.

The first bug was introduced before the git epoch; the second is
introduced by 6b7d31fc (v2.6.15-rc1); the third is introduced by
6b7d31fc (v2.6.15-rc1). To trigger the bug one should have
CAP_NET_ADMIN.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
net/ipv4/netfilter/arp_tables.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 2909c92..da85e92 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -816,6 +816,7 @@ static int do_replace(void __user *user, unsigned int len)
return -ENOMEM;
if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;

newinfo = xt_alloc_table_info(tmp.size);
if (!newinfo)
@@ -930,6 +931,7 @@ static int do_add_counters(void __user *user, unsigned int len)
paddc = vmalloc(len);
if (!paddc)
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;

if (copy_from_user(paddc, user, len) != 0) {
ret = -EFAULT;
@@ -1070,6 +1072,7 @@ static int do_arpt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len
ret = -EFAULT;
break;
}
+ rev.name[sizeof(rev.name)-1] = 0;

try_then_request_module(xt_find_revision(NF_ARP, rev.name,
rev.revision, 1, &ret),
--
1.7.4.1


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 07-04-2011, 02:47 PM
Stefan Bader
 
Default netfilter: arp_tables: fix infoleak to userspace CVE-2011-1170

On 04.07.2011 16:08, paolo.pisati@canonical.com wrote:
> From: Vasiliy Kulikov <segoon@openwall.com>
>
> BugLink: http://bugs.launchpad.net/bugs/801480
>
> commit upstream 42eab94fff18cb1091d3501cd284d6bd6cc9c143
>
> Structures ipt_replace, compat_ipt_replace, and xt_get_revision are
> copied from userspace. Fields of these structs that are
> zero-terminated strings are not checked. When they are used as argument
> to a format string containing "%s" in request_module(), some sensitive
> information is leaked to userspace via argument of spawned modprobe
> process.
>
> The first bug was introduced before the git epoch; the second is
> introduced by 6b7d31fc (v2.6.15-rc1); the third is introduced by
> 6b7d31fc (v2.6.15-rc1). To trigger the bug one should have
> CAP_NET_ADMIN.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
> net/ipv4/netfilter/arp_tables.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
> index 2909c92..da85e92 100644
> --- a/net/ipv4/netfilter/arp_tables.c
> +++ b/net/ipv4/netfilter/arp_tables.c
> @@ -816,6 +816,7 @@ static int do_replace(void __user *user, unsigned int len)
> return -ENOMEM;
> if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
> return -ENOMEM;
> + tmp.name[sizeof(tmp.name)-1] = 0;
>
> newinfo = xt_alloc_table_info(tmp.size);
> if (!newinfo)

Comparing the second hunk against upstream there may be a misplacement. In
upstream code the change was in compat_do_replace().

> @@ -930,6 +931,7 @@ static int do_add_counters(void __user *user, unsigned int len)
> paddc = vmalloc(len);
> if (!paddc)
> return -ENOMEM;
> + tmp.name[sizeof(tmp.name)-1] = 0;
>
> if (copy_from_user(paddc, user, len) != 0) {
> ret = -EFAULT;

> @@ -1070,6 +1072,7 @@ static int do_arpt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len
> ret = -EFAULT;
> break;
> }
> + rev.name[sizeof(rev.name)-1] = 0;
>
> try_then_request_module(xt_find_revision(NF_ARP, rev.name,
> rev.revision, 1, &ret),


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 10:01 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org