Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Ubuntu Kernel Team (http://www.linux-archive.org/ubuntu-kernel-team/)
-   -   UBUNTU: custom binaries need VERSION_SIGNATURE updated during prepare (http://www.linux-archive.org/ubuntu-kernel-team/537028-ubuntu-custom-binaries-need-version_signature-updated-during-prepare.html)

Andy Whitcroft 06-08-2011 06:43 PM

UBUNTU: custom binaries need VERSION_SIGNATURE updated during prepare
 
BugLink: http://bugs.launchpad.net/bugs/794698

When preparing the custom binary trees we build a configuration. Part
of this should involve setting VERSION_SIGNATURE for that build. This
is missed for custom binaries which leads to the confusing situation
that a -xen flavour will report as below:

$ uname -a && cat /proc/version_signature
Linux ip-10-36-7-174 2.6.24-29-xen #1 SMP
Thu Apr 21 20:44:30 UTC 2011 i686 GNU/Linux
Ubuntu 2.6.24-4.6-generic

This renders /proc/version_signature worthless. Ensure we fill this
in when we build the config.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
debian/rules.d/6-binary-custom.mk | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/debian/rules.d/6-binary-custom.mk b/debian/rules.d/6-binary-custom.mk
index ec34480..908d162 100644
--- a/debian/rules.d/6-binary-custom.mk
+++ b/debian/rules.d/6-binary-custom.mk
@@ -23,7 +23,8 @@ $(stampdir)/stamp-custom-prepare-%: debian/binary-custom.d/%/config.$(arch)
echo $$patch;
patch -p1 -d $(origsrc) < $$patch ;
done
- cat $< > $(srcdir)/.config
+ cat $< | sed -e 's/.*CONFIG_VERSION_SIGNATURE.*/CONFIG_VERSION_SIGNATURE="Ubuntu $(release)-$(revision)-$*"/' > $(srcdir)/.config
+
$(kmake) -C $(origsrc) O=$(srcdir) silentoldconfig prepare scripts
touch $@

--
1.7.4.1


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Stefan Bader 06-08-2011 06:50 PM

UBUNTU: custom binaries need VERSION_SIGNATURE updated during prepare
 
On 08.06.2011 20:43, Andy Whitcroft wrote:
> BugLink: http://bugs.launchpad.net/bugs/794698
>
> When preparing the custom binary trees we build a configuration. Part
> of this should involve setting VERSION_SIGNATURE for that build. This
> is missed for custom binaries which leads to the confusing situation
> that a -xen flavour will report as below:
>
> $ uname -a && cat /proc/version_signature
> Linux ip-10-36-7-174 2.6.24-29-xen #1 SMP
> Thu Apr 21 20:44:30 UTC 2011 i686 GNU/Linux
> Ubuntu 2.6.24-4.6-generic
>
> This renders /proc/version_signature worthless. Ensure we fill this
> in when we build the config.
>
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
> ---
> debian/rules.d/6-binary-custom.mk | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/debian/rules.d/6-binary-custom.mk b/debian/rules.d/6-binary-custom.mk
> index ec34480..908d162 100644
> --- a/debian/rules.d/6-binary-custom.mk
> +++ b/debian/rules.d/6-binary-custom.mk
> @@ -23,7 +23,8 @@ $(stampdir)/stamp-custom-prepare-%: debian/binary-custom.d/%/config.$(arch)
> echo $$patch;
> patch -p1 -d $(origsrc) < $$patch ;
> done
> - cat $< > $(srcdir)/.config
> + cat $< | sed -e 's/.*CONFIG_VERSION_SIGNATURE.*/CONFIG_VERSION_SIGNATURE="Ubuntu $(release)-$(revision)-$*"/' > $(srcdir)/.config
> +
> $(kmake) -C $(origsrc) O=$(srcdir) silentoldconfig prepare scripts
> touch $@
>

Looks good to me

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Tim Gardner 06-08-2011 06:51 PM

UBUNTU: custom binaries need VERSION_SIGNATURE updated during prepare
 
On 06/08/2011 12:43 PM, Andy Whitcroft wrote:

BugLink: http://bugs.launchpad.net/bugs/794698

When preparing the custom binary trees we build a configuration. Part
of this should involve setting VERSION_SIGNATURE for that build. This
is missed for custom binaries which leads to the confusing situation
that a -xen flavour will report as below:

$ uname -a&& cat /proc/version_signature
Linux ip-10-36-7-174 2.6.24-29-xen #1 SMP
Thu Apr 21 20:44:30 UTC 2011 i686 GNU/Linux
Ubuntu 2.6.24-4.6-generic

This renders /proc/version_signature worthless. Ensure we fill this
in when we build the config.

Signed-off-by: Andy Whitcroft<apw@canonical.com>
---
debian/rules.d/6-binary-custom.mk | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/debian/rules.d/6-binary-custom.mk b/debian/rules.d/6-binary-custom.mk
index ec34480..908d162 100644
--- a/debian/rules.d/6-binary-custom.mk
+++ b/debian/rules.d/6-binary-custom.mk
@@ -23,7 +23,8 @@ $(stampdir)/stamp-custom-prepare-%: debian/binary-custom.d/%/config.$(arch)
echo $$patch;
patch -p1 -d $(origsrc)< $$patch ;
done
- cat $< > $(srcdir)/.config
+ cat $< | sed -e 's/.*CONFIG_VERSION_SIGNATURE.*/CONFIG_VERSION_SIGNATURE="Ubuntu $(release)-$(revision)-$*"/'> $(srcdir)/.config
+
$(kmake) -C $(origsrc) O=$(srcdir) silentoldconfig prepare scripts
touch $@



Acked-by: Tim Gardner <tim.gardner@canonical.com>

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team


All times are GMT. The time now is 07:07 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.