FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 05-19-2011, 02:20 PM
Brad Figg
 
Default UBUNTU: SAUCE: vesafb: mtrr module parameter is uint, not bool

On 05/19/2011 06:54 AM, Andy Whitcroft wrote:

From: Thomas Schlichter<thomas.schlichter@web.de>

BugLink: http://bugs.launchpad.net/bugs/778043

As noted by the reporter the mtrr kernel command line option is actually a
positive numeric not a boolean, move the module parameter we add to match.

Signed-off-by: Andy Whitcroft<apw@canonical.com>
---
drivers/video/vesafb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c
index 2a60213..d0db4bb 100644
--- a/drivers/video/vesafb.c
+++ b/drivers/video/vesafb.c
@@ -74,7 +74,7 @@ module_param_named(vgapal, pmi_setpal, invbool, 0);
MODULE_PARM_DESC(vgapal, "Use VGA for setting palette (default)");
module_param_named(pmipal, pmi_setpal, bool, 0);
MODULE_PARM_DESC(pmipal, "Use PMI for setting palette");
-module_param(mtrr, bool, 0);
+module_param(mtrr, uint, 0);
MODULE_PARM_DESC(mtrr, "Enable MTRR support (default)");
module_param_named(nomtrr, mtrr, invbool, 0);
MODULE_PARM_DESC(nomtrr, "Disable MTRR support");


Acked-by: Brad Figg <brad.figg@canonical.com>

Andy,

Don't forget to add the SRU justification text.

Brad
--
Brad Figg brad.figg@canonical.com http://www.canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 05-19-2011, 02:20 PM
Brad Figg
 
Default UBUNTU: SAUCE: vesafb: mtrr module parameter is uint, not bool

On 05/19/2011 06:54 AM, Andy Whitcroft wrote:

From: Thomas Schlichter<thomas.schlichter@web.de>

BugLink: http://bugs.launchpad.net/bugs/778043

As noted by the reporter the mtrr kernel command line option is actually a
positive numeric not a boolean, move the module parameter we add to match.

Signed-off-by: Andy Whitcroft<apw@canonical.com>
---
drivers/video/vesafb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c
index 2a60213..d0db4bb 100644
--- a/drivers/video/vesafb.c
+++ b/drivers/video/vesafb.c
@@ -74,7 +74,7 @@ module_param_named(vgapal, pmi_setpal, invbool, 0);
MODULE_PARM_DESC(vgapal, "Use VGA for setting palette (default)");
module_param_named(pmipal, pmi_setpal, bool, 0);
MODULE_PARM_DESC(pmipal, "Use PMI for setting palette");
-module_param(mtrr, bool, 0);
+module_param(mtrr, uint, 0);
MODULE_PARM_DESC(mtrr, "Enable MTRR support (default)");
module_param_named(nomtrr, mtrr, invbool, 0);
MODULE_PARM_DESC(nomtrr, "Disable MTRR support");


Acked-by: Brad Figg <brad.figg@canonical.com>

Andy,

Don't forget to add the SRU justification text.

Brad
--
Brad Figg brad.figg@canonical.com http://www.canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 09:48 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org