Yama: fix default relationship to check thread group
On 03/18/2011 05:51 PM, Kees Cook wrote:
> Yet another case of a thread needing to match against the group leader. > > Signed-off-by: Kees Cook <kees.cook@canonical.com> > --- > security/yama/yama_lsm.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c > index b05f1dd..c8f3020 100644 > --- a/security/yama/yama_lsm.c > +++ b/security/yama/yama_lsm.c > @@ -173,6 +173,8 @@ static int task_is_descendant(struct task_struct *parent, > > rcu_read_lock(); > read_lock(&tasklist_lock); > + if (!thread_group_leader(parent)) > + parent = parent->group_leader; > while (walker->pid > 0) { > if (!thread_group_leader(walker)) > walker = walker->group_leader; Acked-by: Stefan Bader <stefan.bader@canonical.com> -- kernel-team mailing list kernel-team@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kernel-team |
Yama: fix default relationship to check thread group
On 03/21/2011 02:51 AM, Stefan Bader wrote:
On 03/18/2011 05:51 PM, Kees Cook wrote: Yet another case of a thread needing to match against the group leader. Signed-off-by: Kees Cook<kees.cook@canonical.com> --- security/yama/yama_lsm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index b05f1dd..c8f3020 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -173,6 +173,8 @@ static int task_is_descendant(struct task_struct *parent, rcu_read_lock(); read_lock(&tasklist_lock); + if (!thread_group_leader(parent)) + parent = parent->group_leader; while (walker->pid> 0) { if (!thread_group_leader(walker)) walker = walker->group_leader; Acked-by: Stefan Bader<stefan.bader@canonical.com> The patch looks fine, we need SRU Justification text. Acked-by: Brad Figg <brad.figg@canonical.com> -- Brad Figg brad.figg@canonical.com http://www.canonical.com -- kernel-team mailing list kernel-team@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kernel-team |
Yama: fix default relationship to check thread group
On 04/08/2011 08:58 AM, Brad Figg wrote:
On 03/21/2011 02:51 AM, Stefan Bader wrote: On 03/18/2011 05:51 PM, Kees Cook wrote: Yet another case of a thread needing to match against the group leader. Signed-off-by: Kees Cook<kees.cook@canonical.com> --- security/yama/yama_lsm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index b05f1dd..c8f3020 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -173,6 +173,8 @@ static int task_is_descendant(struct task_struct *parent, rcu_read_lock(); read_lock(&tasklist_lock); + if (!thread_group_leader(parent)) + parent = parent->group_leader; while (walker->pid> 0) { if (!thread_group_leader(walker)) walker = walker->group_leader; Acked-by: Stefan Bader<stefan.bader@canonical.com> The patch looks fine, we need SRU Justification text. Acked-by: Brad Figg <brad.figg@canonical.com> Acked-by ..., applied -- Tim Gardner tim.gardner@canonical.com -- kernel-team mailing list kernel-team@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kernel-team |
Yama: fix default relationship to check thread group
On 03/18/2011 09:51 AM, Kees Cook wrote:
Yet another case of a thread needing to match against the group leader. Signed-off-by: Kees Cook<kees.cook@canonical.com> --- security/yama/yama_lsm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index b05f1dd..c8f3020 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -173,6 +173,8 @@ static int task_is_descendant(struct task_struct *parent, rcu_read_lock(); read_lock(&tasklist_lock); + if (!thread_group_leader(parent)) + parent = parent->group_leader; while (walker->pid> 0) { if (!thread_group_leader(walker)) walker = walker->group_leader; Acked-by: Brad Figg <brad.figg@canonical.com> -- Brad Figg brad.figg@canonical.com http://www.canonical.com -- kernel-team mailing list kernel-team@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kernel-team |
| All times are GMT. The time now is 07:48 PM. |
VBulletin, Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.