FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 02-23-2011, 02:20 PM
Tim Gardner
 
Default UBUNTU: lucid: allow printchanges to accept varying release commit messages

On 02/22/2011 07:45 PM, Jeremy Kerr wrote:

Hi Tim,


Jeremy - the second patch looks fine. As for the first patch, why not
just add branch customizations to a branch specific file that already
exists, e.g., debian/debian.env ?


When we're starting a new branch, we create a new debian.<project>, and don't
need to touch anything else in the tree (except for debian.env, but more about
that below). So, it'd be nice to contain the necessary variable within that
branch-specific config.

debian.env needs to be parseable as shell, and isn't directly sourced into the
make infrastructure at present. I'd like to avoid doing this, as it could
potentially contain non-make syntax. For setting $(DEBIAN), we currently parse
it with awk - we can't do the same for baseCommitRegex, which requires other
make vars to be set.

However, I'm happy to use an existing file if that's the preferred solution.
In this case, how about debian/rules.d/0-common-vars.mk ?



OK, thats a good point about debian/debian.env. I'm fine with a branch
specific file, which will also avoid conflicts in
debian/rules.d/0-common-vars.mk.


Thoughts Andy ?

rtg
--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 02-28-2011, 12:14 PM
Andy Whitcroft
 
Default UBUNTU: lucid: allow printchanges to accept varying release commit messages

On Wed, Feb 23, 2011 at 08:20:39AM -0700, Tim Gardner wrote:
> On 02/22/2011 07:45 PM, Jeremy Kerr wrote:
> >Hi Tim,
> >
> >>Jeremy - the second patch looks fine. As for the first patch, why not
> >>just add branch customizations to a branch specific file that already
> >>exists, e.g., debian/debian.env ?
> >
> >When we're starting a new branch, we create a new debian.<project>, and don't
> >need to touch anything else in the tree (except for debian.env, but more about
> >that below). So, it'd be nice to contain the necessary variable within that
> >branch-specific config.
> >
> >debian.env needs to be parseable as shell, and isn't directly sourced into the
> >make infrastructure at present. I'd like to avoid doing this, as it could
> >potentially contain non-make syntax. For setting $(DEBIAN), we currently parse
> >it with awk - we can't do the same for baseCommitRegex, which requires other
> >make vars to be set.
> >
> >However, I'm happy to use an existing file if that's the preferred solution.
> >In this case, how about debian/rules.d/0-common-vars.mk ?
> >
>
> OK, thats a good point about debian/debian.env. I'm fine with a
> branch specific file, which will also avoid conflicts in
> debian/rules.d/0-common-vars.mk.
>
> Thoughts Andy ?

If its branch specific, that seems appropriate that it would be a
separate file indeed. Though if they use a slightly different format
they might be able to pull into the current pattern, which basically
allows anything you like between the UBUNTU: and the Ubuntu-<version>.

No particular objection to the series overall. Have fun getting it back
to Lucid though .

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 07:03 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org