--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
11-24-2010, 08:44 PM
Tim Gardner
drm/i915: Avoid pageflipping freeze when we miss the flip prepare interrupt
On 11/24/2010 02:39 PM, Brad Figg wrote:
> On 11/24/2010 10:50 AM, Tim Gardner wrote:
>> On 11/24/2010 11:45 AM, Brad Figg wrote:
>>> On 11/24/2010 09:56 AM, Tim Gardner wrote:
>>>> git://kernel.ubuntu.com/rtg/ubuntu-maverick.git i915-page-flip-lp680204
>>>
>>> Looks good.
>>>
>>> Acked-by: Brad Figg<brad.figg@canonical.com>
>>>
>>
>> Applied to maverick master-next
>>
>
> I was sort of expecting someone else to also Ack this.
>
> Brad
I didn't write the patch. Isn't my Ack enough? Besides, its already been
vetted by 2 other upstream developers.
rtg
--
Tim Gardner tim.gardner@canonical.com
--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
11-24-2010, 11:21 PM
Brad Figg
drm/i915: Avoid pageflipping freeze when we miss the flip prepare interrupt
On 11/24/2010 01:44 PM, Tim Gardner wrote:
> On 11/24/2010 02:39 PM, Brad Figg wrote:
>> On 11/24/2010 10:50 AM, Tim Gardner wrote:
>>> On 11/24/2010 11:45 AM, Brad Figg wrote:
>>>> On 11/24/2010 09:56 AM, Tim Gardner wrote:
>>>>> git://kernel.ubuntu.com/rtg/ubuntu-maverick.git i915-page-flip-lp680204
>>>>
>>>> Looks good.
>>>>
>>>> Acked-by: Brad Figg<brad.figg@canonical.com>
>>>>
>>>
>>> Applied to maverick master-next
>>>
>>
>> I was sort of expecting someone else to also Ack this.
>>
>> Brad
>
> I didn't write the patch. Isn't my Ack enough? Besides, its already been vetted by 2 other upstream developers.
>
> rtg
Maybe it is my misunderstanding of our process. I have observed in the past
that it appeared the submitter, even of an upstream cherry-pick didn't count
as an ack. Now, not all submitters have been senior kdevs.
It makes sense that since the commit came from upstream with those Acks/Sobs
and your own, that should be enough.
--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
11-25-2010, 09:04 AM
Stefan Bader
drm/i915: Avoid pageflipping freeze when we miss the flip prepare interrupt
On 11/25/2010 01:21 AM, Brad Figg wrote:
> On 11/24/2010 01:44 PM, Tim Gardner wrote:
>> On 11/24/2010 02:39 PM, Brad Figg wrote:
>>> On 11/24/2010 10:50 AM, Tim Gardner wrote:
>>>> On 11/24/2010 11:45 AM, Brad Figg wrote:
>>>>> On 11/24/2010 09:56 AM, Tim Gardner wrote:
>>>>>> git://kernel.ubuntu.com/rtg/ubuntu-maverick.git i915-page-flip-lp680204
>>>>>
>>>>> Looks good.
>>>>>
>>>>> Acked-by: Brad Figg<brad.figg@canonical.com>
>>>>>
>>>>
>>>> Applied to maverick master-next
>>>>
>>>
>>> I was sort of expecting someone else to also Ack this.
>>>
>>> Brad
>>
>> I didn't write the patch. Isn't my Ack enough? Besides, its already been vetted by 2 other upstream developers.
>>
>> rtg
>
> Maybe it is my misunderstanding of our process. I have observed in the past
> that it appeared the submitter, even of an upstream cherry-pick didn't count
> as an ack. Now, not all submitters have been senior kdevs.
>
> It makes sense that since the commit came from upstream with those Acks/Sobs
> and your own, that should be enough.
>
> Brad
You could freely change it by now. I used to exclude the submitter of an
upstream patch from the acks normally. The reasoning to me was that when I
submit patches, I am usually biased and not very critical in the review.
But that may just been my personal reading of the two ack rule. And whatever you
decide, then chisel the result into wiki-stone.
-Stefan
--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
drm/i915: Avoid pageflipping freeze when we miss the flip prepare interrupt
