FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 11-21-2010, 06:03 AM
Kees Cook
 
Default nx-emu: fix inverted report of disable_nx

This nx-emu commit:
http://git.kernel.org/?p=linux/kernel/git/frob/linux-2.6-roland.git;a=commitdiff;h=b86f45c02494d4cba26caf13 2e8a178854e812fd
was intended to replace "exec_shield" with "!disable_nx", but in
x86_report_nx() it was not correctly inverted resulting in a backward
report to dmesg about the state of nx-emu.

Signed-off-by: Kees Cook <kees.cook@canonical.com>
---
arch/x86/mm/setup_nx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/setup_nx.c b/arch/x86/mm/setup_nx.c
index b936b25..1d7a269 100644
--- a/arch/x86/mm/setup_nx.c
+++ b/arch/x86/mm/setup_nx.c
@@ -42,7 +42,7 @@ void __init x86_report_nx(void)
{
if (!cpu_has_nx) {
#ifdef CONFIG_X86_32
- if (disable_nx)
+ if (!disable_nx)
printk(KERN_INFO "NX (Execute Disable) protection: "
"approximated by x86 segment limits
");
else
--
1.7.2.3


--
Kees Cook
Ubuntu Security Team

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 11-22-2010, 06:47 PM
Kyle McMartin
 
Default nx-emu: fix inverted report of disable_nx

On Sat, Nov 20, 2010 at 11:03:42PM -0800, Kees Cook wrote:
> This nx-emu commit:
> http://git.kernel.org/?p=linux/kernel/git/frob/linux-2.6-roland.git;a=commitdiff;h=b86f45c02494d4cba26caf13 2e8a178854e812fd
> was intended to replace "exec_shield" with "!disable_nx", but in
> x86_report_nx() it was not correctly inverted resulting in a backward
> report to dmesg about the state of nx-emu.
>
> Signed-off-by: Kees Cook <kees.cook@canonical.com>

Thanks, applied (to Fedora at least.)

--Kyle

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 11-22-2010, 07:20 PM
Tim Gardner
 
Default nx-emu: fix inverted report of disable_nx

On 11/21/2010 12:03 AM, Kees Cook wrote:
> This nx-emu commit:
> http://git.kernel.org/?p=linux/kernel/git/frob/linux-2.6-roland.git;a=commitdiff;h=b86f45c02494d4cba26caf13 2e8a178854e812fd
> was intended to replace "exec_shield" with "!disable_nx", but in
> x86_report_nx() it was not correctly inverted resulting in a backward
> report to dmesg about the state of nx-emu.
>
> Signed-off-by: Kees Cook<kees.cook@canonical.com>
> ---
> arch/x86/mm/setup_nx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/mm/setup_nx.c b/arch/x86/mm/setup_nx.c
> index b936b25..1d7a269 100644
> --- a/arch/x86/mm/setup_nx.c
> +++ b/arch/x86/mm/setup_nx.c
> @@ -42,7 +42,7 @@ void __init x86_report_nx(void)
> {
> if (!cpu_has_nx) {
> #ifdef CONFIG_X86_32
> - if (disable_nx)
> + if (!disable_nx)
> printk(KERN_INFO "NX (Execute Disable) protection: "
> "approximated by x86 segment limits
");
> else

Applied to Ubuntu natty

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 11-22-2010, 10:37 PM
Roland McGrath
 
Default nx-emu: fix inverted report of disable_nx

I merged it into my fedora/x86-nx-emulation tree.

Thanks,
Roland

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 04:33 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org