FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 06-08-2010, 03:16 PM
Stefan Bader
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On 06/08/2010 04:47 PM, Brad Figg wrote:
> On 06/08/2010 07:28 AM, Eric Miao wrote:
>> Stefan,
>>
>> Below are the patches needed to sync our mvl-dove branch with Marvell
>> LSP 5.2.1
>> which Chase is looking for. All 10 code fixes. Please help pull.
>>
>> The following changes since commit
>> 191d3ad543c66bbe69c61877637decdf3653bfa2:
>> Eric Miao (1):
>> UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>
>> are available in the git repository at:
>>
>> git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249

Brad, this is a bit hidden but the branch name is a hint to the tracking bug.
Just for info of all, I need to apply the previous update and then there was
another request in between. Something with overwriting ramdisk i believe. For
now apw is having a go to merge back the merrits of the polished abstracted
debian. If he is done, we could go there.

-Stefan
>>
>> Chao Deng (1):
>> Fix wrong stride issue for RGB565 on overlay
>>
>> Ethan Ku (1):
>> fix spi flash type to mx2513205d for AVD1 rev2
>>
>> Green Wan (1):
>> Refine alogrithm of filling yuv pitch length and do correction
>> when input pitch value<= 0.
>>
>> Joseph Lo (2):
>> MRVL BMM module update
>> BMM module: remove ioremap_xxx for kernel space VA mapping
>>
>> Saeed Bishara (3):
>> dove pm: restore cp15 Marvell Auxiliary Function and PMC register
>> dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
>> dove: register the usb as host mode when HAL drivers disabled
>>
>> Tawfik Bayouk (1):
>> Nand: fix PIO support for 8bit devices.
>>
>> stephenkou (1):
>> Fix colorkey issue with PM
>>
>> arch/arm/mach-dove/common.c | 5 +-
>> arch/arm/mach-dove/dove-db-setup.c | 4 +-
>> arch/arm/mach-dove/dove-rd-avng-setup.c | 5 +-
>> arch/arm/mach-dove/mv_hal_support/Makefile | 2 +-
>> .../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S | 15 +++-
>> drivers/misc/mrvl-bmm/bmm_drv.c | 88
>> ++++++++++++----
>> drivers/misc/mrvl-bmm/bmm_drv.h | 48 +++++-----
>> drivers/mtd/nand/dove_nand_hal.c | 50 ++++++---
>> drivers/video/marvell/dovefb_base.c | 34 +++++-
>> drivers/video/marvell/dovefb_ovly.c | 105
>> +++++++++++++-------
>> 10 files changed, 242 insertions(+), 114 deletions(-)
>>
>
> We need an SRU bug for this.
>
> Brad


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 03:23 PM
Brad Figg
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On 06/08/2010 08:16 AM, Stefan Bader wrote:
> On 06/08/2010 04:47 PM, Brad Figg wrote:
>> On 06/08/2010 07:28 AM, Eric Miao wrote:
>>> Stefan,
>>>
>>> Below are the patches needed to sync our mvl-dove branch with Marvell
>>> LSP 5.2.1
>>> which Chase is looking for. All 10 code fixes. Please help pull.
>>>
>>> The following changes since commit
>>> 191d3ad543c66bbe69c61877637decdf3653bfa2:
>>> Eric Miao (1):
>>> UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>>
>>> are available in the git repository at:
>>>
>>> git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249
>
> Brad, this is a bit hidden but the branch name is a hint to the tracking bug.
> Just for info of all, I need to apply the previous update and then there was
> another request in between. Something with overwriting ramdisk i believe. For
> now apw is having a go to merge back the merrits of the polished abstracted
> debian. If he is done, we could go there.
>
> -Stefan
>>>
>>> Chao Deng (1):
>>> Fix wrong stride issue for RGB565 on overlay
>>>
>>> Ethan Ku (1):
>>> fix spi flash type to mx2513205d for AVD1 rev2
>>>
>>> Green Wan (1):
>>> Refine alogrithm of filling yuv pitch length and do correction
>>> when input pitch value<= 0.
>>>
>>> Joseph Lo (2):
>>> MRVL BMM module update
>>> BMM module: remove ioremap_xxx for kernel space VA mapping
>>>
>>> Saeed Bishara (3):
>>> dove pm: restore cp15 Marvell Auxiliary Function and PMC register
>>> dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
>>> dove: register the usb as host mode when HAL drivers disabled
>>>
>>> Tawfik Bayouk (1):
>>> Nand: fix PIO support for 8bit devices.
>>>
>>> stephenkou (1):
>>> Fix colorkey issue with PM
>>>
>>> arch/arm/mach-dove/common.c | 5 +-
>>> arch/arm/mach-dove/dove-db-setup.c | 4 +-
>>> arch/arm/mach-dove/dove-rd-avng-setup.c | 5 +-
>>> arch/arm/mach-dove/mv_hal_support/Makefile | 2 +-
>>> .../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S | 15 +++-
>>> drivers/misc/mrvl-bmm/bmm_drv.c | 88
>>> ++++++++++++----
>>> drivers/misc/mrvl-bmm/bmm_drv.h | 48 +++++-----
>>> drivers/mtd/nand/dove_nand_hal.c | 50 ++++++---
>>> drivers/video/marvell/dovefb_base.c | 34 +++++-
>>> drivers/video/marvell/dovefb_ovly.c | 105
>>> +++++++++++++-------
>>> 10 files changed, 242 insertions(+), 114 deletions(-)
>>>
>>
>> We need an SRU bug for this.
>>
>> Brad
>

Stephan,

Thanks, should have noticed that. I was expecting the SRU justification and
all to come with the pull request email.

Brad
--
Brad Figg brad.figg@canonical.com http://www.canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 03:30 PM
Stefan Bader
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On 06/08/2010 05:23 PM, Brad Figg wrote:
> On 06/08/2010 08:16 AM, Stefan Bader wrote:
>> On 06/08/2010 04:47 PM, Brad Figg wrote:
>>> On 06/08/2010 07:28 AM, Eric Miao wrote:
>>>> Stefan,
>>>>
>>>> Below are the patches needed to sync our mvl-dove branch with Marvell
>>>> LSP 5.2.1
>>>> which Chase is looking for. All 10 code fixes. Please help pull.
>>>>
>>>> The following changes since commit
>>>> 191d3ad543c66bbe69c61877637decdf3653bfa2:
>>>> Eric Miao (1):
>>>> UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>>>
>>>> are available in the git repository at:
>>>>
>>>> git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249
>>
>> Brad, this is a bit hidden but the branch name is a hint to the
>> tracking bug.
>> Just for info of all, I need to apply the previous update and then
>> there was
>> another request in between. Something with overwriting ramdisk i
>> believe. For
>> now apw is having a go to merge back the merrits of the polished
>> abstracted
>> debian. If he is done, we could go there.
>>
>> -Stefan
>>>>
>>>> Chao Deng (1):
>>>> Fix wrong stride issue for RGB565 on overlay
>>>>
>>>> Ethan Ku (1):
>>>> fix spi flash type to mx2513205d for AVD1 rev2
>>>>
>>>> Green Wan (1):
>>>> Refine alogrithm of filling yuv pitch length and do correction
>>>> when input pitch value<= 0.
>>>>
>>>> Joseph Lo (2):
>>>> MRVL BMM module update
>>>> BMM module: remove ioremap_xxx for kernel space VA mapping
>>>>
>>>> Saeed Bishara (3):
>>>> dove pm: restore cp15 Marvell Auxiliary Function and PMC
>>>> register
>>>> dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
>>>> dove: register the usb as host mode when HAL drivers disabled
>>>>
>>>> Tawfik Bayouk (1):
>>>> Nand: fix PIO support for 8bit devices.
>>>>
>>>> stephenkou (1):
>>>> Fix colorkey issue with PM
>>>>
>>>> arch/arm/mach-dove/common.c | 5 +-
>>>> arch/arm/mach-dove/dove-db-setup.c | 4 +-
>>>> arch/arm/mach-dove/dove-rd-avng-setup.c | 5 +-
>>>> arch/arm/mach-dove/mv_hal_support/Makefile | 2 +-
>>>> .../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S | 15 +++-
>>>> drivers/misc/mrvl-bmm/bmm_drv.c | 88
>>>> ++++++++++++----
>>>> drivers/misc/mrvl-bmm/bmm_drv.h | 48 +++++-----
>>>> drivers/mtd/nand/dove_nand_hal.c | 50 ++++++---
>>>> drivers/video/marvell/dovefb_base.c | 34 +++++-
>>>> drivers/video/marvell/dovefb_ovly.c | 105
>>>> +++++++++++++-------
>>>> 10 files changed, 242 insertions(+), 114 deletions(-)
>>>>
>>>
>>> We need an SRU bug for this.
>>>
>>> Brad
>>
>
> Stephan,
>
> Thanks, should have noticed that. I was expecting the SRU justification and
> all to come with the pull request email.
>
> Brad

In an ideal world, yes. otoh in that world I would have an example wiki page to
point people to. Another good idea to have...

Stefan

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 04:02 PM
Chase Douglas
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On Tue, 2010-06-08 at 17:16 +0200, Stefan Bader wrote:
> Just for info of all, I need to apply the previous update and then there was
> another request in between. Something with overwriting ramdisk i believe. For
> now apw is having a go to merge back the merrits of the polished abstracted
> debian. If he is done, we could go there.

Assuming these new changes are ACK'd and apw is done with his common
debianization work in the next day or so, how soon do you foresee these
changes being merged into the lucid branch. If it will take a few days
I'll probably wait to rebase the hedley sources. However, if you think
it will take more than a week I may apply these changes for hedley and
rebase later.

Thanks,

-- Chase


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 08:27 PM
Stefan Bader
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On 06/08/2010 06:02 PM, Chase Douglas wrote:
> On Tue, 2010-06-08 at 17:16 +0200, Stefan Bader wrote:
>> Just for info of all, I need to apply the previous update and then there was
>> another request in between. Something with overwriting ramdisk i believe. For
>> now apw is having a go to merge back the merrits of the polished abstracted
>> debian. If he is done, we could go there.
>
> Assuming these new changes are ACK'd and apw is done with his common
> debianization work in the next day or so, how soon do you foresee these
> changes being merged into the lucid branch. If it will take a few days
> I'll probably wait to rebase the hedley sources. However, if you think
> it will take more than a week I may apply these changes for hedley and
> rebase later.
>
> Thanks,
>
> -- Chase
>

This depends a bit on time, time and a bit more time. The time it takes to
complete the debian work, the time I got while being on LinuxTag in Berlin to
apply and rebase things and finally the time I have a network. I am actually
quite impressed that I currently have access now. This place has a certain rough
charm. :-P
But I really hope to get that done this week because I want the three upstream
stable updates pending to be in proposed.

-Stefan

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 08:52 PM
Chase Douglas
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On Tue, 2010-06-08 at 22:28 +0800, Eric Miao wrote:
> Stefan,
>
> Below are the patches needed to sync our mvl-dove branch with Marvell LSP 5.2.1
> which Chase is looking for. All 10 code fixes. Please help pull.
>
> The following changes since commit 191d3ad543c66bbe69c61877637decdf3653bfa2:
> Eric Miao (1):
> UBUNTU: [Config]: sync with Dove LSP 5.1.0
>
> are available in the git repository at:
>
> git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249
>
> Chao Deng (1):
> Fix wrong stride issue for RGB565 on overlay
>
> Ethan Ku (1):
> fix spi flash type to mx2513205d for AVD1 rev2
>
> Green Wan (1):
> Refine alogrithm of filling yuv pitch length and do correction
> when input pitch value <= 0.
>
> Joseph Lo (2):
> MRVL BMM module update
> BMM module: remove ioremap_xxx for kernel space VA mapping
>
> Saeed Bishara (3):
> dove pm: restore cp15 Marvell Auxiliary Function and PMC register
> dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
> dove: register the usb as host mode when HAL drivers disabled
>
> Tawfik Bayouk (1):
> Nand: fix PIO support for 8bit devices.
>
> stephenkou (1):
> Fix colorkey issue with PM
>
> arch/arm/mach-dove/common.c | 5 +-
> arch/arm/mach-dove/dove-db-setup.c | 4 +-
> arch/arm/mach-dove/dove-rd-avng-setup.c | 5 +-
> arch/arm/mach-dove/mv_hal_support/Makefile | 2 +-
> .../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S | 15 +++-
> drivers/misc/mrvl-bmm/bmm_drv.c | 88 ++++++++++++----
> drivers/misc/mrvl-bmm/bmm_drv.h | 48 +++++-----
> drivers/mtd/nand/dove_nand_hal.c | 50 ++++++---
> drivers/video/marvell/dovefb_base.c | 34 +++++-
> drivers/video/marvell/dovefb_ovly.c | 105 +++++++++++++-------
> 10 files changed, 242 insertions(+), 114 deletions(-)

A lot of these changes are cryptic and do not contain meaningful commit
messages, but after dealing with LSP patches for the Hedley project I
can't fault Eric . That said, it is hard to figure out what is going
on in some of them, and I really don't know what many of the changes
really do. However, they do come from Marvell, and they only touch
Marvell specific code, so I feel I can trust them. Most of the changes
are really bug fixes anyways and not huge changes to the source code.

Acked-by: Chase Douglas <chase.douglas@canonical.com>


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-09-2010, 01:02 AM
Eric Miao
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On Wed, Jun 9, 2010 at 4:52 AM, Chase Douglas
<chase.douglas@canonical.com> wrote:
> On Tue, 2010-06-08 at 22:28 +0800, Eric Miao wrote:
>> Stefan,
>>
>> Below are the patches needed to sync our mvl-dove branch with Marvell LSP 5.2.1
>> which Chase is looking for. All 10 code fixes. Please help pull.
>>
>> The following changes since commit 191d3ad543c66bbe69c61877637decdf3653bfa2:
>> * Eric Miao (1):
>> * * * * UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>
>> are available in the git repository at:
>>
>> * git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249
>>
>> Chao Deng (1):
>> * * * Fix wrong stride issue for RGB565 on overlay
>>
>> Ethan Ku (1):
>> * * * fix spi flash type to mx2513205d for AVD1 rev2
>>
>> Green Wan (1):
>> * * * Refine alogrithm of filling yuv pitch length and do correction
>> when input pitch value <= 0.
>>
>> Joseph Lo (2):
>> * * * MRVL BMM module update
>> * * * BMM module: remove ioremap_xxx for kernel space VA mapping
>>
>> Saeed Bishara (3):
>> * * * dove pm: restore cp15 Marvell Auxiliary Function and PMC register
>> * * * dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
>> * * * dove: register the usb as host mode when HAL drivers disabled
>>
>> Tawfik Bayouk (1):
>> * * * Nand: fix PIO support for 8bit devices.
>>
>> stephenkou (1):
>> * * * Fix colorkey issue with PM
>>
>> *arch/arm/mach-dove/common.c * * * * * * * * * * * *| * *5 +-
>> *arch/arm/mach-dove/dove-db-setup.c * * * * * * * * | * *4 +-
>> *arch/arm/mach-dove/dove-rd-avng-setup.c * * * * * *| * *5 +-
>> *arch/arm/mach-dove/mv_hal_support/Makefile * * * * | * *2 +-
>> *.../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S * * * * *| * 15 +++-
>> *drivers/misc/mrvl-bmm/bmm_drv.c * * * * * * * * * *| * 88 ++++++++++++----
>> *drivers/misc/mrvl-bmm/bmm_drv.h * * * * * * * * * *| * 48 +++++-----
>> *drivers/mtd/nand/dove_nand_hal.c * * * * * * * * * | * 50 ++++++---
>> *drivers/video/marvell/dovefb_base.c * * * * * * * *| * 34 +++++-
>> *drivers/video/marvell/dovefb_ovly.c * * * * * * * *| *105 +++++++++++++-------
>> *10 files changed, 242 insertions(+), 114 deletions(-)
>
> A lot of these changes are cryptic and do not contain meaningful commit
> messages, but after dealing with LSP patches for the Hedley project I
> can't fault Eric . That said, it is hard to figure out what is going
> on in some of them, and I really don't know what many of the changes
> really do. However, they do come from Marvell, and they only touch
> Marvell specific code, so I feel I can trust them. Most of the changes
> are really bug fixes anyways and not huge changes to the source code.
>
> Acked-by: Chase Douglas <chase.douglas@canonical.com>
>

Stefan,

These are actually rebased on top of your last pull (the one again rebased
on top of the security patches). If you haven't yet committed all the crap,
you may have noticed the title of commit 191d3ad:

>> Eric Miao (1):
>> * * * * UBUNTU: [Config]: sync with Dove LSP 5.1.0

is wrong, which should be "sync with Dove LSP 5.1.1". It will make things
a bit clearer if you can 'reword' that commit message?

Sorry for the mistake and let me know you prefer me to have a change
here at my side and send a pull again?

Thanks
- eric

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-09-2010, 01:24 AM
Eric Miao
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

> We need an SRU bug for this.
>

Sorry Brad,

I did forget to mention the justification, here's a simple one if it
makes sense:

BugLink: http://bugs.launchpad.net/bugs/591249

Marvell has released LSP version 5.2.1 for their Dove platform. There
are all 10 fixes in total since their 5.1.1 release. All are fixes to
the code, no change to configs, as are shown below:

dove pm: restore cp15 Marvell Auxiliary Function and PMC register
dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
dove: register the usb as host mode when HAL drivers disabled
Fix wrong stride issue for RGB565 on overlay
Refine alogrithm of filling yuv pitch length and do correction
when input pitch value <= 0.
Nand: fix PIO support for 8bit devices.
MRVL BMM module update
BMM module: remove ioremap_xxx for kernel space VA mapping
fix spi flash type to mx2513205d for AVD1 rev2
Fix colorkey issue with PM

A short diffstat shows:
arch/arm/mach-dove/common.c | 5 +-
arch/arm/mach-dove/dove-db-setup.c | 4 +-
arch/arm/mach-dove/dove-rd-avng-setup.c | 5 +-
arch/arm/mach-dove/mv_hal_support/Makefile | 2 +-
.../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S | 15 +++-
drivers/misc/mrvl-bmm/bmm_drv.c | 88 ++++++++++++----
drivers/misc/mrvl-bmm/bmm_drv.h | 48 +++++-----
drivers/mtd/nand/dove_nand_hal.c | 50 ++++++---
drivers/video/marvell/dovefb_base.c | 34 +++++-
drivers/video/marvell/dovefb_ovly.c | 105
+++++++++++++-------
10 files changed, 242 insertions(+), 114 deletions(-)

A review of the changes shows it's less likely to cause any regressions.

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-09-2010, 09:13 AM
Stefan Bader
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On 06/09/2010 03:02 AM, Eric Miao wrote:
> On Wed, Jun 9, 2010 at 4:52 AM, Chase Douglas
> <chase.douglas@canonical.com> wrote:
>> On Tue, 2010-06-08 at 22:28 +0800, Eric Miao wrote:
>>> Stefan,
>>>
>>> Below are the patches needed to sync our mvl-dove branch with Marvell LSP 5.2.1
>>> which Chase is looking for. All 10 code fixes. Please help pull.
>>>
>>> The following changes since commit 191d3ad543c66bbe69c61877637decdf3653bfa2:
>>> Eric Miao (1):
>>> UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>>
>>> are available in the git repository at:
>>>
>>> git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249
>>>
>>> Chao Deng (1):
>>> Fix wrong stride issue for RGB565 on overlay
>>>
>>> Ethan Ku (1):
>>> fix spi flash type to mx2513205d for AVD1 rev2
>>>
>>> Green Wan (1):
>>> Refine alogrithm of filling yuv pitch length and do correction
>>> when input pitch value <= 0.
>>>
>>> Joseph Lo (2):
>>> MRVL BMM module update
>>> BMM module: remove ioremap_xxx for kernel space VA mapping
>>>
>>> Saeed Bishara (3):
>>> dove pm: restore cp15 Marvell Auxiliary Function and PMC register
>>> dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
>>> dove: register the usb as host mode when HAL drivers disabled
>>>
>>> Tawfik Bayouk (1):
>>> Nand: fix PIO support for 8bit devices.
>>>
>>> stephenkou (1):
>>> Fix colorkey issue with PM
>>>
>>> arch/arm/mach-dove/common.c | 5 +-
>>> arch/arm/mach-dove/dove-db-setup.c | 4 +-
>>> arch/arm/mach-dove/dove-rd-avng-setup.c | 5 +-
>>> arch/arm/mach-dove/mv_hal_support/Makefile | 2 +-
>>> .../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S | 15 +++-
>>> drivers/misc/mrvl-bmm/bmm_drv.c | 88 ++++++++++++----
>>> drivers/misc/mrvl-bmm/bmm_drv.h | 48 +++++-----
>>> drivers/mtd/nand/dove_nand_hal.c | 50 ++++++---
>>> drivers/video/marvell/dovefb_base.c | 34 +++++-
>>> drivers/video/marvell/dovefb_ovly.c | 105 +++++++++++++-------
>>> 10 files changed, 242 insertions(+), 114 deletions(-)
>>
>> A lot of these changes are cryptic and do not contain meaningful commit
>> messages, but after dealing with LSP patches for the Hedley project I
>> can't fault Eric . That said, it is hard to figure out what is going
>> on in some of them, and I really don't know what many of the changes
>> really do. However, they do come from Marvell, and they only touch
>> Marvell specific code, so I feel I can trust them. Most of the changes
>> are really bug fixes anyways and not huge changes to the source code.
>>
>> Acked-by: Chase Douglas <chase.douglas@canonical.com>
>>
>
> Stefan,
>
> These are actually rebased on top of your last pull (the one again rebased
> on top of the security patches). If you haven't yet committed all the crap,
> you may have noticed the title of commit 191d3ad:
>
>>> Eric Miao (1):
>>> UBUNTU: [Config]: sync with Dove LSP 5.1.0
>
> is wrong, which should be "sync with Dove LSP 5.1.1". It will make things
> a bit clearer if you can 'reword' that commit message?
>
> Sorry for the mistake and let me know you prefer me to have a change
> here at my side and send a pull again?
>
> Thanks
> - eric

Hi Eric,

thanks for the hint, I will keep that in mind when we try to merge everything
back. I will need to see how to proceed there anyway. From the last time
experience somehow it felt like your base has somehow diverged from the one I am
using. Like this patch which changes a file which has DOS newlines in the tree I
have, but your patch is formed like the file is cleaned. I will have to see how
the most recent patches go.
From the contents, well I know where they are coming from and I trust you to
have tested on the hw involved and the tree is specific to only that hardware,
so the regression risk for the main distro is non-existing.

Acked-by: Stefan Bader <stefan.bader@canonical.com>


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-09-2010, 09:40 AM
Eric Miao
 
Default mvl-dove: sync to LSP 5.2.1 (LP591249)

On Wed, Jun 9, 2010 at 5:13 PM, Stefan Bader <stefan.bader@canonical.com> wrote:
> On 06/09/2010 03:02 AM, Eric Miao wrote:
>> On Wed, Jun 9, 2010 at 4:52 AM, Chase Douglas
>> <chase.douglas@canonical.com> wrote:
>>> On Tue, 2010-06-08 at 22:28 +0800, Eric Miao wrote:
>>>> Stefan,
>>>>
>>>> Below are the patches needed to sync our mvl-dove branch with Marvell LSP 5.2.1
>>>> which Chase is looking for. All 10 code fixes. Please help pull.
>>>>
>>>> The following changes since commit 191d3ad543c66bbe69c61877637decdf3653bfa2:
>>>> * Eric Miao (1):
>>>> * * * * UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>>>
>>>> are available in the git repository at:
>>>>
>>>> * git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp591249
>>>>
>>>> Chao Deng (1):
>>>> * * * Fix wrong stride issue for RGB565 on overlay
>>>>
>>>> Ethan Ku (1):
>>>> * * * fix spi flash type to mx2513205d for AVD1 rev2
>>>>
>>>> Green Wan (1):
>>>> * * * Refine alogrithm of filling yuv pitch length and do correction
>>>> when input pitch value <= 0.
>>>>
>>>> Joseph Lo (2):
>>>> * * * MRVL BMM module update
>>>> * * * BMM module: remove ioremap_xxx for kernel space VA mapping
>>>>
>>>> Saeed Bishara (3):
>>>> * * * dove pm: restore cp15 Marvell Auxiliary Function and PMC register
>>>> * * * dove: fix build issues when MV_HAL_DRIVERS_SUPPORT disabled
>>>> * * * dove: register the usb as host mode when HAL drivers disabled
>>>>
>>>> Tawfik Bayouk (1):
>>>> * * * Nand: fix PIO support for 8bit devices.
>>>>
>>>> stephenkou (1):
>>>> * * * Fix colorkey issue with PM
>>>>
>>>> *arch/arm/mach-dove/common.c * * * * * * * * * * * *| * *5 +-
>>>> *arch/arm/mach-dove/dove-db-setup.c * * * * * * * * | * *4 +-
>>>> *arch/arm/mach-dove/dove-rd-avng-setup.c * * * * * *| * *5 +-
>>>> *arch/arm/mach-dove/mv_hal_support/Makefile * * * * | * *2 +-
>>>> *.../mv_hal_drivers/mv_hal/pmu/mvPmu_asm.S * * * * *| * 15 +++-
>>>> *drivers/misc/mrvl-bmm/bmm_drv.c * * * * * * * * * *| * 88 ++++++++++++----
>>>> *drivers/misc/mrvl-bmm/bmm_drv.h * * * * * * * * * *| * 48 +++++-----
>>>> *drivers/mtd/nand/dove_nand_hal.c * * * * * * * * * | * 50 ++++++---
>>>> *drivers/video/marvell/dovefb_base.c * * * * * * * *| * 34 +++++-
>>>> *drivers/video/marvell/dovefb_ovly.c * * * * * * * *| *105 +++++++++++++-------
>>>> *10 files changed, 242 insertions(+), 114 deletions(-)
>>>
>>> A lot of these changes are cryptic and do not contain meaningful commit
>>> messages, but after dealing with LSP patches for the Hedley project I
>>> can't fault Eric . That said, it is hard to figure out what is going
>>> on in some of them, and I really don't know what many of the changes
>>> really do. However, they do come from Marvell, and they only touch
>>> Marvell specific code, so I feel I can trust them. Most of the changes
>>> are really bug fixes anyways and not huge changes to the source code.
>>>
>>> Acked-by: Chase Douglas <chase.douglas@canonical.com>
>>>
>>
>> Stefan,
>>
>> These are actually rebased on top of your last pull (the one again rebased
>> on top of the security patches). If you haven't yet committed all the crap,
>> you may have noticed the title of commit 191d3ad:
>>
>>>> Eric Miao (1):
>>>> * * * * UBUNTU: [Config]: sync with Dove LSP 5.1.0
>>
>> is wrong, which should be "sync with Dove LSP 5.1.1". It will make things
>> a bit clearer if you can 'reword' that commit message?
>>
>> Sorry for the mistake and let me know you prefer me to have a change
>> here at my side and send a pull again?
>>
>> Thanks
>> - eric
>
> Hi Eric,
>
> thanks for the hint, I will keep that in mind when we try to merge everything
> back. I will need to see how to proceed there anyway. From the last time
> experience somehow it felt like your base has somehow diverged from the one I am
> using. Like this patch which changes a file which has DOS newlines in the tree I
> have, but your patch is formed like the file is cleaned. I will have to see how
> the most recent patches go.

Stefan,

Hold on for a while, I do think the DOS newlines things caused some mess.
There is a build failure with GC600. Let me try to fix that first.

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 08:09 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org