FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 06-01-2010, 04:52 PM
Leann Ogasawara
 
Default UBUNTU: Enable perf to be more helpful when perf_ does not exist.

On Tue, 2010-06-01 at 11:47 +0100, Lee Jones wrote:
> > The pull request is correct. For most patches (except the truly
> > gargantuan ones) I attach or inline so that patchwork detects it as a
> > patch which makes the release maintainers job easier.

Hi Lee,

Based on the nominations in the bug report, I assume this patch is
intended for both Maverick and Lucid.

And just a small tweak noted below. . .

> commit 8a2775c937d9349e8c7ccb915a3d2b134c13f09b
> Author: Lee Jones <lee.jones@canonical.com>
> Date: Tue May 25 11:49:32 2010 +0100
>
> UBUNTU: Enable perf to be more helpful when perf_<version> does not
> exist.
>
> http://bugs.launchpad.net/bugs/570500

This should be:

BugLink: http://bugs.launchpad.net/bugs/570500

The launchpad janitor parses for the above syntax and will auto close
the bug when the fix is uploaded.

Thanks,
Leann

>
> Signed-off-by: Lee Jones <lee.jones@canonical.com>
>
>
> diff --git a/debian/tools/perf b/debian/tools/perf
> index 79253d2..ab35fab 100644 (file)
> --- a/debian/tools/perf
> +++ b/debian/tools/perf
> @@ -1,7 +1,16 @@
> #!/bin/bash
> -version=`uname -r`
> -flavour=${version#*-}
> -flavour=${flavour#*-}
> -version=${version%-$flavour}
> +full_version=`uname -r`
>
> -exec "perf_$version" "$@"
> +# Removing flavour from version i.e. generic or server.
> +flavour_abi=${full_version#*-}
> +flavour=${flavour_abi#*-}
> +version=${full_version%-$flavour}
> +perf="perf_$version"
> +
> +if ! which "$perf" > /dev/null; then
> + echo "$perf not found" >&2
> + echo "You may need to install linux-tools-$version" >&2
> + exit 2
> +fi
> +
> +exec "$perf" "$@"
>
> Hopefully this is better.
>
> Kind regards,
> Lee
>



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-01-2010, 05:05 PM
Lee Jones
 
Default UBUNTU: Enable perf to be more helpful when perf_ does not exist.

commit 8a2775c937d9349e8c7ccb915a3d2b134c13f09b
Author: Lee Jones <lee.jones@canonical.com>
Date: Tue May 25 11:49:32 2010 +0100

UBUNTU: Enable perf to be more helpful when perf_<version> does not exist.

BugLink: http://bugs.launchpad.net/bugs/570500

Signed-off-by: Lee Jones <lee.jones@canonical.com>


diff --git a/debian/tools/perf b/debian/tools/perf
index 79253d2..ab35fab 100644 (file)
--- a/debian/tools/perf
+++ b/debian/tools/perf
@@ -1,7 +1,16 @@
#!/bin/bash
-version=`uname -r`
-flavour=${version#*-}
-flavour=${flavour#*-}
-version=${version%-$flavour}
+full_version=`uname -r`

-exec "perf_$version" "$@"
+# Removing flavour from version i.e. generic or server.
+flavour_abi=${full_version#*-}
+flavour=${flavour_abi#*-}
+version=${full_version%-$flavour}
+perf="perf_$version"
+
+if ! which "$perf" > /dev/null; then
+ echo "$perf not found" >&2
+ echo "You may need to install linux-tools-$version" >&2
+ exit 2
+fi
+
+exec "$perf" "$@"



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 01:16 PM
Lee Jones
 
Default UBUNTU: Enable perf to be more helpful when perf_ does not exist.

Hi all,

This patch as already been excepted in Maverick.

I would also like it to go into Lucid.

The following changes since commit f8b7e92f771b23dafe40a6a1080cd89a3187628e:
Jerome Glisse (1):
(pre-stable) drm/radeon/kms: initialize set_surface_reg reg for rs600 asic

are available in the git repository at:

git://kernel.ubuntu.com/lag/ubuntu-lucid.git lp570500

Lee Jones (1):
UBUNTU: Enable perf to be more helpful when perf_<version> does not exist.

debian/tools/perf | 19 ++++++++++++++-----
1 files changed, 14 insertions(+), 5 deletions(-)



diff --git a/debian/tools/perf b/debian/tools/perf
index 79253d2..ab35fab 100644 (file)
--- a/debian/tools/perf
+++ b/debian/tools/perf
@@ -1,7 +1,16 @@
#!/bin/bash
-version=`uname -r`
-flavour=${version#*-}
-flavour=${flavour#*-}
-version=${version%-$flavour}
+full_version=`uname -r`

-exec "perf_$version" "$@"
+# Removing flavour from version i.e. generic or server.
+flavour_abi=${full_version#*-}
+flavour=${flavour_abi#*-}
+version=${full_version%-$flavour}
+perf="perf_$version"
+
+if ! which "$perf" > /dev/null; then
+ echo "$perf not found" >&2
+ echo "You may need to install linux-tools-$version" >&2
+ exit 2
+fi
+
+exec "$perf" "$@"

Kind regards,
Lee

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-08-2010, 01:35 PM
Lee Jones
 
Default UBUNTU: Enable perf to be more helpful when perf_ does not exist.

Hi all,

This patch as already been excepted in Maverick.

I would also like it to go into Lucid.

The following changes since commit f8b7e92f771b23dafe40a6a1080cd89a3187628e:
Jerome Glisse (1):
(pre-stable) drm/radeon/kms: initialize set_surface_reg reg for rs600 asic

are available in the git repository at:

git://kernel.ubuntu.com/lag/ubuntu-lucid.git lp570500

Lee Jones (1):
UBUNTU: Enable perf to be more helpful when perf_<version> does not exist.

debian/tools/perf | 19 ++++++++++++++-----
1 files changed, 14 insertions(+), 5 deletions(-)



diff --git a/debian/tools/perf b/debian/tools/perf
index 79253d2..ab35fab 100644 (file)
--- a/debian/tools/perf
+++ b/debian/tools/perf
@@ -1,7 +1,16 @@
#!/bin/bash
-version=`uname -r`
-flavour=${version#*-}
-flavour=${flavour#*-}
-version=${version%-$flavour}
+full_version=`uname -r`

-exec "perf_$version" "$@"
+# Removing flavour from version i.e. generic or server.
+flavour_abi=${full_version#*-}
+flavour=${flavour_abi#*-}
+version=${full_version%-$flavour}
+perf="perf_$version"
+
+if ! which "$perf" > /dev/null; then
+ echo "$perf not found" >&2
+ echo "You may need to install linux-tools-$version" >&2
+ exit 2
+fi
+
+exec "$perf" "$@"

Kind regards,
Lee

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 04:44 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org