FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 05-06-2010, 09:08 AM
Andy Whitcroft
 
Default UBUNTU: abi-check -- be more forgiving of the ABI element type

BugLink: http://bugs.launchpad.net/bugs/576274

With some configurations we may find entries in the ABI which are not
EXPORT_*. For example with CONFIG_UNUSED_SYMBOLS=n entries marked as
UNUSED are listed as below:

(unknown) vmlinux 0xc48a85c4 simple_prepare_write

This leads to an undiagnosable error from abi-check:

Missing module name in is_ignored() at debian/scripts/abi-check line 77.

There is no obvious reason to limit ourselves to EXPORT_* in the abi files.
Separatly we should ensure that CONFIG_UNUSED_SYMBOLS is set.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
debian/scripts/abi-check | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/scripts/abi-check b/debian/scripts/abi-check
index b7df0d8..c7a02c5 100755
--- a/debian/scripts/abi-check
+++ b/debian/scripts/abi-check
@@ -90,7 +90,7 @@ open(NEW, "< $abidir/$flavour") or
die "Could not open $abidir/$flavour";
while (<NEW>) {
chomp;
- m/^(EXPORT_.+)s(.+)s(0x[0-9a-f]+)s(.+)$/;
+ m/^(S+)s(.+)s(0x[0-9a-f]+)s(.+)$/;
$symbols{$4}{'type'} = $1;
$symbols{$4}{'loc'} = $2;
$symbols{$4}{'hash'} = $3;
@@ -107,7 +107,7 @@ open(OLD, "< $prev_abidir/$flavour") or
die "Could not open $prev_abidir/$flavour";
while (<OLD>) {
chomp;
- m/^(EXPORT_.+)s(.+)s(0x[0-9a-f]+)s(.+)$/;
+ m/^(S+)s(.+)s(0x[0-9a-f]+)s(.+)$/;
$symbols{$4}{'old_type'} = $1;
$symbols{$4}{'old_loc'} = $2;
$symbols{$4}{'old_hash'} = $3;
--
1.7.0.4


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 02:45 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org