FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 05-05-2010, 10:19 AM
Bryan Wu
 
Default UBUNTU: (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.

From: Mattias Walstrom <mattias@vmlinux.org>

BugLink: http://bugs.launchpad.net/bugs/575558

Fix memory corruption that sometimes result in kernel panic.

Signed-off-by: Mattias Walström <mattias@vmlinux.org>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
drivers/net/fec.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 2280373..d63d18c 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1049,7 +1049,7 @@ fec_set_mac_address(struct net_device *dev, void *p)
(dev->dev_addr[1] << 16) | (dev->dev_addr[0] << 24),
fep->hwp + FEC_ADDR_LOW);
writel((dev->dev_addr[5] << 16) | (dev->dev_addr[4] << 24),
- fep + FEC_ADDR_HIGH);
+ fep->hwp + FEC_ADDR_HIGH);
return 0;
}

--
1.7.0.4


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 05-05-2010, 12:21 PM
Andy Whitcroft
 
Default UBUNTU: (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.

On Wed, May 05, 2010 at 06:19:37PM +0800, Bryan Wu wrote:
> From: Mattias Walstrom <mattias@vmlinux.org>
>
> BugLink: http://bugs.launchpad.net/bugs/575558
>
> Fix memory corruption that sometimes result in kernel panic.
>
> Signed-off-by: Mattias Walström <mattias@vmlinux.org>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
> drivers/net/fec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 2280373..d63d18c 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -1049,7 +1049,7 @@ fec_set_mac_address(struct net_device *dev, void *p)
> (dev->dev_addr[1] << 16) | (dev->dev_addr[0] << 24),
> fep->hwp + FEC_ADDR_LOW);
> writel((dev->dev_addr[5] << 16) | (dev->dev_addr[4] << 24),
> - fep + FEC_ADDR_HIGH);
> + fep->hwp + FEC_ADDR_HIGH);
> return 0;
> }

Seems obviously correct.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 05-05-2010, 12:46 PM
Colin Ian King
 
Default UBUNTU: (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.

On Wed, 2010-05-05 at 18:19 +0800, Bryan Wu wrote:
> From: Mattias Walstrom <mattias@vmlinux.org>
>
> BugLink: http://bugs.launchpad.net/bugs/575558
>
> Fix memory corruption that sometimes result in kernel panic.
>
> Signed-off-by: Mattias Walström <mattias@vmlinux.org>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
> drivers/net/fec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 2280373..d63d18c 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -1049,7 +1049,7 @@ fec_set_mac_address(struct net_device *dev, void *p)
> (dev->dev_addr[1] << 16) | (dev->dev_addr[0] << 24),
> fep->hwp + FEC_ADDR_LOW);
> writel((dev->dev_addr[5] << 16) | (dev->dev_addr[4] << 24),
> - fep + FEC_ADDR_HIGH);
> + fep->hwp + FEC_ADDR_HIGH);
> return 0;
> }
>
Yep, looks good to me.

Acked-by: Colin King <colin.king@canonical.com>



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 05-05-2010, 05:07 PM
Leann Ogasawara
 
Default UBUNTU: (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.

Applied to Maverick.

Thanks,
Leann


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 05-07-2010, 03:23 PM
Stefan Bader
 
Default UBUNTU: (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.

Applied to Lucid fsl-imx51

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 01:32 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org