FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 04-28-2010, 04:17 PM
Colin Ian King
 
Default UBUNTU: SAUCE: IMX51: fix stgl5000 regulator_get failing error

On Fri, 2010-04-23 at 10:29 +0800, Bryan Wu wrote:
> BugLink: http://bugs.launchpad.net/bugs/567157
>
> In Freescale BSP, commit 2d75a8fa9d7c7272b3b81268c2fb33a57be9a072 removes
> regulator_consumer_supply VDDD which will be used by stgl5000 driver. So it
> will give us an error message during booting:
>
> 'regulator: Unable to get requested regulator: VDDD'
>
> This patch added it back and fix this error.
>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
> arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c b/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
> index 72d8baf..e8a03cf 100644
> --- a/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
> +++ b/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
> @@ -99,6 +99,11 @@ static struct regulator_consumer_supply vdig_consumers[] = {
> .supply = "VDDA",
> .dev_name = "1-000a",
> }
> + {
> + /* sgtl5000 */
> + .supply = "VDDD",
> + .dev_name = "1-000a",
> + },
> };
>
> static struct regulator_consumer_supply vvideo_consumers[] = {
> --
> 1.7.0.1
>
>
Urm, I'm confused about this patch - isn't the VDDD already enabled in
the current lucid fsl-imx51 branch?




--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 04-29-2010, 01:29 AM
Bryan Wu
 
Default UBUNTU: SAUCE: IMX51: fix stgl5000 regulator_get failing error

On 04/29/2010 12:17 AM, Colin Ian King wrote:
> On Fri, 2010-04-23 at 10:29 +0800, Bryan Wu wrote:
>> BugLink: http://bugs.launchpad.net/bugs/567157
>>
>> In Freescale BSP, commit 2d75a8fa9d7c7272b3b81268c2fb33a57be9a072 removes
>> regulator_consumer_supply VDDD which will be used by stgl5000 driver. So it
>> will give us an error message during booting:
>>
>> 'regulator: Unable to get requested regulator: VDDD'
>>
>> This patch added it back and fix this error.
>>
>> Signed-off-by: Bryan Wu<bryan.wu@canonical.com>
>> ---
>> arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c b/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
>> index 72d8baf..e8a03cf 100644
>> --- a/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
>> +++ b/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
>> @@ -99,6 +99,11 @@ static struct regulator_consumer_supply vdig_consumers[] = {
>> .supply = "VDDA",
>> .dev_name = "1-000a",
>> }
>> + {
>> + /* sgtl5000 */
>> + .supply = "VDDD",
>> + .dev_name = "1-000a",
>> + },
>> };
>>
>> static struct regulator_consumer_supply vvideo_consumers[] = {
>> --
>> 1.7.0.1
>>
>>
> Urm, I'm confused about this patch - isn't the VDDD already enabled in
> the current lucid fsl-imx51 branch?
>
>

VDDD's already been enabled in our Lucid fsl-imx51 branch. But it was removed in
Freescale's patch which is "[PATCH 3/5] ENGR00121069: MX51: Complete the
constraints for the various regulators.". I don't wanna to change their patch,
so I fixed here. I will post my fix to Freescale later.

IMHO, this is an obvious mistake in their BSP.

Thanks,
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.138-1617-6545 Mobile
Ubuntu Kernel Team | Hardware Enablement Team
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 03:01 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org