FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 03-18-2010, 04:46 AM
Andy Whitcroft
 
Default softlockup: stop softlockup messages due to touch_ts math overflow

On Tue, Mar 09, 2010 at 04:37:19PM +0000, Colin Ian King wrote:
> Hi,
>
> This patch will fix a math overflow error that causes spurious soft
> lockup error messages. It catches a corner case, for example, just when
> the TSC heads towards a 64 bit wrap-around when the upper 32 bits are
> set to 0xffffffff. While this normally does not happen (since it
> requires an uptime of possibly thousands of years, it may happen if the
> TSC warps during S3).

Can't you rewrite this:

if ((unsigned long long)now <=
((unsigned long long)touch_ts + softlockup_thresh))
return;

as below and avoid the cast?

if ((now - touch_ts) <= softlockup_threash)

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 12:42 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org