FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 03-15-2010, 10:38 AM
Hans de Goede
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

This gets triggered now that we run it on partitions and lv's too to
detect disk label formats on non disks.

This patch is intended for both master and f13-branch.
---
storage/formats/disklabel.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/storage/formats/disklabel.py b/storage/formats/disklabel.py
index 1a9d066..62fde7e 100644
--- a/storage/formats/disklabel.py
+++ b/storage/formats/disklabel.py
@@ -130,7 +130,7 @@ class DiskLabel(DeviceFormat):
if self.exists:
try:
self._partedDisk = parted.Disk(device=self.partedDevice)
- except _ped.DiskLabelException as e:
+ except (_ped.DiskLabelException, IOException) as e:
raise InvalidDiskLabelError()

if self._partedDisk.type == "loop":
--
1.7.0

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-15-2010, 11:08 AM
Ales Kozumplik
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

try:
self._partedDisk = parted.Disk(device=self.partedDevice)
- except _ped.DiskLabelException as e:
+ except (_ped.DiskLabelException, IOException) as e:
raise InvalidDiskLabelError()


ack

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-15-2010, 01:33 PM
Chris Lumens
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

> This patch is intended for both master and f13-branch.

573539 is not marked as an F13Blocker.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-15-2010, 01:50 PM
Hans de Goede
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

Hi,

On 03/15/2010 03:33 PM, Chris Lumens wrote:

This patch is intended for both master and f13-branch.


573539 is not marked as an F13Blocker.



<sigh>, AFAIK were not in Beta Freeze yet, so common sense rules
apply and applying this fix clearly is common sense as:

1) We are likely to see this on other systems too
2) It is a pretty safe patch

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-15-2010, 01:57 PM
Chris Lumens
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

> <sigh>, AFAIK were not in Beta Freeze yet, so common sense rules
> apply and applying this fix clearly is common sense as:
>
> 1) We are likely to see this on other systems too

You should at least verify with dlehman that it's appropriate for
f13-branch, since he's in charge of that show.

> 2) It is a pretty safe patch

I've heard that one before.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-15-2010, 05:08 PM
David Lehman
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

On Mon, 2010-03-15 at 15:50 +0100, Hans de Goede wrote:
> Hi,
>
> On 03/15/2010 03:33 PM, Chris Lumens wrote:
> >> This patch is intended for both master and f13-branch.
> >
> > 573539 is not marked as an F13Blocker.
> >
>
> <sigh>, AFAIK were not in Beta Freeze yet, so common sense rules
> apply and applying this fix clearly is common sense as:
>
> 1) We are likely to see this on other systems too
> 2) It is a pretty safe patch

No, it isn't a safe patch -- it causes a traceback. Do I need to say
that this is why phrases like "common sense" and "safe" quickly become
meaningless in this context?

Dave

>
> Regards,
>
> Hans
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-15-2010, 05:54 PM
Hans de Goede
 
Default parted.PartedDisk can throw IOExceptions too (#573539)

Hi,

On 03/15/2010 07:08 PM, David Lehman wrote:

On Mon, 2010-03-15 at 15:50 +0100, Hans de Goede wrote:

Hi,

On 03/15/2010 03:33 PM, Chris Lumens wrote:

This patch is intended for both master and f13-branch.


573539 is not marked as an F13Blocker.



<sigh>, AFAIK were not in Beta Freeze yet, so common sense rules
apply and applying this fix clearly is common sense as:

1) We are likely to see this on other systems too
2) It is a pretty safe patch


No, it isn't a safe patch -- it causes a traceback. Do I need to say
that this is why phrases like "common sense" and "safe" quickly become
meaningless in this context?



Gah, sorry about that, I had parted's IOException mixed up with pythons
IOError and thus assumed that it was part of the global namespace.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:39 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org