FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 03-02-2010, 05:46 PM
David Partington
 
Default ihwmon: (it87) Fix VID register access for it8718 and it8720

The comments on the register definitions for the VID register indicates
that IT8718 and IT8720 use a different register (IT87_REG_VID) while the
other sensors use IT87_SIO_VID_REG.
But the code that accesses the register uses the names swaped around. So
the VID value of a it8716 device has been found incorrect.

Signed-off-by: David Partington <david@partington.com>
CC: stable@kernel.org
---
drivers/hwmon/it87.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 0ffe84d..aaf3e2c 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -1061,7 +1061,7 @@ static int __init it87_find(unsigned short *address,

if ((sio_data->type == it8718 || sio_data->type == it8720)
&& !(sio_data->skip_vid))
- sio_data->vid_value = superio_inb(IT87_SIO_VID_REG);
+ sio_data->vid_value = superio_inb(IT87_REG_VID);

reg = superio_inb(IT87_SIO_PINX2_REG);
if (reg & (1 << 0))
@@ -1557,10 +1557,10 @@ static struct it87_data *it87_update_device(struct device *dev)

data->sensor = it87_read_value(data, IT87_REG_TEMP_ENABLE);
/* The 8705 does not have VID capability.
- The 8718 and the 8720 don't use IT87_REG_VID for the
+ The 8718 and the 8720 don't use IT87_SIO_VID_REG for the
same purpose. */
if (data->type == it8712 || data->type == it8716) {
- data->vid = it87_read_value(data, IT87_REG_VID);
+ data->vid = it87_read_value(data, IT87_SIO_VID_REG);
/* The older IT8712F revisions had only 5 VID pins,
but we assume it is always safe to read 6 bits. */
data->vid &= 0x3f;
--
1.6.3.3


--------------060103010409090309000905
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

--------------060103010409090309000905--
 

Thread Tools




All times are GMT. The time now is 08:57 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org