Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Ubuntu Kernel Team (http://www.linux-archive.org/ubuntu-kernel-team/)
-   -   UBUNTU: SAUCE: Make CONFIG_{OMNIBOOK, AVERATEC_5100P, PACKARDBELL_E5} depend on X86 (http://www.linux-archive.org/ubuntu-kernel-team/315845-ubuntu-sauce-make-config_-omnibook-averatec_5100p-packardbell_e5-depend-x86.html)

Andy Whitcroft 01-27-2010 02:10 PM

UBUNTU: SAUCE: Make CONFIG_{OMNIBOOK, AVERATEC_5100P, PACKARDBELL_E5} depend on X86
 
On Wed, Jan 27, 2010 at 10:02:24PM +0800, Eric Miao wrote:
> commit a9244d2e2bb71094fe64b0063ba35963bfc6d656
> Author: Eric Miao <eric.y.miao@gmail.com>
> Date: Wed Jan 27 21:50:51 2010 +0800
>
> UBUNTU: SAUCE: Make
> CONFIG_{OMNIBOOK,AVERATEC_5100P,PACKARDBELL_E5} depend on X86
>
> There options are really X86 specific, and the source won't compile on
> ARM platforms. Make them depend on X86 and less confusing when syncing
> config options to ARM.
>
> Signed-off-by: Eric Miao <eric.miao@canonical.com>
>
> diff --git a/ubuntu/omnibook/Kconfig b/ubuntu/omnibook/Kconfig
> index 370b379..acad37a 100644
> --- a/ubuntu/omnibook/Kconfig
> +++ b/ubuntu/omnibook/Kconfig
> @@ -1,4 +1,5 @@
> config OMNIBOOK
> tristate "Kernel module for HP and Toshiba laptops"
> + depends on X86
> default m
> ---help---
> diff --git a/ubuntu/rfkill/Kconfig b/ubuntu/rfkill/Kconfig
> index ff6d8a1..efb62c2 100644
> --- a/ubuntu/rfkill/Kconfig
> +++ b/ubuntu/rfkill/Kconfig
> @@ -1,7 +1,9 @@
> config AVERATEC_5100P
> tristate "Software kill switch for Averatec 5100P"
> + depends on X86
> default m
>
> config PACKARDBELL_E5
> tristate "Software kill switch for Packard Bell EasyNote E5"
> + depends on X86
> default m

This looks reasonable to me assuming they are really only available on
X86. Manjo the omnibook one was yours, I believe its X86 only can you
confirm? The other two also sound so. Based on that I think its a
reasonable patch.

Manjo?

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

01-27-2010 03:49 PM

UBUNTU: SAUCE: Make CONFIG_{OMNIBOOK, AVERATEC_5100P, PACKARDBELL_E5} depend on X86
 
That is correct, the onmibook module is x86 only, and not needed on ARM
platforms. Erics patch looks good.

Thanks Eric.

Cheers
--- manjo

On Wed, 27 Jan 2010, Andy Whitcroft wrote:

> On Wed, Jan 27, 2010 at 10:02:24PM +0800, Eric Miao wrote:
>> commit a9244d2e2bb71094fe64b0063ba35963bfc6d656
>> Author: Eric Miao <eric.y.miao@gmail.com>
>> Date: Wed Jan 27 21:50:51 2010 +0800
>>
>> UBUNTU: SAUCE: Make
>> CONFIG_{OMNIBOOK,AVERATEC_5100P,PACKARDBELL_E5} depend on X86
>>
>> There options are really X86 specific, and the source won't compile on
>> ARM platforms. Make them depend on X86 and less confusing when syncing
>> config options to ARM.
>>
>> Signed-off-by: Eric Miao <eric.miao@canonical.com>
>>
>> diff --git a/ubuntu/omnibook/Kconfig b/ubuntu/omnibook/Kconfig
>> index 370b379..acad37a 100644
>> --- a/ubuntu/omnibook/Kconfig
>> +++ b/ubuntu/omnibook/Kconfig
>> @@ -1,4 +1,5 @@
>> config OMNIBOOK
>> tristate "Kernel module for HP and Toshiba laptops"
>> + depends on X86
>> default m
>> ---help---
>> diff --git a/ubuntu/rfkill/Kconfig b/ubuntu/rfkill/Kconfig
>> index ff6d8a1..efb62c2 100644
>> --- a/ubuntu/rfkill/Kconfig
>> +++ b/ubuntu/rfkill/Kconfig
>> @@ -1,7 +1,9 @@
>> config AVERATEC_5100P
>> tristate "Software kill switch for Averatec 5100P"
>> + depends on X86
>> default m
>>
>> config PACKARDBELL_E5
>> tristate "Software kill switch for Packard Bell EasyNote E5"
>> + depends on X86
>> default m
>
> This looks reasonable to me assuming they are really only available on
> X86. Manjo the omnibook one was yours, I believe its X86 only can you
> confirm? The other two also sound so. Based on that I think its a
> reasonable patch.
>
> Manjo?
>
> -apw
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Andy Whitcroft 01-31-2010 08:51 PM

UBUNTU: SAUCE: Make CONFIG_{OMNIBOOK, AVERATEC_5100P, PACKARDBELL_E5} depend on X86
 
Applied to Lucid.

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team


All times are GMT. The time now is 02:35 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.