FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 01-20-2010, 08:16 AM
Keng-Yu Lin
 
Default UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung Q210/P210 laptops

SRU Justification:

Impact:
Some hotkeys do not produce key release events so not function well.

Fix:
Add quirks in atkbd.c to force a key release.
(in 2.6.32, this can be done via /sys from userspace)

Testcase:
A user reported this patch works well.

-
From 10cc63dff1ccb95432ddded56786f4ad5dbbde87 Mon Sep 17 00:00:00 2001
From: Keng-Yu Lin <keng-yu.lin@canonical.com>
Date: Fri, 11 Dec 2009 11:24:39 +0800
Subject: [PATCH] UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung Q210/P210 laptops

Hotkeys do not produce release events. Add the quirk to force a key release.

In 2.6.32, a /sys interface is provided to handle setting from userspace.
It is not necessary to apply this patch to newer version than 2.6.31.

OriginalAuthor: Alexander Huhlaev <sancheolz@gmail.com>
BugLink: http://bugs.launchpad.net/bugs/385683

Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
---
drivers/input/keyboard/atkbd.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 6529fe9..5f32d73 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1625,6 +1625,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
.driver_data = atkbd_samsung_forced_release_keys,
},
{
+ .ident = "Samsung Q210/P210",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Q210/P210"),
+ },
+ .callback = atkbd_setup_forced_release,
+ .driver_data = atkbd_samsung_forced_release_keys,
+ },
+ {
.ident = "Fujitsu Amilo PA 1510",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
--
1.6.3.3


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 01-20-2010, 01:05 PM
Tim Gardner
 
Default UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung Q210/P210 laptops

Keng-Yu Lin wrote:
> SRU Justification:
>
> Impact:
> Some hotkeys do not produce key release events so not function well.
>
> Fix:
> Add quirks in atkbd.c to force a key release.
> (in 2.6.32, this can be done via /sys from userspace)
>
> Testcase:
> A user reported this patch works well.
>
> -
> From 10cc63dff1ccb95432ddded56786f4ad5dbbde87 Mon Sep 17 00:00:00 2001
> From: Keng-Yu Lin <keng-yu.lin@canonical.com>
> Date: Fri, 11 Dec 2009 11:24:39 +0800
> Subject: [PATCH] UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung Q210/P210 laptops
>
> Hotkeys do not produce release events. Add the quirk to force a key release.
>
> In 2.6.32, a /sys interface is provided to handle setting from userspace.
> It is not necessary to apply this patch to newer version than 2.6.31.
>
> OriginalAuthor: Alexander Huhlaev <sancheolz@gmail.com>
> BugLink: http://bugs.launchpad.net/bugs/385683
>
> Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
> ---
> drivers/input/keyboard/atkbd.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 6529fe9..5f32d73 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1625,6 +1625,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
> .driver_data = atkbd_samsung_forced_release_keys,
> },
> {
> + .ident = "Samsung Q210/P210",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Q210/P210"),
> + },
> + .callback = atkbd_setup_forced_release,
> + .driver_data = atkbd_samsung_forced_release_keys,
> + },
> + {
> .ident = "Fujitsu Amilo PA 1510",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),

Looks right to me.

Acked-by: Tim Gardner <tim.gardner@canonical.com>

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 01-22-2010, 01:28 PM
Stefan Bader
 
Default UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung Q210/P210 laptops

Keng-Yu Lin wrote:
> SRU Justification:
>
> Impact:
> Some hotkeys do not produce key release events so not function well.
>
> Fix:
> Add quirks in atkbd.c to force a key release.
> (in 2.6.32, this can be done via /sys from userspace)
>
> Testcase:
> A user reported this patch works well.
>
> -
> From 10cc63dff1ccb95432ddded56786f4ad5dbbde87 Mon Sep 17 00:00:00 2001
> From: Keng-Yu Lin <keng-yu.lin@canonical.com>
> Date: Fri, 11 Dec 2009 11:24:39 +0800
> Subject: [PATCH] UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung Q210/P210 laptops
>
> Hotkeys do not produce release events. Add the quirk to force a key release.
>
> In 2.6.32, a /sys interface is provided to handle setting from userspace.
> It is not necessary to apply this patch to newer version than 2.6.31.
>
> OriginalAuthor: Alexander Huhlaev <sancheolz@gmail.com>
> BugLink: http://bugs.launchpad.net/bugs/385683
>
> Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
> drivers/input/keyboard/atkbd.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 6529fe9..5f32d73 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1625,6 +1625,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
> .driver_data = atkbd_samsung_forced_release_keys,
> },
> {
> + .ident = "Samsung Q210/P210",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Q210/P210"),
> + },
> + .callback = atkbd_setup_forced_release,
> + .driver_data = atkbd_samsung_forced_release_keys,
> + },
> + {
> .ident = "Fujitsu Amilo PA 1510",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 09:27 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org