FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 01-15-2010, 08:23 PM
Peter Jones
 
Default Use StorageError insead of enumerating all the different storage errors.

devicetree.teardownAll() often causes storage errors which all get
ignored, but we've been enumerating them individually. use their
superclass instead.
---
storage/devicetree.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/storage/devicetree.py b/storage/devicetree.py
index 17700f6..99af7c6 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -1949,7 +1949,7 @@ class DeviceTree(object):
for device in self.leaves:
try:
device.teardown(recursive=True)
- except (DeviceError, DeviceFormatError, LVMError, MDRaidError) as e:
+ except StorageError as e:
log.info("teardown of %s failed: %s" % (device.name, e))

def setupAll(self):
--
1.6.5.2

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-15-2010, 09:43 PM
David Lehman
 
Default Use StorageError insead of enumerating all the different storage errors.

On Fri, 2010-01-15 at 16:23 -0500, Peter Jones wrote:
> devicetree.teardownAll() often causes storage errors which all get
> ignored, but we've been enumerating them individually. use their
> superclass instead.

This one's well overdue. Ack.

> ---
> storage/devicetree.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/storage/devicetree.py b/storage/devicetree.py
> index 17700f6..99af7c6 100644
> --- a/storage/devicetree.py
> +++ b/storage/devicetree.py
> @@ -1949,7 +1949,7 @@ class DeviceTree(object):
> for device in self.leaves:
> try:
> device.teardown(recursive=True)
> - except (DeviceError, DeviceFormatError, LVMError, MDRaidError) as e:
> + except StorageError as e:
> log.info("teardown of %s failed: %s" % (device.name, e))
>
> def setupAll(self):


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-19-2010, 01:48 AM
David Cantrell
 
Default Use StorageError insead of enumerating all the different storage errors.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 15 Jan 2010, Peter Jones wrote:


devicetree.teardownAll() often causes storage errors which all get
ignored, but we've been enumerating them individually. use their
superclass instead.
---
storage/devicetree.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/storage/devicetree.py b/storage/devicetree.py
index 17700f6..99af7c6 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -1949,7 +1949,7 @@ class DeviceTree(object):
for device in self.leaves:
try:
device.teardown(recursive=True)
- except (DeviceError, DeviceFormatError, LVMError, MDRaidError) as e:
+ except StorageError as e:
log.info("teardown of %s failed: %s" % (device.name, e))

def setupAll(self):



Ack.

- --
David Cantrell <dcantrell@redhat.com>

Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAktVHZAACgkQ5hsjjIy1VklRnQCg5b69I3NBL2 jbuSwmSETYK+mw
id8AoPYXm7g9nlyxc7Vf2DYa5M71bMpv
=yGIH
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:38 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org