UBUNTU: SAUCE: AppArmor: Fix oops there is no tracer and doing unsafe transition.
Andy Whitcroft wrote:
> On Thu, Nov 12, 2009 at 11:28:10AM +0000, Andy Whitcroft wrote:
>> Hrm, now perhaps this is fixing the concern I raised in the previous
>> patch. Perhaps it would be safer to simply make the put_cred()
>> incantation instead?
>> if (cred)
> I guess I _am_ happy that the current form would address the concern and
> so in that sense:
> Acked-by: Andy Whitcroft <firstname.lastname@example.org>
> I would suggest considering a more bullet proof approach as above for
> your mainline efforts as its clearer that cred can only be released if
> non-null, and its safer against further change in the function.
Yep, what you suggest would be better.
kernel-team mailing list