FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 11-12-2009, 03:27 PM
John Johansen
 
Default UBUNTU: SAUCE: AppArmor: Fix oops there is no tracer and doing unsafe transition.

Andy Whitcroft wrote:
> On Thu, Nov 12, 2009 at 11:28:10AM +0000, Andy Whitcroft wrote:
>
>> Hrm, now perhaps this is fixing the concern I raised in the previous
>> patch. Perhaps it would be safer to simply make the put_cred()
>> incantation instead?
>>
>> if (cred)
>> put_cred(cred);
>
> I guess I _am_ happy that the current form would address the concern and
> so in that sense:
>
> Acked-by: Andy Whitcroft <apw@canonical.com>
>
> I would suggest considering a more bullet proof approach as above for
> your mainline efforts as its clearer that cred can only be released if
> non-null, and its safer against further change in the function.
>
Yep, what you suggest would be better.

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 03:02 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org