SRU: Enable speakers and mic for Toshiba NB200 (Realtek ALC272)
 

On 11/03/2009 09:46 AM, Leann Ogasawara wrote:
> Hi All,
>
> The following set of patches fixes a regression from Hardy to Jaunty on
> a a Toshiba NB200 (Realtek ALC272). The set of patches enable sound
> from the speakers, mute the speakers when headphones are plugged in, and
> also enable the internal mic. The patches were forward ported from
> Hardy LUM (netbook-lpia branch). There is a low risk of regression as
> we are just adding a new verb table specific to this soundcard/codec.
> There are currently 185,000 systems this is known to affect. Please
> consider carrying.

Is that really 185,000? Seems a bit high.

~pete
>
> Thanks,
> Leann
>
> The following changes since commit f706cfd92861c7c51f45d722d1398d67bb9d6255:
> Stefan Bader (1):
> UBUNTU: Ubuntu-2.6.28-16.56
>
> are available in the git repository at:
>
> git://kernel.ubuntu.com/ogasawara/ubuntu-jaunty lp438318
>
> Leann Ogasawara (3):
> UBUNTU: SAUCE: Enable speakers for Toshiba NB200 (Realtek ALC272)
> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) mute speakers when headphones are plugged in
> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) enable microphone
>
> sound/pci/hda/patch_realtek.c | 79 +++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 79 insertions(+), 0 deletions(-)
>
>
>
>


--
Pete Graner <pgraner@canonical.com>
Manager +1.828.358.0068 Office
Ubuntu Kernel Team +1.828.582.9466 Mobile
Canonical Ltd. http://www.canonical.com/

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

SRU: Enable speakers and mic for Toshiba NB200 (Realtek ALC272)
 

Leann Ogasawara wrote:
> Hi All,
>
> The following set of patches fixes a regression from Hardy to Jaunty on
> a a Toshiba NB200 (Realtek ALC272). The set of patches enable sound
> from the speakers, mute the speakers when headphones are plugged in, and
> also enable the internal mic. The patches were forward ported from
> Hardy LUM (netbook-lpia branch). There is a low risk of regression as
> we are just adding a new verb table specific to this soundcard/codec.
> There are currently 185,000 systems this is known to affect. Please
> consider carrying.
>
> Thanks,
> Leann
>
> The following changes since commit f706cfd92861c7c51f45d722d1398d67bb9d6255:
> Stefan Bader (1):
> UBUNTU: Ubuntu-2.6.28-16.56
>
> are available in the git repository at:
>
> git://kernel.ubuntu.com/ogasawara/ubuntu-jaunty lp438318
>
> Leann Ogasawara (3):
> UBUNTU: SAUCE: Enable speakers for Toshiba NB200 (Realtek ALC272)
> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) mute speakers when headphones are plugged in
> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) enable microphone
>
> sound/pci/hda/patch_realtek.c | 79 +++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 79 insertions(+), 0 deletions(-)
>
>
>
>

In alc663_mode1_unsol_event() you are changing entry points for an
existing model. Are you _sure_ that won't cause a regression?

- .unsol_event = alc663_m51va_unsol_event,
- .init_hook = alc663_m51va_inithook,
+ .unsol_event = alc272_toshiba_unsol_event,
+ .init_hook = alc272_toshiba_inithook,

rtg
--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

SRU: Enable speakers and mic for Toshiba NB200 (Realtek ALC272)
 

Tim Gardner wrote:
> Leann Ogasawara wrote:
>> Hi All,
>>
>> The following set of patches fixes a regression from Hardy to Jaunty on
>> a a Toshiba NB200 (Realtek ALC272). The set of patches enable sound
>> from the speakers, mute the speakers when headphones are plugged in, and
>> also enable the internal mic. The patches were forward ported from
>> Hardy LUM (netbook-lpia branch). There is a low risk of regression as
>> we are just adding a new verb table specific to this soundcard/codec.
>> There are currently 185,000 systems this is known to affect. Please
>> consider carrying.
>>
>> Thanks,
>> Leann
>>
>> The following changes since commit f706cfd92861c7c51f45d722d1398d67bb9d6255:
>> Stefan Bader (1):
>> UBUNTU: Ubuntu-2.6.28-16.56
>>
>> are available in the git repository at:
>>
>> git://kernel.ubuntu.com/ogasawara/ubuntu-jaunty lp438318
>>
>> Leann Ogasawara (3):
>> UBUNTU: SAUCE: Enable speakers for Toshiba NB200 (Realtek ALC272)
>> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) mute speakers when headphones are plugged in
>> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) enable microphone
>>
>> sound/pci/hda/patch_realtek.c | 79 +++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 79 insertions(+), 0 deletions(-)
>>
>>
>>
>>
>
> In alc663_mode1_unsol_event() you are changing entry points for an
> existing model. Are you _sure_ that won't cause a regression?
>
> - .unsol_event = alc663_m51va_unsol_event,
> - .init_hook = alc663_m51va_inithook,
> + .unsol_event = alc272_toshiba_unsol_event,
> + .init_hook = alc272_toshiba_inithook,
>
> rtg

That is not in alc663_mode1_unsol_event but in alc662_presets[]
(see below). The patch lines surrounding it are a bit misleading. :)

-Stefan

static void alc663_mode1_unsol_event(struct hda_codec *codec,
unsigned int res)
@@ -16086,8 +16120,8 @@ static struct alc_config_preset alc662_presets[] = {
.capsrc_nids = alc662_capsrc_nids,
.channel_mode = alc662_3ST_2ch_modes,
.input_mux = &alc663_m51va_capture_source,
- .unsol_event = alc663_m51va_unsol_event,
- .init_hook = alc663_m51va_inithook,
+ .unsol_event = alc272_toshiba_unsol_event,
+ .init_hook = alc272_toshiba_inithook,

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

SRU: Enable speakers and mic for Toshiba NB200 (Realtek ALC272)
 

On Wed, 2009-11-04 at 07:09 -0800, Tim Gardner wrote:
> Leann Ogasawara wrote:
> > Hi All,
> >
> > The following set of patches fixes a regression from Hardy to Jaunty on
> > a a Toshiba NB200 (Realtek ALC272). The set of patches enable sound
> > from the speakers, mute the speakers when headphones are plugged in, and
> > also enable the internal mic. The patches were forward ported from
> > Hardy LUM (netbook-lpia branch). There is a low risk of regression as
> > we are just adding a new verb table specific to this soundcard/codec.
> > There are currently 185,000 systems this is known to affect. Please
> > consider carrying.
> >
> > Thanks,
> > Leann
> >
> > The following changes since commit f706cfd92861c7c51f45d722d1398d67bb9d6255:
> > Stefan Bader (1):
> > UBUNTU: Ubuntu-2.6.28-16.56
> >
> > are available in the git repository at:
> >
> > git://kernel.ubuntu.com/ogasawara/ubuntu-jaunty lp438318
> >
> > Leann Ogasawara (3):
> > UBUNTU: SAUCE: Enable speakers for Toshiba NB200 (Realtek ALC272)
> > UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) mute speakers when headphones are plugged in
> > UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) enable microphone
> >
> > sound/pci/hda/patch_realtek.c | 79 +++++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 79 insertions(+), 0 deletions(-)
> >
> >
> >
> >
>
> In alc663_mode1_unsol_event() you are changing entry points for an
> existing model. Are you _sure_ that won't cause a regression?
>
> - .unsol_event = alc663_m51va_unsol_event,
> - .init_hook = alc663_m51va_inithook,
> + .unsol_event = alc272_toshiba_unsol_event,
> + .init_hook = alc272_toshiba_inithook,
>

I believe the way the patch was formatted makes it look a bit
misleading. When examining the actual code, you'll see we're actually
only changing the entry points specific to ALC272_TOSHIBA_NB200 element
in alc662_presets[]. So yes, I believe this will not cause a
regression.

static struct alc_config_preset alc662_presets[] = {
...
[ALC272_TOSHIBA_NB200] = {
.mixers = { alc663_m51va_mixer, alc272_toshiba_mixer, alc662_capture_mixer },
.init_verbs = { alc662_init_verbs, alc272_toshiba_init_verbs },
.num_dacs = ARRAY_SIZE(alc662_dac_nids),
.dac_nids = alc662_dac_nids,
.num_channel_mode = ARRAY_SIZE(alc662_3ST_2ch_modes),
.adc_nids = alc662_adc_nids,
.num_adc_nids = ARRAY_SIZE(alc662_adc_nids),
.capsrc_nids = alc662_capsrc_nids,
.channel_mode = alc662_3ST_2ch_modes,
.input_mux = &alc663_m51va_capture_source,
- .unsol_event = alc663_m51va_unsol_event,
- .init_hook = alc663_m51va_inithook,
+ .unsol_event = alc272_toshiba_unsol_event,
+ .init_hook = alc272_toshiba_inithook,
},


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

SRU: Enable speakers and mic for Toshiba NB200 (Realtek ALC272)
 

Leann Ogasawara wrote:
> On Wed, 2009-11-04 at 07:09 -0800, Tim Gardner wrote:
>> Leann Ogasawara wrote:
>>> Hi All,
>>>
>>> The following set of patches fixes a regression from Hardy to Jaunty on
>>> a a Toshiba NB200 (Realtek ALC272). The set of patches enable sound
>>> from the speakers, mute the speakers when headphones are plugged in, and
>>> also enable the internal mic. The patches were forward ported from
>>> Hardy LUM (netbook-lpia branch). There is a low risk of regression as
>>> we are just adding a new verb table specific to this soundcard/codec.
>>> There are currently 185,000 systems this is known to affect. Please
>>> consider carrying.
>>>
>>> Thanks,
>>> Leann
>>>
>>> The following changes since commit f706cfd92861c7c51f45d722d1398d67bb9d6255:
>>> Stefan Bader (1):
>>> UBUNTU: Ubuntu-2.6.28-16.56
>>>
>>> are available in the git repository at:
>>>
>>> git://kernel.ubuntu.com/ogasawara/ubuntu-jaunty lp438318
>>>
>>> Leann Ogasawara (3):
>>> UBUNTU: SAUCE: Enable speakers for Toshiba NB200 (Realtek ALC272)
>>> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) mute speakers when headphones are plugged in
>>> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) enable microphone
>>>
>>> sound/pci/hda/patch_realtek.c | 79 +++++++++++++++++++++++++++++++++++++++++
>>> 1 files changed, 79 insertions(+), 0 deletions(-)
>>>
>>>
>>>
>>>
>> In alc663_mode1_unsol_event() you are changing entry points for an
>> existing model. Are you _sure_ that won't cause a regression?
>>
>> - .unsol_event = alc663_m51va_unsol_event,
>> - .init_hook = alc663_m51va_inithook,
>> + .unsol_event = alc272_toshiba_unsol_event,
>> + .init_hook = alc272_toshiba_inithook,
>>
>
> I believe the way the patch was formatted makes it look a bit
> misleading. When examining the actual code, you'll see we're actually
> only changing the entry points specific to ALC272_TOSHIBA_NB200 element
> in alc662_presets[]. So yes, I believe this will not cause a
> regression.
>
> static struct alc_config_preset alc662_presets[] = {
> ...
> [ALC272_TOSHIBA_NB200] = {
> .mixers = { alc663_m51va_mixer, alc272_toshiba_mixer, alc662_capture_mixer },
> .init_verbs = { alc662_init_verbs, alc272_toshiba_init_verbs },
> .num_dacs = ARRAY_SIZE(alc662_dac_nids),
> .dac_nids = alc662_dac_nids,
> .num_channel_mode = ARRAY_SIZE(alc662_3ST_2ch_modes),
> .adc_nids = alc662_adc_nids,
> .num_adc_nids = ARRAY_SIZE(alc662_adc_nids),
> .capsrc_nids = alc662_capsrc_nids,
> .channel_mode = alc662_3ST_2ch_modes,
> .input_mux = &alc663_m51va_capture_source,
> - .unsol_event = alc663_m51va_unsol_event,
> - .init_hook = alc663_m51va_inithook,
> + .unsol_event = alc272_toshiba_unsol_event,
> + .init_hook = alc272_toshiba_inithook,
> },
>

OK, then ACK from me.

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

SRU: Enable speakers and mic for Toshiba NB200 (Realtek ALC272)
 

Leann Ogasawara wrote:
> Hi All,
>
> The following set of patches fixes a regression from Hardy to Jaunty on
> a a Toshiba NB200 (Realtek ALC272). The set of patches enable sound
> from the speakers, mute the speakers when headphones are plugged in, and
> also enable the internal mic. The patches were forward ported from
> Hardy LUM (netbook-lpia branch). There is a low risk of regression as
> we are just adding a new verb table specific to this soundcard/codec.
> There are currently 185,000 systems this is known to affect. Please
> consider carrying.
>
> Thanks,
> Leann
>
> The following changes since commit f706cfd92861c7c51f45d722d1398d67bb9d6255:
> Stefan Bader (1):
> UBUNTU: Ubuntu-2.6.28-16.56
>
> are available in the git repository at:
>
> git://kernel.ubuntu.com/ogasawara/ubuntu-jaunty lp438318
>
> Leann Ogasawara (3):
> UBUNTU: SAUCE: Enable speakers for Toshiba NB200 (Realtek ALC272)
> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) mute speakers when headphones are plugged in
> UBUNTU: SAUCE: Toshiba NB200 (Realtek ALC272) enable microphone
>
> sound/pci/hda/patch_realtek.c | 79 +++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 79 insertions(+), 0 deletions(-)
>
>
>
>
Applied all three. A pre-poposed will be uploaded to my Jaunty PPA[1] and later to
proposed.

Stefan

[1] https://launchpad.net/~stefan-bader-canonical/+archive/jaunty

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team