Andy Whitcroft wrote:
> There is a bug in the NFS notifications system that triggers a false
> delete notification when a file is renamed over an existing file.
> This triggers icons to dissappear from the desktop when files are named.
> This is fixed by an upstream commit which corrects the NFS notifications.
>
> Proposing this patch for Jaunty and Intrepid SRU, and in a very slightly
> modified form for Hardy SRU. Has been tested on Jaunty and Hardy by
> the reporters.
>
> -apw
>
> Trond Myklebust (1):
> UBUNTU: SAUCE: NFS: Fix the notifications when renaming onto an
> existing file
>
> fs/nfs/dir.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
>

This patch looks reasonable, but Linus' tree has the original code
(therefore the patch did not originate from upstream Linus). You kind of
imply that this NFS bug is "fixed by an upstream commit which corrects
the NFS notifications", but I'm not seeing how that is done in Linus
tree. Can you elaborate? Is this a patch that is ready for the 2.6.30
merge window?

rtg
--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

On Wed, Mar 25, 2009 at 01:04:02PM -0600, Tim Gardner wrote:
> Andy Whitcroft wrote:
> > There is a bug in the NFS notifications system that triggers a false
> > delete notification when a file is renamed over an existing file.
> > This triggers icons to dissappear from the desktop when files are named.
> > This is fixed by an upstream commit which corrects the NFS notifications.
> >
> > Proposing this patch for Jaunty and Intrepid SRU, and in a very slightly
> > modified form for Hardy SRU. Has been tested on Jaunty and Hardy by
> > the reporters.
> >
> > -apw
> >
> > Trond Myklebust (1):
> > UBUNTU: SAUCE: NFS: Fix the notifications when renaming onto an
> > existing file
> >
> > fs/nfs/dir.c | 9 ++++-----
> > 1 files changed, 4 insertions(+), 5 deletions(-)
> >
> >
>
> This patch looks reasonable, but Linus' tree has the original code
> (therefore the patch did not originate from upstream Linus). You kind of
> imply that this NFS bug is "fixed by an upstream commit which corrects
> the NFS notifications", but I'm not seeing how that is done in Linus
> tree. Can you elaborate? Is this a patch that is ready for the 2.6.30
> merge window?

Yes that wording is unclear. It is a patch by Trond who is all things
NFS. It has come from the upsteam bugzilla. But I should clarify its
status before we go any further. Thanks for the nudge.

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Andy Whitcroft wrote:
> There is a bug in the NFS notifications system that triggers a false
> delete notification when a file is renamed over an existing file.
> This triggers icons to dissappear from the desktop when files are named.
> This is fixed by an upstream commit which corrects the NFS notifications.
>
> Proposing this patch for Jaunty and Intrepid SRU, and in a very slightly
> modified form for Hardy SRU. Has been tested on Jaunty and Hardy by
> the reporters.
>
> -apw
>
> Trond Myklebust (1):
> UBUNTU: SAUCE: NFS: Fix the notifications when renaming onto an
> existing file
>
> fs/nfs/dir.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
>
The patch looks reasonable. ACK for that, but surely Tim is right about the
origins. Depending on the urgency of the bug the question is whether we should
wait for Hardy and Intrepid until it is merged to Linus tree.

--

When all other means of communication fail, try words!



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

On Wed, Mar 25, 2009 at 07:34:38PM +0000, Andy Whitcroft wrote:
> On Wed, Mar 25, 2009 at 01:04:02PM -0600, Tim Gardner wrote:

> Yes that wording is unclear. It is a patch by Trond who is all things
> NFS. It has come from the upsteam bugzilla. But I should clarify its
> status before we go any further. Thanks for the nudge.

Ok, Trond says that it is queued for 2.6.30. So its going to be
upstream but as yet does not have a stable sha1.

-apw

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

Andy Whitcroft wrote:
> On Wed, Mar 25, 2009 at 07:34:38PM +0000, Andy Whitcroft wrote:
>> On Wed, Mar 25, 2009 at 01:04:02PM -0600, Tim Gardner wrote:
>
>> Yes that wording is unclear. It is a patch by Trond who is all things
>> NFS. It has come from the upsteam bugzilla. But I should clarify its
>> status before we go any further. Thanks for the nudge.
>
> Ok, Trond says that it is queued for 2.6.30. So its going to be
> upstream but as yet does not have a stable sha1.
>
> -apw

ACK - I'm fine with it, especially since it has proved to fix some problems.

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team