FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 01-22-2009, 12:53 PM
Tim Gardner
 
Default UBUNTU: Return 0 when ABI skip is requested and no ABI files exist.

OriginalAuthor: Amit Kucheria <amit.kucheria@ubuntu.com>

The previous version of abi-check would return an error if a flavour
ABI ignore file existed and there were no ABI files for the flavour (a
common mistake).

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
debian/scripts/abi-check | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/debian/scripts/abi-check b/debian/scripts/abi-check
index abef5f7..b7df0d8 100755
--- a/debian/scripts/abi-check
+++ b/debian/scripts/abi-check
@@ -10,6 +10,7 @@ my $skipabi = shift;
my $fail_exit = 1;
my $EE = "EE:";
my $errors = 0;
+my $abiskip = 0;

my $count;

@@ -19,6 +20,7 @@ if (-f "$prev_abidir/ignore"
or -f "$prev_abidir/$flavour.ignore" or "$skipabi" eq "true") {
print "WW: Explicitly asked to ignore ABI, running in no-fail mode
";
$fail_exit = 0;
+ $abiskip = 1;
$EE = "WW:";
}

@@ -32,8 +34,14 @@ if (not -f "$abidir/$flavour" or not -f "$prev_abidir/$flavour") {
print "EE: Previous or current ABI file missing!
";
print " $abidir/$flavour
" if not -f "$abidir/$flavour";
print " $prev_abidir/$flavour
" if not -f "$prev_abidir/$flavour";
- # Always fail here. This is bad
- exit(1);
+
+ # Exit if the ABI files are missing, but return status based on whether
+ # skip ABI was indicated.
+ if ("$abiskip" eq "1") {
+ exit(0);
+ } else {
+ exit(1);
+ }
}

my %symbols;
--
1.5.6.3


--------------030407060302080004060005
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

--------------030407060302080004060005--
 

Thread Tools




All times are GMT. The time now is 10:44 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org