FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 12-02-2008, 11:35 AM
Stefan Bader
 
Default UBUNTU: SAUCE: serial: RS485 ioctl structure uses __u32 include linux/types.h

GAndy Whitcroft wrote:
> Bug: #303711
>
> In the commit below a new struct serial_rs485 was introduced for a new
> ioctl:
>
> commit c26c56c0f40e200e61d1390629c806f6adaffbcc
> Author: Alan Cox <alan@redhat.com>
> Date: Mon Oct 13 10:37:48 2008 +0100
>
> tty: Cris has a nice RS485 ioctl so we should steal it
>
> This structure uses the __u32 types for some of its members, which leads
> to the following compile error:
>
> $ cc -I.../include -c X.c
> In file included from X.c:2: .../include/linux/serial.h:185:
> error: expected specifier-qualifier-list before ‘__u32’
> $
>
> It seems that these types are appropriate for this structure as it is
> to be exposed to userspace. These types are available via linux/types.h
> so move the include of that outside the __KERNEL__ section.
>
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
> ---
> include/linux/serial.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/serial.h b/include/linux/serial.h
> index 1ea8d92..9136cc5 100644
> --- a/include/linux/serial.h
> +++ b/include/linux/serial.h
> @@ -10,8 +10,9 @@
> #ifndef _LINUX_SERIAL_H
> #define _LINUX_SERIAL_H
>
> -#ifdef __KERNEL__
> #include <linux/types.h>
> +
> +#ifdef __KERNEL__
> #include <asm/page.h>
>
> /*


ACK
--

When all other means of communication fail, try words!




--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 03:57 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org